[PATCH] iproute2.inc: clean .o before do_configure

[PATCH] iproute2.inc: clean .o before do_configure

[Changqing Li]

From: Changqing Li <changqing.li@windriver.com>

Reproduce steps:
1. add 'DISTRO_FEATURES_append = ' usrmerge'' in local.conf
2. bitbake iproute2
3. remove 'DISTRO_FEATURES_append = ' usrmerge'' from local.conf
4. bitbake iproute2

In step4, since CLEANBROKEN is set, files generated in step2 is not
cleaned and rebuilded. Check after step4:

file /sbin/ip.iproute2
/sbin/ip.iproute2: ELF 64-bit LSB pie executable, x86-64, version 1
(SYSV), dynamically linked, interpreter /usr/lib64/ld-linux-x86-64.so.2,

interpreter path is wrong, it should be  /lib64/ld-linux-x86-64.so.2

This will make run ip.iproute2 report error:
-sh: /sbin/ip.iproute2: No such file or directory

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta/recipes-connectivity/iproute2/iproute2.inc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-connectivity/iproute2/iproute2.inc b/meta/recipes-connectivity/iproute2/iproute2.inc
index 403d264..e70620c 100644
--- a/meta/recipes-connectivity/iproute2/iproute2.inc
+++ b/meta/recipes-connectivity/iproute2/iproute2.inc
@@ -29,6 +29,10 @@ EXTRA_OEMAKE = "\
     LIBDIR='${libdir}' \
 "
 
+do_configure_prepend () {
+    find ${B} -ignore_readdir_race -name \*.o -type f -print0 | xargs -0 rm -f
+}
+
 do_configure_append () {
     sh configure ${STAGING_INCDIR}
     # Explicitly disable ATM support
-- 
2.7.4

Re: [OE-core] [PATCH] iproute2.inc: clean .o before do_configure

[Jacob Kroon]

On 5/7/20 4:05 AM, Changqing Li wrote:
> From: Changqing Li <changqing.li@windriver.com>
> 
> Reproduce steps:
> 1. add 'DISTRO_FEATURES_append = ' usrmerge'' in local.conf
> 2. bitbake iproute2
> 3. remove 'DISTRO_FEATURES_append = ' usrmerge'' from local.conf
> 4. bitbake iproute2
> 
> In step4, since CLEANBROKEN is set, files generated in step2 is not
> cleaned and rebuilded. Check after step4:
> 
> file /sbin/ip.iproute2
> /sbin/ip.iproute2: ELF 64-bit LSB pie executable, x86-64, version 1
> (SYSV), dynamically linked, interpreter /usr/lib64/ld-linux-x86-64.so.2,
> 
> interpreter path is wrong, it should be  /lib64/ld-linux-x86-64.so.2
> 
> This will make run ip.iproute2 report error:
> -sh: /sbin/ip.iproute2: No such file or directory
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>   meta/recipes-connectivity/iproute2/iproute2.inc | 4 ++++
>   1 file changed, 4 insertions(+)
> 

Isn't this a general problem, and not specific to just iproute2 ?

Re: [OE-core] [PATCH] iproute2.inc: clean .o before do_configure

[Changqing Li]

On 5/7/20 1:56 PM, Jacob Kroon wrote:
> On 5/7/20 4:05 AM, Changqing Li wrote:
>> From: Changqing Li <changqing.li@windriver.com>
>>
>> Reproduce steps:
>> 1. add 'DISTRO_FEATURES_append = ' usrmerge'' in local.conf
>> 2. bitbake iproute2
>> 3. remove 'DISTRO_FEATURES_append = ' usrmerge'' from local.conf
>> 4. bitbake iproute2
>>
>> In step4, since CLEANBROKEN is set, files generated in step2 is not
>> cleaned and rebuilded. Check after step4:
>>
>> file /sbin/ip.iproute2
>> /sbin/ip.iproute2: ELF 64-bit LSB pie executable, x86-64, version 1
>> (SYSV), dynamically linked, interpreter /usr/lib64/ld-linux-x86-64.so.2,
>>
>> interpreter path is wrong, it should be /lib64/ld-linux-x86-64.so.2
>>
>> This will make run ip.iproute2 report error:
>> -sh: /sbin/ip.iproute2: No such file or directory
>>
>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> ---
>>   meta/recipes-connectivity/iproute2/iproute2.inc | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>
> Isn't this a general problem, and not specific to just iproute2 ?

For  those recipe ${B} != ${S} ,  ${B} will be cleaned,  will not have 
this problem.

and by default, CLEANBROKEN is not set,  make clean will be executed.

but for this specific recipe,  both condition not matched.

Re: [OE-core] [PATCH] iproute2.inc: clean .o before do_configure

[Jacob Kroon]

On 5/7/20 8:10 AM, Changqing Li wrote:
> On 5/7/20 1:56 PM, Jacob Kroon wrote:
>> On 5/7/20 4:05 AM, Changqing Li wrote:
>>> From: Changqing Li <changqing.li@windriver.com>
>>>
>>> Reproduce steps:
>>> 1. add 'DISTRO_FEATURES_append = ' usrmerge'' in local.conf
>>> 2. bitbake iproute2
>>> 3. remove 'DISTRO_FEATURES_append = ' usrmerge'' from local.conf
>>> 4. bitbake iproute2
>>>
>>> In step4, since CLEANBROKEN is set, files generated in step2 is not
>>> cleaned and rebuilded. Check after step4:
>>>
>>> file /sbin/ip.iproute2
>>> /sbin/ip.iproute2: ELF 64-bit LSB pie executable, x86-64, version 1
>>> (SYSV), dynamically linked, interpreter /usr/lib64/ld-linux-x86-64.so.2,
>>>
>>> interpreter path is wrong, it should be /lib64/ld-linux-x86-64.so.2
>>>
>>> This will make run ip.iproute2 report error:
>>> -sh: /sbin/ip.iproute2: No such file or directory
>>>
>>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>>> ---
>>>   meta/recipes-connectivity/iproute2/iproute2.inc | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>
>> Isn't this a general problem, and not specific to just iproute2 ?
> 
> For  those recipe ${B} != ${S} ,  ${B} will be cleaned,  will not have 
> this problem.
> 
> and by default, CLEANBROKEN is not set,  make clean will be executed.
> 
> but for this specific recipe,  both condition not matched.
> 
> 

btrfs-tools inherits autotools-brokensep and sets CLEANBROKEN = "1", 
will it also require a similar fix ?

Re: [OE-core] [PATCH] iproute2.inc: clean .o before do_configure

[Changqing Li]

On 5/7/20 2:19 PM, Jacob Kroon wrote:
> On 5/7/20 8:10 AM, Changqing Li wrote:
>> On 5/7/20 1:56 PM, Jacob Kroon wrote:
>>> On 5/7/20 4:05 AM, Changqing Li wrote:
>>>> From: Changqing Li <changqing.li@windriver.com>
>>>>
>>>> Reproduce steps:
>>>> 1. add 'DISTRO_FEATURES_append = ' usrmerge'' in local.conf
>>>> 2. bitbake iproute2
>>>> 3. remove 'DISTRO_FEATURES_append = ' usrmerge'' from local.conf
>>>> 4. bitbake iproute2
>>>>
>>>> In step4, since CLEANBROKEN is set, files generated in step2 is not
>>>> cleaned and rebuilded. Check after step4:
>>>>
>>>> file /sbin/ip.iproute2
>>>> /sbin/ip.iproute2: ELF 64-bit LSB pie executable, x86-64, version 1
>>>> (SYSV), dynamically linked, interpreter 
>>>> /usr/lib64/ld-linux-x86-64.so.2,
>>>>
>>>> interpreter path is wrong, it should be /lib64/ld-linux-x86-64.so.2
>>>>
>>>> This will make run ip.iproute2 report error:
>>>> -sh: /sbin/ip.iproute2: No such file or directory
>>>>
>>>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>>>> ---
>>>>   meta/recipes-connectivity/iproute2/iproute2.inc | 4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>>
>>>
>>> Isn't this a general problem, and not specific to just iproute2 ?
>>
>> For  those recipe ${B} != ${S} ,  ${B} will be cleaned,  will not 
>> have this problem.
>>
>> and by default, CLEANBROKEN is not set,  make clean will be executed.
>>
>> but for this specific recipe,  both condition not matched.
>>
>>
>
> btrfs-tools inherits autotools-brokensep and sets CLEANBROKEN = "1", 
> will it also require a similar fix ?

In theory， btrfs-tools and other recipes like this will met similar 
problem.


But I tested on btrfs-tools, it don't met problem even without clean, 
since some dependency changed, so

binary btrfs also recompiled. so this is also related to respective 
makefile.


And your suggestion to make it commons also make sense,  in this way,  
we need to

handle condition (${B} and ${S} is same,and CLEANBROKEN = "1")

in base.bbclass and autotools-brokensep.bbclass.   But one problem here 
is  that

we have kinds of recipes,  not all Intermediate file are *.o, how to 
handle this, any suggestion?

or still handle this in seperate recipes?