All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Wei Liu" <wei.liu2@citrix.com>,
	"Nakajima, Jun" <jun.nakajima@intel.com>,
	"Jan Beulich" <JBeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2] x86/msr: Fix fallout from mostly c/s 832c180
Date: Wed, 24 Apr 2019 06:46:48 +0000	[thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D19C9F96AE@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1555329809-3248-1-git-send-email-andrew.cooper3@citrix.com>

> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
> Sent: Monday, April 15, 2019 8:03 PM
> 
>  * Fix the shim build by providing a !CONFIG_HVM declaration for
>    hvm_get_guest_bndcfgs(), and removing the introduced
>    ASSERT(is_hvm_domain(d))'s.  They are needed for DCE to keep the build
>    working.  Furthermore, in this way, the risk of runtime type confusion is
>    removed.
>  * Revert the de-const'ing of the vcpu pointer in vmx_get_guest_bndcfgs().
>    vmx_vmcs_enter() really does mutate the vcpu, and may cause it to undergo
> a
>    full de/reschedule, which is in violation of the ABI described by
>    hvm_get_guest_bndcfgs().  guest_rdmsr() was always going to need to lose
>    its const parameter, and this was the correct time for it to happen.
>  * The MSRs in vcpu_msrs are in numeric order.  Re-position XSS to match.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Paul Durrant <paul.durrant@citrix.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Wei Liu" <wei.liu2@citrix.com>,
	"Nakajima, Jun" <jun.nakajima@intel.com>,
	"Jan Beulich" <JBeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] x86/msr: Fix fallout from mostly c/s 832c180
Date: Wed, 24 Apr 2019 06:46:48 +0000	[thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D19C9F96AE@SHSMSX104.ccr.corp.intel.com> (raw)
Message-ID: <20190424064648.xgyc9bAS3nTgy8ER9MG_XUOrgo5ZiU_yOHMopCWh410@z> (raw)
In-Reply-To: <1555329809-3248-1-git-send-email-andrew.cooper3@citrix.com>

> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
> Sent: Monday, April 15, 2019 8:03 PM
> 
>  * Fix the shim build by providing a !CONFIG_HVM declaration for
>    hvm_get_guest_bndcfgs(), and removing the introduced
>    ASSERT(is_hvm_domain(d))'s.  They are needed for DCE to keep the build
>    working.  Furthermore, in this way, the risk of runtime type confusion is
>    removed.
>  * Revert the de-const'ing of the vcpu pointer in vmx_get_guest_bndcfgs().
>    vmx_vmcs_enter() really does mutate the vcpu, and may cause it to undergo
> a
>    full de/reschedule, which is in violation of the ABI described by
>    hvm_get_guest_bndcfgs().  guest_rdmsr() was always going to need to lose
>    its const parameter, and this was the correct time for it to happen.
>  * The MSRs in vcpu_msrs are in numeric order.  Re-position XSS to match.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Paul Durrant <paul.durrant@citrix.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-04-24  6:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 12:03 [PATCH v2] x86/msr: Fix fallout from mostly c/s 832c180 Andrew Cooper
2019-04-15 12:03 ` [Xen-devel] " Andrew Cooper
2019-04-15 15:49 ` Jan Beulich
2019-04-15 15:49   ` [Xen-devel] " Jan Beulich
2019-04-16 10:53 ` Paul Durrant
2019-04-16 10:53   ` [Xen-devel] " Paul Durrant
2019-04-24  6:46 ` Tian, Kevin [this message]
2019-04-24  6:46   ` Tian, Kevin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D19C9F96AE@SHSMSX104.ccr.corp.intel.com \
    --to=kevin.tian@intel.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.