* [PATCH] ARM: dts: imx7d: use operating-points-v2 for cpu
@ 2018-05-16 4:48 ` Anson Huang
0 siblings, 0 replies; 6+ messages in thread
From: Anson Huang @ 2018-05-16 4:48 UTC (permalink / raw)
To: shawnguo, kernel, fabio.estevam, robh+dt, mark.rutland
Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel
This patch uses "operating-points-v2" instead of
"operating-points" to be more fit with cpufreq-dt
driver.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm/boot/dts/imx7d.dtsi | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 4c9877e..28980c8 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -9,12 +9,8 @@
/ {
cpus {
cpu0: cpu@0 {
- operating-points = <
- /* KHz uV */
- 996000 1075000
- 792000 975000
- >;
clock-frequency = <996000000>;
+ operating-points-v2 = <&cpu0_opp_table>;
};
cpu1: cpu@1 {
@@ -22,6 +18,24 @@
device_type = "cpu";
reg = <1>;
clock-frequency = <996000000>;
+ operating-points-v2 = <&cpu0_opp_table>;
+ };
+ };
+
+ cpu0_opp_table: opp_table0 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp-792000000 {
+ opp-hz = /bits/ 64 <792000000>;
+ opp-microvolt = <975000>;
+ clock-latency-ns = <150000>;
+ };
+ opp-996000000 {
+ opp-hz = /bits/ 64 <996000000>;
+ opp-microvolt = <1075000>;
+ clock-latency-ns = <150000>;
+ opp-suspend;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: imx7d: use operating-points-v2 for cpu
@ 2018-05-16 4:48 ` Anson Huang
0 siblings, 0 replies; 6+ messages in thread
From: Anson Huang @ 2018-05-16 4:48 UTC (permalink / raw)
To: linux-arm-kernel
This patch uses "operating-points-v2" instead of
"operating-points" to be more fit with cpufreq-dt
driver.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm/boot/dts/imx7d.dtsi | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 4c9877e..28980c8 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -9,12 +9,8 @@
/ {
cpus {
cpu0: cpu at 0 {
- operating-points = <
- /* KHz uV */
- 996000 1075000
- 792000 975000
- >;
clock-frequency = <996000000>;
+ operating-points-v2 = <&cpu0_opp_table>;
};
cpu1: cpu at 1 {
@@ -22,6 +18,24 @@
device_type = "cpu";
reg = <1>;
clock-frequency = <996000000>;
+ operating-points-v2 = <&cpu0_opp_table>;
+ };
+ };
+
+ cpu0_opp_table: opp_table0 {
+ compatible = "operating-points-v2";
+ opp-shared;
+
+ opp-792000000 {
+ opp-hz = /bits/ 64 <792000000>;
+ opp-microvolt = <975000>;
+ clock-latency-ns = <150000>;
+ };
+ opp-996000000 {
+ opp-hz = /bits/ 64 <996000000>;
+ opp-microvolt = <1075000>;
+ clock-latency-ns = <150000>;
+ opp-suspend;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx7d: use operating-points-v2 for cpu
2018-05-16 4:48 ` Anson Huang
@ 2018-05-20 12:50 ` Shawn Guo
-1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-05-20 12:50 UTC (permalink / raw)
To: Anson Huang
Cc: kernel, fabio.estevam, robh+dt, mark.rutland, Linux-imx,
linux-arm-kernel, devicetree, linux-kernel
On Wed, May 16, 2018 at 12:48:17PM +0800, Anson Huang wrote:
> This patch uses "operating-points-v2" instead of
> "operating-points" to be more fit with cpufreq-dt
> driver.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm/boot/dts/imx7d.dtsi | 24 +++++++++++++++++++-----
> 1 file changed, 19 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 4c9877e..28980c8 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -9,12 +9,8 @@
> / {
> cpus {
> cpu0: cpu@0 {
> - operating-points = <
> - /* KHz uV */
> - 996000 1075000
> - 792000 975000
> - >;
> clock-frequency = <996000000>;
> + operating-points-v2 = <&cpu0_opp_table>;
> };
>
> cpu1: cpu@1 {
> @@ -22,6 +18,24 @@
> device_type = "cpu";
> reg = <1>;
> clock-frequency = <996000000>;
> + operating-points-v2 = <&cpu0_opp_table>;
> + };
> + };
> +
> + cpu0_opp_table: opp_table0 {
Hyphen is recommended in node name. Also the suffix 0 doesn't mean too
much here. That said, a better node name would be 'opp-table'.
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp-792000000 {
> + opp-hz = /bits/ 64 <792000000>;
> + opp-microvolt = <975000>;
> + clock-latency-ns = <150000>;
> + };
We recommend to have a newline between nodes.
I fixed them all and applied the patch.
Shawn
> + opp-996000000 {
> + opp-hz = /bits/ 64 <996000000>;
> + opp-microvolt = <1075000>;
> + clock-latency-ns = <150000>;
> + opp-suspend;
> };
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: imx7d: use operating-points-v2 for cpu
@ 2018-05-20 12:50 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-05-20 12:50 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 16, 2018 at 12:48:17PM +0800, Anson Huang wrote:
> This patch uses "operating-points-v2" instead of
> "operating-points" to be more fit with cpufreq-dt
> driver.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm/boot/dts/imx7d.dtsi | 24 +++++++++++++++++++-----
> 1 file changed, 19 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 4c9877e..28980c8 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -9,12 +9,8 @@
> / {
> cpus {
> cpu0: cpu at 0 {
> - operating-points = <
> - /* KHz uV */
> - 996000 1075000
> - 792000 975000
> - >;
> clock-frequency = <996000000>;
> + operating-points-v2 = <&cpu0_opp_table>;
> };
>
> cpu1: cpu at 1 {
> @@ -22,6 +18,24 @@
> device_type = "cpu";
> reg = <1>;
> clock-frequency = <996000000>;
> + operating-points-v2 = <&cpu0_opp_table>;
> + };
> + };
> +
> + cpu0_opp_table: opp_table0 {
Hyphen is recommended in node name. Also the suffix 0 doesn't mean too
much here. That said, a better node name would be 'opp-table'.
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp-792000000 {
> + opp-hz = /bits/ 64 <792000000>;
> + opp-microvolt = <975000>;
> + clock-latency-ns = <150000>;
> + };
We recommend to have a newline between nodes.
I fixed them all and applied the patch.
Shawn
> + opp-996000000 {
> + opp-hz = /bits/ 64 <996000000>;
> + opp-microvolt = <1075000>;
> + clock-latency-ns = <150000>;
> + opp-suspend;
> };
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] ARM: dts: imx7d: use operating-points-v2 for cpu
2018-05-20 12:50 ` Shawn Guo
@ 2018-05-21 1:58 ` Anson Huang
-1 siblings, 0 replies; 6+ messages in thread
From: Anson Huang @ 2018-05-21 1:58 UTC (permalink / raw)
To: Shawn Guo
Cc: kernel, Fabio Estevam, robh+dt, mark.rutland, dl-linux-imx,
linux-arm-kernel, devicetree, linux-kernel
Anson Huang
Best Regards!
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Sunday, May 20, 2018 8:51 PM
> To: Anson Huang <anson.huang@nxp.com>
> Cc: kernel@pengutronix.de; Fabio Estevam <fabio.estevam@nxp.com>;
> robh+dt@kernel.org; mark.rutland@arm.com; dl-linux-imx
> <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ARM: dts: imx7d: use operating-points-v2 for cpu
>
> On Wed, May 16, 2018 at 12:48:17PM +0800, Anson Huang wrote:
> > This patch uses "operating-points-v2" instead of "operating-points" to
> > be more fit with cpufreq-dt driver.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > arch/arm/boot/dts/imx7d.dtsi | 24 +++++++++++++++++++-----
> > 1 file changed, 19 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx7d.dtsi
> > b/arch/arm/boot/dts/imx7d.dtsi index 4c9877e..28980c8 100644
> > --- a/arch/arm/boot/dts/imx7d.dtsi
> > +++ b/arch/arm/boot/dts/imx7d.dtsi
> > @@ -9,12 +9,8 @@
> > / {
> > cpus {
> > cpu0: cpu@0 {
> > - operating-points = <
> > - /* KHz uV */
> > - 996000 1075000
> > - 792000 975000
> > - >;
> > clock-frequency = <996000000>;
> > + operating-points-v2 = <&cpu0_opp_table>;
> > };
> >
> > cpu1: cpu@1 {
> > @@ -22,6 +18,24 @@
> > device_type = "cpu";
> > reg = <1>;
> > clock-frequency = <996000000>;
> > + operating-points-v2 = <&cpu0_opp_table>;
> > + };
> > + };
> > +
> > + cpu0_opp_table: opp_table0 {
>
> Hyphen is recommended in node name. Also the suffix 0 doesn't mean too
> much here. That said, a better node name would be 'opp-table'.
>
> > + compatible = "operating-points-v2";
> > + opp-shared;
> > +
> > + opp-792000000 {
> > + opp-hz = /bits/ 64 <792000000>;
> > + opp-microvolt = <975000>;
> > + clock-latency-ns = <150000>;
> > + };
>
> We recommend to have a newline between nodes.
>
> I fixed them all and applied the patch.
>
> Shawn
Thanks Shawn.
Anson.
>
> > + opp-996000000 {
> > + opp-hz = /bits/ 64 <996000000>;
> > + opp-microvolt = <1075000>;
> > + clock-latency-ns = <150000>;
> > + opp-suspend;
> > };
> > };
> >
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: imx7d: use operating-points-v2 for cpu
@ 2018-05-21 1:58 ` Anson Huang
0 siblings, 0 replies; 6+ messages in thread
From: Anson Huang @ 2018-05-21 1:58 UTC (permalink / raw)
To: linux-arm-kernel
Anson Huang
Best Regards!
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo at kernel.org]
> Sent: Sunday, May 20, 2018 8:51 PM
> To: Anson Huang <anson.huang@nxp.com>
> Cc: kernel at pengutronix.de; Fabio Estevam <fabio.estevam@nxp.com>;
> robh+dt at kernel.org; mark.rutland at arm.com; dl-linux-imx
> <linux-imx@nxp.com>; linux-arm-kernel at lists.infradead.org;
> devicetree at vger.kernel.org; linux-kernel at vger.kernel.org
> Subject: Re: [PATCH] ARM: dts: imx7d: use operating-points-v2 for cpu
>
> On Wed, May 16, 2018 at 12:48:17PM +0800, Anson Huang wrote:
> > This patch uses "operating-points-v2" instead of "operating-points" to
> > be more fit with cpufreq-dt driver.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > arch/arm/boot/dts/imx7d.dtsi | 24 +++++++++++++++++++-----
> > 1 file changed, 19 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx7d.dtsi
> > b/arch/arm/boot/dts/imx7d.dtsi index 4c9877e..28980c8 100644
> > --- a/arch/arm/boot/dts/imx7d.dtsi
> > +++ b/arch/arm/boot/dts/imx7d.dtsi
> > @@ -9,12 +9,8 @@
> > / {
> > cpus {
> > cpu0: cpu at 0 {
> > - operating-points = <
> > - /* KHz uV */
> > - 996000 1075000
> > - 792000 975000
> > - >;
> > clock-frequency = <996000000>;
> > + operating-points-v2 = <&cpu0_opp_table>;
> > };
> >
> > cpu1: cpu at 1 {
> > @@ -22,6 +18,24 @@
> > device_type = "cpu";
> > reg = <1>;
> > clock-frequency = <996000000>;
> > + operating-points-v2 = <&cpu0_opp_table>;
> > + };
> > + };
> > +
> > + cpu0_opp_table: opp_table0 {
>
> Hyphen is recommended in node name. Also the suffix 0 doesn't mean too
> much here. That said, a better node name would be 'opp-table'.
>
> > + compatible = "operating-points-v2";
> > + opp-shared;
> > +
> > + opp-792000000 {
> > + opp-hz = /bits/ 64 <792000000>;
> > + opp-microvolt = <975000>;
> > + clock-latency-ns = <150000>;
> > + };
>
> We recommend to have a newline between nodes.
>
> I fixed them all and applied the patch.
>
> Shawn
Thanks Shawn.
Anson.
>
> > + opp-996000000 {
> > + opp-hz = /bits/ 64 <996000000>;
> > + opp-microvolt = <1075000>;
> > + clock-latency-ns = <150000>;
> > + opp-suspend;
> > };
> > };
> >
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-21 1:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 4:48 [PATCH] ARM: dts: imx7d: use operating-points-v2 for cpu Anson Huang
2018-05-16 4:48 ` Anson Huang
2018-05-20 12:50 ` Shawn Guo
2018-05-20 12:50 ` Shawn Guo
2018-05-21 1:58 ` Anson Huang
2018-05-21 1:58 ` Anson Huang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.