[tpm2] Re: CFLAGS and LIBS defines for tss versus other tpm2 projects

[tpm2] Re: CFLAGS and LIBS defines for tss versus other tpm2 projects

[Fuchs, Andreas]

[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]

I don't mind at all...

________________________________________
Von: Roberts, William C <william.c.roberts(a)intel.com>
Gesendet: Donnerstag, 9. September 2021 19:08
An: tpm2(a)lists.01.org
Betreff: [tpm2] CFLAGS and LIBS defines for tss versus other tpm2 projects

So in all of the projects that need libcrypto, the configure.ac check using PKG_CHECK_MODULES
uses "CRYPTO" except tss project which uses LIBCRYPT. This means that when exporting variables
for building against a custom libcrypto, the variables will be LIBCRYPTO_CFLAGS and LIBCRYPTO_LIBS,
where as all the other projects are just CRYPTO_CFLAGS and CRYPTO_LIBS. While it's not difficult to
set both variables, I was wondering if we could unify this around CRYPTO (without the lib prefix) and
if we consider configure.ac to be stable, ie if we made this change would we make someones life miserable?

Thanks,
Bill

Configure.ac snippets below.

tpm2-openssl/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 3.0.0],
tpm2-pkcs11/configure.ac:PKG_CHECK_MODULES([CRYPTO],      [libcrypto >= 1.1.0])
tpm2-tools/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 1.1.0])
tpm2-tss/configure.ac:           PKG_CHECK_MODULES([LIBCRYPTO],
tpm2-tss/configure.ac:           [PKG_CHECK_MODULES([LIBCRYPTO],[libcrypto])])
tpm2-tss-engine/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 1.0.2g],