Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

[Shlomo Pongratz <shlomo.pongratz@huawei.com>]

> -----Original Message-----
> From: Pavel Fedin [mailto:p.fedin@samsung.com]
> Sent: Tuesday, 12 May, 2015 12:06 PM
> To: Shlomo Pongratz; qemu-devel@nongnu.org
> Subject: RE: [PATCH v2] Add virt-v3 machine that uses GIC-500
> 
>  Hello!
> 
> > I just pulled last git and git am-ed your patch on-top of my first 3
> > patches and got
> this error:
> > /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c: In function
> 'fdt_add_gic_node':
> > /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c:366:17: error:
> > 'KVM_DEV_TYPE_ARM_VGIC_V3' undeclared (first use in this function)
> >      if (type == KVM_DEV_TYPE_ARM_VGIC_V3) {
> 
>  Very strange. Check your source tree. This value is declared in linux-
> headers/linux/kvm.h. Try to #include it directly maybe ? OTOH it perfectly
> works for me, i have just verified, i have no extra #include's which could be
> missing from the patch.
>  But, may be something has changed in master over the last three days?
> Actually my base tree is from friday.
> 
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
> 

Hi Pavel,

I did include "linux/kvm.h" which fixed the issue.
But as I wrote I did "git pull" before applying the patches, so it is strange.

BTW did you try going beyond 16 cores I had problems with 32 and 64 cores.

Best regards,

S.P.