From: "Tian, Kevin" <kevin.tian@intel.com> To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, Steve Wahl <steve.wahl@hpe.com> Cc: Dimitri Sivanich <sivanich@hpe.com>, "Anderson, Russ" <russ.anderson@hpe.com>, Mike Travis <mike.travis@hpe.com>, Jerry Snitselaar <jsnitsel@redhat.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>, David Woodhouse <dwmw2@infradead.org> Subject: RE: [PATCH v1 2/6] iommu/vt-d: Use IDA interface to manage iommu sequence id Date: Thu, 30 Jun 2022 08:21:51 +0000 [thread overview] Message-ID: <BL1PR11MB5271C0143C8EA440BDAF45828CBA9@BL1PR11MB5271.namprd11.prod.outlook.com> (raw) In-Reply-To: <20220625125204.2199437-3-baolu.lu@linux.intel.com> > From: Lu Baolu <baolu.lu@linux.intel.com> > Sent: Saturday, June 25, 2022 8:52 PM > > @@ -1062,11 +1040,14 @@ static int alloc_iommu(struct dmar_drhd_unit > *drhd) > if (!iommu) > return -ENOMEM; > > - if (dmar_alloc_seq_id(iommu) < 0) { > + iommu->seq_id = ida_alloc_range(&dmar_seq_ids, 0, > + DMAR_UNITS_SUPPORTED, should be "DMAR_UNITS_SUPPORTED - 1" > GFP_KERNEL); > + if (iommu->seq_id < 0) { > pr_err("Failed to allocate seq_id\n"); > err = -ENOSPC; > goto error; > } ida_alloc_range() returns error code already. No need to change it. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: "Tian, Kevin" <kevin.tian@intel.com> To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, Steve Wahl <steve.wahl@hpe.com> Cc: David Woodhouse <dwmw2@infradead.org>, Jerry Snitselaar <jsnitsel@redhat.com>, Mike Travis <mike.travis@hpe.com>, Dimitri Sivanich <sivanich@hpe.com>, "Anderson, Russ" <russ.anderson@hpe.com>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v1 2/6] iommu/vt-d: Use IDA interface to manage iommu sequence id Date: Thu, 30 Jun 2022 08:21:51 +0000 [thread overview] Message-ID: <BL1PR11MB5271C0143C8EA440BDAF45828CBA9@BL1PR11MB5271.namprd11.prod.outlook.com> (raw) In-Reply-To: <20220625125204.2199437-3-baolu.lu@linux.intel.com> > From: Lu Baolu <baolu.lu@linux.intel.com> > Sent: Saturday, June 25, 2022 8:52 PM > > @@ -1062,11 +1040,14 @@ static int alloc_iommu(struct dmar_drhd_unit > *drhd) > if (!iommu) > return -ENOMEM; > > - if (dmar_alloc_seq_id(iommu) < 0) { > + iommu->seq_id = ida_alloc_range(&dmar_seq_ids, 0, > + DMAR_UNITS_SUPPORTED, should be "DMAR_UNITS_SUPPORTED - 1" > GFP_KERNEL); > + if (iommu->seq_id < 0) { > pr_err("Failed to allocate seq_id\n"); > err = -ENOSPC; > goto error; > } ida_alloc_range() returns error code already. No need to change it.
next prev parent reply other threads:[~2022-06-30 8:22 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-25 12:51 [PATCH v1 0/6] iommu/vt-d: Reset DMAR_UNITS_SUPPORTED Lu Baolu 2022-06-25 12:51 ` Lu Baolu 2022-06-25 12:51 ` [PATCH v1 1/6] iommu/vt-d: Remove unused domain_get_iommu() Lu Baolu 2022-06-25 12:51 ` Lu Baolu 2022-06-30 8:19 ` Tian, Kevin 2022-06-30 8:19 ` Tian, Kevin 2022-06-25 12:52 ` [PATCH v1 2/6] iommu/vt-d: Use IDA interface to manage iommu sequence id Lu Baolu 2022-06-25 12:52 ` Lu Baolu 2022-06-30 8:21 ` Tian, Kevin [this message] 2022-06-30 8:21 ` Tian, Kevin 2022-07-01 1:17 ` Lu Baolu 2022-07-01 1:17 ` Lu Baolu 2022-06-25 12:52 ` [PATCH v1 3/6] iommu/vt-d: Refactor iommu information of each domain Lu Baolu 2022-06-25 12:52 ` Lu Baolu 2022-06-30 8:28 ` Tian, Kevin 2022-06-30 8:28 ` Tian, Kevin 2022-07-01 2:35 ` Lu Baolu 2022-07-01 2:35 ` Lu Baolu 2022-06-25 12:52 ` [PATCH v1 4/6] iommu/vt-d: Add VTD_FLAG_IOMMU_PROBED flag Lu Baolu 2022-06-25 12:52 ` Lu Baolu 2022-06-30 8:29 ` Tian, Kevin 2022-06-30 8:29 ` Tian, Kevin 2022-07-01 3:13 ` Baolu Lu 2022-07-01 3:13 ` Baolu Lu 2022-07-01 6:09 ` Tian, Kevin 2022-07-01 6:09 ` Tian, Kevin 2022-06-25 12:52 ` [PATCH v1 5/6] iommu/vt-d: Remove global g_iommus array Lu Baolu 2022-06-25 12:52 ` Lu Baolu 2022-06-30 8:29 ` Tian, Kevin 2022-06-30 8:29 ` Tian, Kevin 2022-06-25 12:52 ` [PATCH v1 6/6] iommu/vt-d: Make DMAR_UNITS_SUPPORTED default 1024 Lu Baolu 2022-06-25 12:52 ` Lu Baolu 2022-06-30 8:30 ` Tian, Kevin 2022-06-30 8:30 ` Tian, Kevin 2022-06-28 12:39 ` [PATCH v1 0/6] iommu/vt-d: Reset DMAR_UNITS_SUPPORTED Baolu Lu 2022-06-28 12:39 ` Baolu Lu 2022-07-06 18:55 ` Steve Wahl
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BL1PR11MB5271C0143C8EA440BDAF45828CBA9@BL1PR11MB5271.namprd11.prod.outlook.com \ --to=kevin.tian@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dwmw2@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=iommu@lists.linux.dev \ --cc=joro@8bytes.org \ --cc=jsnitsel@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mike.travis@hpe.com \ --cc=russ.anderson@hpe.com \ --cc=sivanich@hpe.com \ --cc=steve.wahl@hpe.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.