From: Michal Kazior <michal.kazior@tieto.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] ath10k: synchronize tx/rx reporting to mac80211
Date: Wed, 28 Aug 2013 12:54:46 +0200 [thread overview]
Message-ID: <CA+BoTQmW8F+e3YqLSoCWbYRSzZAM=Wy2GvGfbbW7iwVHtaesOQ@mail.gmail.com> (raw)
In-Reply-To: <87txiajveo.fsf@kamboji.qca.qualcomm.com>
On 28 August 2013 06:23, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> According to mac80211 docs tx and rx reporting
>> routines must not run concurrently unless they are
>> _irqsafe variants.
>>
>> This doesn't fix any visible bug but is apparently
>> the right thing to do as per the documentation.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>
> I had a quick chat with Johannes and Sujith about this. The concurrency
> requirements are for the STA PS race in AP mode (see
> ieee80211_handle_filtered_frame()).
>
> I think we should drop this frame, revisit later and properly analyse
> how to fix the race. But it would be good add this to the todo list:
>
> http://wireless.kernel.org/en/users/Drivers/ath10k#TODO
I've added this to the TODO list.
I'm worried this PS stuff is broken on ath10k anyway because ath10k
modifies tx skbuffs for QoS workaround (QoS Control must be removed
before submitting to FW).
Michał.
WARNING: multiple messages have this Message-ID (diff)
From: Michal Kazior <michal.kazior@tieto.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
ath10k@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ath10k: synchronize tx/rx reporting to mac80211
Date: Wed, 28 Aug 2013 12:54:46 +0200 [thread overview]
Message-ID: <CA+BoTQmW8F+e3YqLSoCWbYRSzZAM=Wy2GvGfbbW7iwVHtaesOQ@mail.gmail.com> (raw)
In-Reply-To: <87txiajveo.fsf@kamboji.qca.qualcomm.com>
On 28 August 2013 06:23, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> According to mac80211 docs tx and rx reporting
>> routines must not run concurrently unless they are
>> _irqsafe variants.
>>
>> This doesn't fix any visible bug but is apparently
>> the right thing to do as per the documentation.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>
> I had a quick chat with Johannes and Sujith about this. The concurrency
> requirements are for the STA PS race in AP mode (see
> ieee80211_handle_filtered_frame()).
>
> I think we should drop this frame, revisit later and properly analyse
> how to fix the race. But it would be good add this to the todo list:
>
> http://wireless.kernel.org/en/users/Drivers/ath10k#TODO
I've added this to the TODO list.
I'm worried this PS stuff is broken on ath10k anyway because ath10k
modifies tx skbuffs for QoS workaround (QoS Control must be removed
before submitting to FW).
Michał.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2013-08-28 10:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 6:34 [PATCH 0/3] ath10k: fixes Michal Kazior
2013-08-21 6:34 ` Michal Kazior
2013-08-21 6:34 ` [PATCH 1/3] ath10k: make the workqueue multithreaded Michal Kazior
2013-08-21 6:34 ` Michal Kazior
2013-08-21 6:34 ` [PATCH 2/3] ath10k: move htt rx processing to worker Michal Kazior
2013-08-21 6:34 ` Michal Kazior
2013-08-21 6:34 ` [PATCH 3/3] ath10k: fix issues on non-preemptible systems Michal Kazior
2013-08-21 6:34 ` Michal Kazior
2013-08-22 10:05 ` [PATCH 0/3] ath10k: fixes Michal Kazior
2013-08-22 10:05 ` Michal Kazior
2013-08-26 8:53 ` [PATCH v2 0/4] " Michal Kazior
2013-08-26 8:53 ` Michal Kazior
2013-08-26 8:53 ` [PATCH v2 1/4] ath10k: synchronize tx/rx reporting to mac80211 Michal Kazior
2013-08-26 8:53 ` Michal Kazior
2013-08-28 4:23 ` Kalle Valo
2013-08-28 4:23 ` Kalle Valo
2013-08-28 10:54 ` Michal Kazior [this message]
2013-08-28 10:54 ` Michal Kazior
2013-08-28 11:04 ` Kalle Valo
2013-08-28 11:04 ` Kalle Valo
2013-08-26 8:53 ` [PATCH v2 2/4] ath10k: make the workqueue multithreaded Michal Kazior
2013-08-26 8:53 ` Michal Kazior
2013-08-26 8:53 ` [PATCH v2 3/4] ath10k: move htt rx processing to worker Michal Kazior
2013-08-26 8:53 ` Michal Kazior
2013-08-26 8:53 ` [PATCH v2 4/4] ath10k: fix issues on non-preemptible systems Michal Kazior
2013-08-26 8:53 ` Michal Kazior
2013-08-27 7:06 ` Kalle Valo
2013-08-27 7:06 ` Kalle Valo
2013-08-27 7:30 ` Michal Kazior
2013-08-27 7:30 ` Michal Kazior
2013-08-28 4:02 ` Kalle Valo
2013-08-28 4:02 ` Kalle Valo
2013-08-28 13:16 ` Michal Kazior
2013-08-28 13:16 ` Michal Kazior
2013-08-26 20:20 ` [PATCH v2 0/4] ath10k: fixes Luis R. Rodriguez
2013-08-26 20:20 ` Luis R. Rodriguez
2013-08-27 5:42 ` Michal Kazior
2013-08-27 5:42 ` Michal Kazior
2013-08-27 7:59 ` Luis R. Rodriguez
2013-08-27 7:59 ` Luis R. Rodriguez
2013-08-27 6:57 ` Kalle Valo
2013-08-27 6:57 ` Kalle Valo
2013-08-27 8:01 ` Luis R. Rodriguez
2013-08-27 8:01 ` Luis R. Rodriguez
2013-08-28 3:53 ` Kalle Valo
2013-08-28 3:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+BoTQmW8F+e3YqLSoCWbYRSzZAM=Wy2GvGfbbW7iwVHtaesOQ@mail.gmail.com' \
--to=michal.kazior@tieto.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.