All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fuad Tabba <tabba@google.com>
To: Oliver Upton <oupton@google.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, maz@kernel.org,
	james.morse@arm.com, alexandru.elisei@arm.com,
	suzuki.poulose@arm.com, qperret@google.com, will@kernel.org
Subject: Re: [PATCH 2/2] KVM: arm64: pkvm: Don't mask already zeroed FEAT_SVE
Date: Tue, 10 May 2022 10:45:30 +0100	[thread overview]
Message-ID: <CA+EHjTztV9ZN4sQyS8BGxuROw4NY873LXve8LPjo417Ao6y4aQ@mail.gmail.com> (raw)
In-Reply-To: <20220509162559.2387784-3-oupton@google.com>

Hi Oliver,


On Mon, May 9, 2022 at 5:26 PM Oliver Upton <oupton@google.com> wrote:
>
> FEAT_SVE is already masked by the fixed configuration for
> ID_AA64PFR0_EL1; don't try and mask it at runtime.
>
> No functional change intended.
>
> Signed-off-by: Oliver Upton <oupton@google.com>
> ---

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad


>  arch/arm64/kvm/hyp/nvhe/sys_regs.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/kvm/hyp/nvhe/sys_regs.c b/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> index 33f5181af330..3f5d7bd171c5 100644
> --- a/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> +++ b/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> @@ -90,9 +90,6 @@ static u64 get_pvm_id_aa64pfr0(const struct kvm_vcpu *vcpu)
>         u64 set_mask = 0;
>         u64 allow_mask = PVM_ID_AA64PFR0_ALLOW;
>
> -       if (!vcpu_has_sve(vcpu))
> -               allow_mask &= ~ARM64_FEATURE_MASK(ID_AA64PFR0_SVE);
> -
>         set_mask |= get_restricted_features_unsigned(id_aa64pfr0_el1_sys_val,
>                 PVM_ID_AA64PFR0_RESTRICT_UNSIGNED);
>
> --
> 2.36.0.512.ge40c2bad7a-goog
>

WARNING: multiple messages have this Message-ID (diff)
From: Fuad Tabba <tabba@google.com>
To: Oliver Upton <oupton@google.com>
Cc: kvm@vger.kernel.org, maz@kernel.org,
	linux-kernel@vger.kernel.org, will@kernel.org,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] KVM: arm64: pkvm: Don't mask already zeroed FEAT_SVE
Date: Tue, 10 May 2022 10:45:30 +0100	[thread overview]
Message-ID: <CA+EHjTztV9ZN4sQyS8BGxuROw4NY873LXve8LPjo417Ao6y4aQ@mail.gmail.com> (raw)
In-Reply-To: <20220509162559.2387784-3-oupton@google.com>

Hi Oliver,


On Mon, May 9, 2022 at 5:26 PM Oliver Upton <oupton@google.com> wrote:
>
> FEAT_SVE is already masked by the fixed configuration for
> ID_AA64PFR0_EL1; don't try and mask it at runtime.
>
> No functional change intended.
>
> Signed-off-by: Oliver Upton <oupton@google.com>
> ---

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad


>  arch/arm64/kvm/hyp/nvhe/sys_regs.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/kvm/hyp/nvhe/sys_regs.c b/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> index 33f5181af330..3f5d7bd171c5 100644
> --- a/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> +++ b/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> @@ -90,9 +90,6 @@ static u64 get_pvm_id_aa64pfr0(const struct kvm_vcpu *vcpu)
>         u64 set_mask = 0;
>         u64 allow_mask = PVM_ID_AA64PFR0_ALLOW;
>
> -       if (!vcpu_has_sve(vcpu))
> -               allow_mask &= ~ARM64_FEATURE_MASK(ID_AA64PFR0_SVE);
> -
>         set_mask |= get_restricted_features_unsigned(id_aa64pfr0_el1_sys_val,
>                 PVM_ID_AA64PFR0_RESTRICT_UNSIGNED);
>
> --
> 2.36.0.512.ge40c2bad7a-goog
>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Fuad Tabba <tabba@google.com>
To: Oliver Upton <oupton@google.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  maz@kernel.org,
	james.morse@arm.com, alexandru.elisei@arm.com,
	 suzuki.poulose@arm.com, qperret@google.com, will@kernel.org
Subject: Re: [PATCH 2/2] KVM: arm64: pkvm: Don't mask already zeroed FEAT_SVE
Date: Tue, 10 May 2022 10:45:30 +0100	[thread overview]
Message-ID: <CA+EHjTztV9ZN4sQyS8BGxuROw4NY873LXve8LPjo417Ao6y4aQ@mail.gmail.com> (raw)
In-Reply-To: <20220509162559.2387784-3-oupton@google.com>

Hi Oliver,


On Mon, May 9, 2022 at 5:26 PM Oliver Upton <oupton@google.com> wrote:
>
> FEAT_SVE is already masked by the fixed configuration for
> ID_AA64PFR0_EL1; don't try and mask it at runtime.
>
> No functional change intended.
>
> Signed-off-by: Oliver Upton <oupton@google.com>
> ---

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad


>  arch/arm64/kvm/hyp/nvhe/sys_regs.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/kvm/hyp/nvhe/sys_regs.c b/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> index 33f5181af330..3f5d7bd171c5 100644
> --- a/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> +++ b/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> @@ -90,9 +90,6 @@ static u64 get_pvm_id_aa64pfr0(const struct kvm_vcpu *vcpu)
>         u64 set_mask = 0;
>         u64 allow_mask = PVM_ID_AA64PFR0_ALLOW;
>
> -       if (!vcpu_has_sve(vcpu))
> -               allow_mask &= ~ARM64_FEATURE_MASK(ID_AA64PFR0_SVE);
> -
>         set_mask |= get_restricted_features_unsigned(id_aa64pfr0_el1_sys_val,
>                 PVM_ID_AA64PFR0_RESTRICT_UNSIGNED);
>
> --
> 2.36.0.512.ge40c2bad7a-goog
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-10  9:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 16:25 [PATCH 0/2] KVM: arm64: Minor pKVM cleanups Oliver Upton
2022-05-09 16:25 ` Oliver Upton
2022-05-09 16:25 ` Oliver Upton
2022-05-09 16:25 ` [PATCH 1/2] KVM: arm64: pkvm: Drop unnecessary FP/SIMD trap handler Oliver Upton
2022-05-09 16:25   ` Oliver Upton
2022-05-09 16:25   ` Oliver Upton
2022-05-10  9:44   ` Fuad Tabba
2022-05-10  9:44     ` Fuad Tabba
2022-05-10  9:44     ` Fuad Tabba
2022-05-09 16:25 ` [PATCH 2/2] KVM: arm64: pkvm: Don't mask already zeroed FEAT_SVE Oliver Upton
2022-05-09 16:25   ` Oliver Upton
2022-05-09 16:25   ` Oliver Upton
2022-05-10  9:45   ` Fuad Tabba [this message]
2022-05-10  9:45     ` Fuad Tabba
2022-05-10  9:45     ` Fuad Tabba
2022-05-10 10:04 ` [PATCH 0/2] KVM: arm64: Minor pKVM cleanups Marc Zyngier
2022-05-10 10:04   ` Marc Zyngier
2022-05-10 10:04   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+EHjTztV9ZN4sQyS8BGxuROw4NY873LXve8LPjo417Ao6y4aQ@mail.gmail.com \
    --to=tabba@google.com \
    --cc=alexandru.elisei@arm.com \
    --cc=james.morse@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@google.com \
    --cc=qperret@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.