All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	alex@ghiti.fr, lcapitulino@redhat.com, mike.kravetz@oracle.com,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-arm-kernel@lists.infradead.org,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hugetlb: fix ARM 3level page tables
Date: Sat, 6 Oct 2018 00:50:05 -0700	[thread overview]
Message-ID: <CA+G9fYs-z-CQ+HgFcosYsNphAmU2rG56PTFqO48T-pZ_63Ujuw@mail.gmail.com> (raw)
In-Reply-To: <20181005161722.904274-1-arnd@arndb.de>

Arnd,

On Fri, 5 Oct 2018 at 09:17, Arnd Bergmann <arnd@arndb.de> wrote:
>
> The check for __HAVE_ARCH_HUGE_PTEP_GET comes before the definition,
> leading to an extraneous definition of huge_ptep_get:
>
> In file included from arch/arm/include/asm/hugetlb.h:28,
>                  from include/linux/hugetlb.h:456,
>                  from arch/arm/kvm/../../../virt/kvm/arm/mmu.c:22:
> arch/arm/include/asm/hugetlb-3level.h:33:21: error: redefinition of 'huge_ptep_get'
>  static inline pte_t huge_ptep_get(pte_t *ptep)
>
> Change the header file inclusions to be in the correct order for
> this to work.
>
> Fixes: bb1d18ffc7ae ("hugetlb: introduce generic version of huge_ptep_get")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I have noticed this build error on linux next tree for arm32 build.
Thanks for the fix.

- Naresh

WARNING: multiple messages have this Message-ID (diff)
From: naresh.kamboju@linaro.org (Naresh Kamboju)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hugetlb: fix ARM 3level page tables
Date: Sat, 6 Oct 2018 00:50:05 -0700	[thread overview]
Message-ID: <CA+G9fYs-z-CQ+HgFcosYsNphAmU2rG56PTFqO48T-pZ_63Ujuw@mail.gmail.com> (raw)
In-Reply-To: <20181005161722.904274-1-arnd@arndb.de>

Arnd,

On Fri, 5 Oct 2018 at 09:17, Arnd Bergmann <arnd@arndb.de> wrote:
>
> The check for __HAVE_ARCH_HUGE_PTEP_GET comes before the definition,
> leading to an extraneous definition of huge_ptep_get:
>
> In file included from arch/arm/include/asm/hugetlb.h:28,
>                  from include/linux/hugetlb.h:456,
>                  from arch/arm/kvm/../../../virt/kvm/arm/mmu.c:22:
> arch/arm/include/asm/hugetlb-3level.h:33:21: error: redefinition of 'huge_ptep_get'
>  static inline pte_t huge_ptep_get(pte_t *ptep)
>
> Change the header file inclusions to be in the correct order for
> this to work.
>
> Fixes: bb1d18ffc7ae ("hugetlb: introduce generic version of huge_ptep_get")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I have noticed this build error on linux next tree for arm32 build.
Thanks for the fix.

- Naresh

  reply	other threads:[~2018-10-06  7:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 16:16 [PATCH] hugetlb: fix ARM 3level page tables Arnd Bergmann
2018-10-05 16:16 ` Arnd Bergmann
2018-10-06  7:50 ` Naresh Kamboju [this message]
2018-10-06  7:50   ` Naresh Kamboju
2018-10-07 18:59 ` Alex Ghiti
2018-10-07 18:59   ` Alex Ghiti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+G9fYs-z-CQ+HgFcosYsNphAmU2rG56PTFqO48T-pZ_63Ujuw@mail.gmail.com \
    --to=naresh.kamboju@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex@ghiti.fr \
    --cc=arnd@arndb.de \
    --cc=lcapitulino@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mike.kravetz@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.