From: Orson Zhai <orsonzhai@gmail.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Chunyan Zhang <zhang.lyra@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Jiri Slaby <jslaby@suse.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Chunyan Zhang <chunyan.zhang@unisoc.com>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, Baolin Wang <baolin.wang7@gmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, kernel-team@android.com Subject: Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD Date: Mon, 9 Mar 2020 22:10:41 +0800 [thread overview] Message-ID: <CA+H2tpFBDSGfwYT--G_FsaEceNJW_xBJjjiSMnhZDVhZamj_QQ@mail.gmail.com> (raw) In-Reply-To: <CAMuHMdUBkS+pPyPid2K=40jaTOSnAE_L-vJP5knmyVr8Fr5_hg@mail.gmail.com> Hi Geert, On Mon, Mar 9, 2020 at 4:01 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Chunyan, > > On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > > > Why would you want a serial driver for a specific platform to be builtin, > > > while all other platform support is modular? > > > > Oh, that's not this patch means. > > > > We just want serial driver can be builtin for any platform, so it > > What would be the benefit of the user to be able to have the SPRD serial > driver built-in on any platform? AFAIU, it supports only Spreadtrum > platforms. > Assume there is a all-in-one common kernel binary image say arm64 for all SoC platform and all device drivers are built as modules from different vendors for each specific devices. But for serial driver it is too late to be initialized as a module if users want to check early console log. At this circumstance vendors prefer to set their serial driver to be built into that all-in-one image as easy as to only set one config instead of enabling whole platform then disabling many out of serial. -Orson > > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > > , otherwise if the config was set as 'm', the serial driver can't be > > selected as 'y' then. > > I ask about that as a reply to PATCH 1/2. > > > That's what I mean. > > > > > --- a/drivers/tty/serial/Kconfig > > > > +++ b/drivers/tty/serial/Kconfig > > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > > > config SERIAL_SPRD > > > > tristate "Support for Spreadtrum serial" > > > > - depends on ARCH_SPRD > > > > select SERIAL_CORE > > > > help > > > > This enables the driver for the Spreadtrum's serial. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Orson Zhai <orsonzhai@gmail.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: kernel-team@android.com, Catalin Marinas <catalin.marinas@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Chunyan Zhang <zhang.lyra@gmail.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Chunyan Zhang <chunyan.zhang@unisoc.com>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, Jiri Slaby <jslaby@suse.com>, Baolin Wang <baolin.wang7@gmail.com>, Will Deacon <will@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD Date: Mon, 9 Mar 2020 22:10:41 +0800 [thread overview] Message-ID: <CA+H2tpFBDSGfwYT--G_FsaEceNJW_xBJjjiSMnhZDVhZamj_QQ@mail.gmail.com> (raw) In-Reply-To: <CAMuHMdUBkS+pPyPid2K=40jaTOSnAE_L-vJP5knmyVr8Fr5_hg@mail.gmail.com> Hi Geert, On Mon, Mar 9, 2020 at 4:01 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Chunyan, > > On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > > > Why would you want a serial driver for a specific platform to be builtin, > > > while all other platform support is modular? > > > > Oh, that's not this patch means. > > > > We just want serial driver can be builtin for any platform, so it > > What would be the benefit of the user to be able to have the SPRD serial > driver built-in on any platform? AFAIU, it supports only Spreadtrum > platforms. > Assume there is a all-in-one common kernel binary image say arm64 for all SoC platform and all device drivers are built as modules from different vendors for each specific devices. But for serial driver it is too late to be initialized as a module if users want to check early console log. At this circumstance vendors prefer to set their serial driver to be built into that all-in-one image as easy as to only set one config instead of enabling whole platform then disabling many out of serial. -Orson > > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > > , otherwise if the config was set as 'm', the serial driver can't be > > selected as 'y' then. > > I ask about that as a reply to PATCH 1/2. > > > That's what I mean. > > > > > --- a/drivers/tty/serial/Kconfig > > > > +++ b/drivers/tty/serial/Kconfig > > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > > > config SERIAL_SPRD > > > > tristate "Support for Spreadtrum serial" > > > > - depends on ARCH_SPRD > > > > select SERIAL_CORE > > > > help > > > > This enables the driver for the Spreadtrum's serial. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-09 14:11 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-05 10:32 [PATCH 1/2] arm64: change ARCH_SPRD Kconfig to tristate Chunyan Zhang 2020-03-05 10:32 ` Chunyan Zhang 2020-03-05 10:32 ` [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD Chunyan Zhang 2020-03-05 10:32 ` Chunyan Zhang 2020-03-06 12:41 ` Geert Uytterhoeven 2020-03-06 12:41 ` Geert Uytterhoeven 2020-03-09 1:17 ` Chunyan Zhang 2020-03-09 1:17 ` Chunyan Zhang 2020-03-09 8:01 ` Geert Uytterhoeven 2020-03-09 8:01 ` Geert Uytterhoeven 2020-03-09 8:42 ` Chunyan Zhang 2020-03-09 8:42 ` Chunyan Zhang 2020-03-09 10:32 ` Geert Uytterhoeven 2020-03-09 10:32 ` Geert Uytterhoeven 2020-03-09 11:15 ` Chunyan Zhang 2020-03-09 11:15 ` Chunyan Zhang 2020-03-09 14:10 ` Orson Zhai [this message] 2020-03-09 14:10 ` Orson Zhai 2020-03-09 8:03 ` [PATCH 1/2] arm64: change ARCH_SPRD Kconfig to tristate Geert Uytterhoeven 2020-03-09 8:03 ` Geert Uytterhoeven 2020-03-09 8:32 ` Chunyan Zhang 2020-03-09 8:32 ` Chunyan Zhang 2020-03-09 10:32 ` Geert Uytterhoeven 2020-03-09 10:32 ` Geert Uytterhoeven 2020-03-10 4:19 ` Sandeep Patil 2020-03-10 4:19 ` Sandeep Patil 2020-03-10 4:27 ` Sandeep Patil 2020-03-10 4:27 ` Sandeep Patil 2020-03-10 8:47 ` Geert Uytterhoeven 2020-03-10 8:47 ` Geert Uytterhoeven 2020-03-10 9:41 ` Orson Zhai 2020-03-10 9:41 ` Orson Zhai 2020-03-10 9:52 ` Geert Uytterhoeven 2020-03-10 9:52 ` Geert Uytterhoeven 2020-03-10 10:13 ` Orson Zhai 2020-03-10 10:13 ` Orson Zhai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+H2tpFBDSGfwYT--G_FsaEceNJW_xBJjjiSMnhZDVhZamj_QQ@mail.gmail.com \ --to=orsonzhai@gmail.com \ --cc=baolin.wang7@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=chunyan.zhang@unisoc.com \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.com \ --cc=kernel-team@android.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=will@kernel.org \ --cc=zhang.lyra@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.