All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Marko <robert.marko@sartura.hr>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
	"Rob Herring" <robh+dt@kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Pali Rohár" <pali@kernel.org>,
	"Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH v2 1/2] arm64: dts: uDPU: update partition table
Date: Tue, 10 May 2022 17:17:14 +0200	[thread overview]
Message-ID: <CA+HBbNHJtHexMHUiZ8d-OStCP57nbDXhQtgL+hvjQkA2FFsXZg@mail.gmail.com> (raw)
In-Reply-To: <b183f838-359c-752a-dd23-9bd1a160eee5@linaro.org>

On Tue, May 10, 2022 at 3:56 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 22/03/2022 11:58, Robert Marko wrote:
> > Partition currently called "uboot" does not only contain U-boot, but
> > rather it contains TF-A, U-boot and U-boot environment.
> >
> > So, to avoid accidentally deleting the U-boot environment which is
> > located at 0x180000 split the partition.
> >
> > "uboot" is not the correct name as you can't boot these boards with U-boot
> > only, TF-A must be present as well, so rename the "uboot" partition to
> > "firmware".
> >
> > While we are here, describe the NOR node as "spi-flash@0" instead of
> > "m25p80@0" which is the old SPI-NOR driver name.
>
> This patch was applied, but it was never tested with dtbs_check (nor
> rebased on my cleanups). spi-flash is still wrong.

Hi Krzysztof, sorry for that, I did run dtbs_check on it but there is
a whole forest of
warnings about schemas not being matched as most of the bindings are
still plaintext
and I missed this.

I did correct this to flash@0 in the eDPU series that was sent out today.
Regards,
Robert
>
> Best regards,
> Krzysztof



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Robert Marko <robert.marko@sartura.hr>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
	"Rob Herring" <robh+dt@kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Pali Rohár" <pali@kernel.org>,
	"Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH v2 1/2] arm64: dts: uDPU: update partition table
Date: Tue, 10 May 2022 17:17:14 +0200	[thread overview]
Message-ID: <CA+HBbNHJtHexMHUiZ8d-OStCP57nbDXhQtgL+hvjQkA2FFsXZg@mail.gmail.com> (raw)
In-Reply-To: <b183f838-359c-752a-dd23-9bd1a160eee5@linaro.org>

On Tue, May 10, 2022 at 3:56 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 22/03/2022 11:58, Robert Marko wrote:
> > Partition currently called "uboot" does not only contain U-boot, but
> > rather it contains TF-A, U-boot and U-boot environment.
> >
> > So, to avoid accidentally deleting the U-boot environment which is
> > located at 0x180000 split the partition.
> >
> > "uboot" is not the correct name as you can't boot these boards with U-boot
> > only, TF-A must be present as well, so rename the "uboot" partition to
> > "firmware".
> >
> > While we are here, describe the NOR node as "spi-flash@0" instead of
> > "m25p80@0" which is the old SPI-NOR driver name.
>
> This patch was applied, but it was never tested with dtbs_check (nor
> rebased on my cleanups). spi-flash is still wrong.

Hi Krzysztof, sorry for that, I did run dtbs_check on it but there is
a whole forest of
warnings about schemas not being matched as most of the bindings are
still plaintext
and I missed this.

I did correct this to flash@0 in the eDPU series that was sent out today.
Regards,
Robert
>
> Best regards,
> Krzysztof



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

  reply	other threads:[~2022-05-10 15:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 10:58 [PATCH v2 1/2] arm64: dts: uDPU: update partition table Robert Marko
2022-03-22 10:58 ` Robert Marko
2022-03-22 10:58 ` [PATCH v2 2/2] arm64: dts: uDPU: correct temperature sensors Robert Marko
2022-03-22 10:58   ` Robert Marko
2022-03-22 12:19   ` Andrew Lunn
2022-03-22 12:19     ` Andrew Lunn
2022-03-22 18:48   ` Pali Rohár
2022-03-22 18:48     ` Pali Rohár
2022-03-22 12:20 ` [PATCH v2 1/2] arm64: dts: uDPU: update partition table Andrew Lunn
2022-03-22 12:20   ` Andrew Lunn
2022-03-22 18:47 ` Pali Rohár
2022-03-22 18:47   ` Pali Rohár
2022-05-09  8:47 ` Gregory CLEMENT
2022-05-09  8:47   ` Gregory CLEMENT
2022-05-10 13:56 ` Krzysztof Kozlowski
2022-05-10 13:56   ` Krzysztof Kozlowski
2022-05-10 15:17   ` Robert Marko [this message]
2022-05-10 15:17     ` Robert Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+HBbNHJtHexMHUiZ8d-OStCP57nbDXhQtgL+hvjQkA2FFsXZg@mail.gmail.com \
    --to=robert.marko@sartura.hr \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=pali@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.