From: Dong Aisheng <dongas86@gmail.com> To: Ezequiel Garcia <ezequiel@collabora.com> Cc: Mirela Rabulea <mirela.rabulea@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "mchehab@kernel.org" <mchehab@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, Aisheng Dong <aisheng.dong@nxp.com>, "G.n. Zhou" <guoniu.zhou@nxp.com>, dl-linux-imx <linux-imx@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Laurentiu Palcu <laurentiu.palcu@nxp.com>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "paul.kocialkowski@bootlin.com" <paul.kocialkowski@bootlin.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Robert Chiras <robert.chiras@nxp.com>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, Peng Fan <peng.fan@nxp.com>, "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>, Daniel Baluta <daniel.baluta@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de> Subject: Re: [PATCH v13 2/2] arm64: dts: imx: Add jpeg encoder/decoder nodes Date: Fri, 18 Jun 2021 20:47:57 +0800 [thread overview] Message-ID: <CAA+hA=RB_va3TRhjFBSofVqDEpj_LxLfUM84ead5D2LLZ3KRwA@mail.gmail.com> (raw) In-Reply-To: <15d5728aeb7895f81f833e7f7e281861c1fcef9a.camel@collabora.com> On Fri, Jun 11, 2021 at 11:01 PM Ezequiel Garcia <ezequiel@collabora.com> wrote: > > On Fri, 2021-06-11 at 21:33 +0800, Dong Aisheng wrote: > > [...] > > > > > > > +img_subsys: bus@58000000 { > > > > > + compatible = "simple-bus"; > > > > > + #address-cells = <1>; > > > > > + #size-cells = <1>; > > > > > + ranges = <0x58000000 0x0 0x58000000 0x1000000>; > > > > > + > > > > > + img_ipg_clk: clock-img-ipg { > > > > > + compatible = "fixed-clock"; > > > > > + #clock-cells = <0>; > > > > > + clock-frequency = <200000000>; > > > > > + clock-output-names = "img_ipg_clk"; > > > > > + }; > > > > > + > > > > > + jpegdec: jpegdec@58400000 { > > > > > > > > Node should be disabled by default. > > > > And enable it in board dts including LPCG. > > > > > > At version v5 of this patch, the node was disabled by default, and I > > > received this feedback from Ezequiel Garcia: > > > > > > "Pure memory-to-memory are typically not enabled per-board, but just > > > per-platform. > > > So you can drop the disabled status here." > > > > > > So, in v6 I made it enabled by default. > > > > > > Any strong reasons for enabled/disabled per platform? > > > > AFAIK we usually only enable system basic features and let other > > user selectable features disabled by default in dts. > > Even for device LPCG clocks, if it's enabled by default and later > > enter runtime suspend if no users, it still consumes power. > > > > Well-written drivers shouldn't draw any power if not used. > LPCG won't draw power when not used. But the power domain used by LPCG will still draw power when enter idle state. > And DT is about hardware-description, not about usage-description. > Which means, at the soc.dtsi level you disable devices that need > some board-level hardware thing to be enabled (e.g. a physical > connected, a regulator, etc.). > A pure memory-to-memory should be enabled by default, because > in practice you can't predict what the users a board will want > to use, nor the DT is the place for that. It makes sense to me. Thanks Mirela, Please follow up with Ezequiel's suggestion. For LPCGS used by jpeg, you can keep it enabled by default. Regards Aisheng > > Sticking to hardware description is the best way to get DT right :-) > > Cheers, > Ezequiel >
WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <dongas86@gmail.com> To: Ezequiel Garcia <ezequiel@collabora.com> Cc: Mirela Rabulea <mirela.rabulea@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "mchehab@kernel.org" <mchehab@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, Aisheng Dong <aisheng.dong@nxp.com>, "G.n. Zhou" <guoniu.zhou@nxp.com>, dl-linux-imx <linux-imx@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Laurentiu Palcu <laurentiu.palcu@nxp.com>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "paul.kocialkowski@bootlin.com" <paul.kocialkowski@bootlin.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Robert Chiras <robert.chiras@nxp.com>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, Peng Fan <peng.fan@nxp.com>, "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>, Daniel Baluta <daniel.baluta@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de> Subject: Re: [PATCH v13 2/2] arm64: dts: imx: Add jpeg encoder/decoder nodes Date: Fri, 18 Jun 2021 20:47:57 +0800 [thread overview] Message-ID: <CAA+hA=RB_va3TRhjFBSofVqDEpj_LxLfUM84ead5D2LLZ3KRwA@mail.gmail.com> (raw) In-Reply-To: <15d5728aeb7895f81f833e7f7e281861c1fcef9a.camel@collabora.com> On Fri, Jun 11, 2021 at 11:01 PM Ezequiel Garcia <ezequiel@collabora.com> wrote: > > On Fri, 2021-06-11 at 21:33 +0800, Dong Aisheng wrote: > > [...] > > > > > > > +img_subsys: bus@58000000 { > > > > > + compatible = "simple-bus"; > > > > > + #address-cells = <1>; > > > > > + #size-cells = <1>; > > > > > + ranges = <0x58000000 0x0 0x58000000 0x1000000>; > > > > > + > > > > > + img_ipg_clk: clock-img-ipg { > > > > > + compatible = "fixed-clock"; > > > > > + #clock-cells = <0>; > > > > > + clock-frequency = <200000000>; > > > > > + clock-output-names = "img_ipg_clk"; > > > > > + }; > > > > > + > > > > > + jpegdec: jpegdec@58400000 { > > > > > > > > Node should be disabled by default. > > > > And enable it in board dts including LPCG. > > > > > > At version v5 of this patch, the node was disabled by default, and I > > > received this feedback from Ezequiel Garcia: > > > > > > "Pure memory-to-memory are typically not enabled per-board, but just > > > per-platform. > > > So you can drop the disabled status here." > > > > > > So, in v6 I made it enabled by default. > > > > > > Any strong reasons for enabled/disabled per platform? > > > > AFAIK we usually only enable system basic features and let other > > user selectable features disabled by default in dts. > > Even for device LPCG clocks, if it's enabled by default and later > > enter runtime suspend if no users, it still consumes power. > > > > Well-written drivers shouldn't draw any power if not used. > LPCG won't draw power when not used. But the power domain used by LPCG will still draw power when enter idle state. > And DT is about hardware-description, not about usage-description. > Which means, at the soc.dtsi level you disable devices that need > some board-level hardware thing to be enabled (e.g. a physical > connected, a regulator, etc.). > A pure memory-to-memory should be enabled by default, because > in practice you can't predict what the users a board will want > to use, nor the DT is the place for that. It makes sense to me. Thanks Mirela, Please follow up with Ezequiel's suggestion. For LPCGS used by jpeg, you can keep it enabled by default. Regards Aisheng > > Sticking to hardware description is the best way to get DT right :-) > > Cheers, > Ezequiel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-18 12:49 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-22 21:10 [PATCH v13 0/2] Add dts and bindings update for i.MX8QM/QXP JPEG codec Mirela Rabulea (OSS) 2021-05-22 21:10 ` Mirela Rabulea (OSS) 2021-05-22 21:10 ` [PATCH v13 1/2] media: dt-bindings: imx-jpeg: Add compatible for i.MX8QM " Mirela Rabulea (OSS) 2021-05-22 21:10 ` Mirela Rabulea (OSS) 2021-05-24 3:19 ` Aisheng Dong 2021-05-24 3:19 ` Aisheng Dong 2021-05-22 21:10 ` [PATCH v13 2/2] arm64: dts: imx: Add jpeg encoder/decoder nodes Mirela Rabulea (OSS) 2021-05-22 21:10 ` Mirela Rabulea (OSS) 2021-05-24 3:28 ` Aisheng Dong 2021-05-24 3:28 ` Aisheng Dong 2021-05-24 7:17 ` Mirela Rabulea 2021-05-24 7:17 ` Mirela Rabulea 2021-06-11 13:33 ` Dong Aisheng 2021-06-11 13:33 ` Dong Aisheng 2021-06-11 15:00 ` Ezequiel Garcia 2021-06-11 15:00 ` Ezequiel Garcia 2021-06-18 12:47 ` Dong Aisheng [this message] 2021-06-18 12:47 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAA+hA=RB_va3TRhjFBSofVqDEpj_LxLfUM84ead5D2LLZ3KRwA@mail.gmail.com' \ --to=dongas86@gmail.com \ --cc=aisheng.dong@nxp.com \ --cc=daniel.baluta@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=ezequiel@collabora.com \ --cc=guoniu.zhou@nxp.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kernel@pengutronix.de \ --cc=laurentiu.palcu@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=mirela.rabulea@nxp.com \ --cc=p.zabel@pengutronix.de \ --cc=paul.kocialkowski@bootlin.com \ --cc=peng.fan@nxp.com \ --cc=robert.chiras@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.