All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jing Zhang <jingzhangos@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: KVM <kvm@vger.kernel.org>, KVMPPC <kvm-ppc@vger.kernel.org>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Matlack <dmatlack@google.com>,
	Ben Gardon <bgardon@google.com>,
	Peter Feiner <pfeiner@google.com>
Subject: Re: [PATCH v1] KVM: stats: Add VM stat for the cumulative number of dirtied pages
Date: Thu, 12 Aug 2021 11:29:19 -0700	[thread overview]
Message-ID: <CAAdAUtiq5v2TMYVEUYWRqn5Bor64NffiR2bEuu9GEt2hd8PZjA@mail.gmail.com> (raw)
In-Reply-To: <6296f7ac-bf99-2198-5a02-9d1ad721cbd3@redhat.com>

On Thu, Aug 12, 2021 at 9:08 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 12/08/21 01:37, Jing Zhang wrote:
> > A per VM stat dirty_pages is added to record the number of dirtied pages
> > in the life cycle of a VM.
> > The growth rate of this stat is a good indicator during the process of
> > live migrations. The exact number of dirty pages at the moment doesn't
> > matter. That's why we define dirty_pages as a cumulative counter instead
> > of an instantaneous one.
>
> Why not make it a per-CPU stat?  mark_page_dirty_in_slot can use
> kvm_get_running_vcpu() and skip the logging in the rare case it's NULL.
>
> Paolo
>
Sure, I will make it a per-CPU one in the next version.

Thanks,
Jing

WARNING: multiple messages have this Message-ID (diff)
From: Jing Zhang <jingzhangos@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: KVM <kvm@vger.kernel.org>, KVMPPC <kvm-ppc@vger.kernel.org>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Matlack <dmatlack@google.com>,
	Ben Gardon <bgardon@google.com>,
	Peter Feiner <pfeiner@google.com>
Subject: Re: [PATCH v1] KVM: stats: Add VM stat for the cumulative number of dirtied pages
Date: Thu, 12 Aug 2021 18:29:19 +0000	[thread overview]
Message-ID: <CAAdAUtiq5v2TMYVEUYWRqn5Bor64NffiR2bEuu9GEt2hd8PZjA@mail.gmail.com> (raw)
In-Reply-To: <6296f7ac-bf99-2198-5a02-9d1ad721cbd3@redhat.com>

On Thu, Aug 12, 2021 at 9:08 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 12/08/21 01:37, Jing Zhang wrote:
> > A per VM stat dirty_pages is added to record the number of dirtied pages
> > in the life cycle of a VM.
> > The growth rate of this stat is a good indicator during the process of
> > live migrations. The exact number of dirty pages at the moment doesn't
> > matter. That's why we define dirty_pages as a cumulative counter instead
> > of an instantaneous one.
>
> Why not make it a per-CPU stat?  mark_page_dirty_in_slot can use
> kvm_get_running_vcpu() and skip the logging in the rare case it's NULL.
>
> Paolo
>
Sure, I will make it a per-CPU one in the next version.

Thanks,
Jing

  reply	other threads:[~2021-08-12 18:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 23:37 [PATCH v1] KVM: stats: Add VM stat for the cumulative number of dirtied pages Jing Zhang
2021-08-11 23:53 ` Oliver Upton
2021-08-11 23:53   ` Oliver Upton
2021-08-12 18:27   ` Jing Zhang
2021-08-12 18:27     ` Jing Zhang
2021-08-12 16:08 ` Paolo Bonzini
2021-08-12 16:08   ` Paolo Bonzini
2021-08-12 18:29   ` Jing Zhang [this message]
2021-08-12 18:29     ` Jing Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdAUtiq5v2TMYVEUYWRqn5Bor64NffiR2bEuu9GEt2hd8PZjA@mail.gmail.com \
    --to=jingzhangos@google.com \
    --cc=bgardon@google.com \
    --cc=dmatlack@google.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=oupton@google.com \
    --cc=pbonzini@redhat.com \
    --cc=pfeiner@google.com \
    --cc=pshier@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.