All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCHv2][RESEND] spi: Add support for N25Q016A
@ 2016-07-13 18:30 Moritz Fischer
  2016-07-14  7:01 ` Jagan Teki
  0 siblings, 1 reply; 3+ messages in thread
From: Moritz Fischer @ 2016-07-13 18:30 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
---
 drivers/mtd/spi/sf_params.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
index 4f37e33..8ae4eea 100644
--- a/drivers/mtd/spi/sf_params.c
+++ b/drivers/mtd/spi/sf_params.c
@@ -83,6 +83,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
 	{"M25P64",	   0x202017, 0x0,       64 * 1024,   128, RD_NORM,			  0},
 	{"M25P128",	   0x202018, 0x0,      256 * 1024,    64, RD_NORM,			  0},
 	{"M25PX64",	   0x207117, 0x0,       64 * 1024,   128, RD_NORM,		    SECT_4K},
+	{"N25Q016A",       0x20bb15, 0x1000,    64 * 1024,    32, RD_NORM,                  SECT_4K},
 	{"N25Q32",	   0x20ba16, 0x0,       64 * 1024,    64, RD_FULL,	   WR_QPP | SECT_4K},
 	{"N25Q32A",	   0x20bb16, 0x0,       64 * 1024,    64, RD_FULL,	   WR_QPP | SECT_4K},
 	{"N25Q64",	   0x20ba17, 0x0,       64 * 1024,   128, RD_FULL,	   WR_QPP | SECT_4K},
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCHv2][RESEND] spi: Add support for N25Q016A
  2016-07-13 18:30 [U-Boot] [PATCHv2][RESEND] spi: Add support for N25Q016A Moritz Fischer
@ 2016-07-14  7:01 ` Jagan Teki
  2016-07-14 23:24   ` Moritz Fischer
  0 siblings, 1 reply; 3+ messages in thread
From: Jagan Teki @ 2016-07-14  7:01 UTC (permalink / raw)
  To: u-boot

On 14 July 2016 at 00:00, Moritz Fischer <moritz.fischer@ettus.com> wrote:
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>  drivers/mtd/spi/sf_params.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
> index 4f37e33..8ae4eea 100644
> --- a/drivers/mtd/spi/sf_params.c
> +++ b/drivers/mtd/spi/sf_params.c
> @@ -83,6 +83,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
>         {"M25P64",         0x202017, 0x0,       64 * 1024,   128, RD_NORM,                        0},
>         {"M25P128",        0x202018, 0x0,      256 * 1024,    64, RD_NORM,                        0},
>         {"M25PX64",        0x207117, 0x0,       64 * 1024,   128, RD_NORM,                  SECT_4K},
> +       {"N25Q016A",       0x20bb15, 0x1000,    64 * 1024,    32, RD_NORM,                  SECT_4K},

Why would we need this ext_id (0x1000) here? I understand this is true
number for this part but it shouldn't require for probe or require
somewhere else?

thanks!
-- 
Jagan.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCHv2][RESEND] spi: Add support for N25Q016A
  2016-07-14  7:01 ` Jagan Teki
@ 2016-07-14 23:24   ` Moritz Fischer
  0 siblings, 0 replies; 3+ messages in thread
From: Moritz Fischer @ 2016-07-14 23:24 UTC (permalink / raw)
  To: u-boot

Jagan,

thanks for your review!

On Thu, Jul 14, 2016 at 12:01 AM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> On 14 July 2016 at 00:00, Moritz Fischer <moritz.fischer@ettus.com> wrote:
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>>  drivers/mtd/spi/sf_params.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
>> index 4f37e33..8ae4eea 100644
>> --- a/drivers/mtd/spi/sf_params.c
>> +++ b/drivers/mtd/spi/sf_params.c
>> @@ -83,6 +83,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
>>         {"M25P64",         0x202017, 0x0,       64 * 1024,   128, RD_NORM,                        0},
>>         {"M25P128",        0x202018, 0x0,      256 * 1024,    64, RD_NORM,                        0},
>>         {"M25PX64",        0x207117, 0x0,       64 * 1024,   128, RD_NORM,                  SECT_4K},
>> +       {"N25Q016A",       0x20bb15, 0x1000,    64 * 1024,    32, RD_NORM,                  SECT_4K},
>
> Why would we need this ext_id (0x1000) here? I understand this is true
> number for this part but it shouldn't require for probe or require
> somewhere else?

You're right. I just sent v3.

Cheers,

Moritz

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-14 23:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-13 18:30 [U-Boot] [PATCHv2][RESEND] spi: Add support for N25Q016A Moritz Fischer
2016-07-14  7:01 ` Jagan Teki
2016-07-14 23:24   ` Moritz Fischer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.