From: Jassi Brar <jassisinghbrar@gmail.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, <",
linux-arm-kernel"@lists.infradead.org>, ",
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
srv_heupstream" <linux-mediatek@lists.infradead.org>,
srv_heupstream <linux-arm-kernel@lists.infradead.org>,
Devicetree List <devicetree@vger.kernel.org>,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver
Date: Wed, 28 Feb 2018 23:44:18 +0530 [thread overview]
Message-ID: <CABb+yY3nfVxoA9wy1ym4mtCTKCZtJjepUTr7OP1uUPmzOEzniA@mail.gmail.com> (raw)
In-Reply-To: <d9e14058-6ffb-e54a-1565-f228342ee1f0@sholland.org>
On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland <samuel@sholland.org> wrote:
> Hi,
>
> On 02/28/18 03:16, Jassi Brar wrote:
>> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland <samuel@sholland.org> wrote:
>> ....
>>
>>> +/*
>>> + * The message box hardware provides 8 unidirectional channels. As the mailbox
>>> + * framework expects them to be bidirectional
>>>
>> That is incorrect. Mailbox framework does not require a channel to be
>> TX and RX capable.
>
> Sorry, it would be more accurate to say that the intended mailbox _client_
> expects the channels to be bidirectional.
>
Mailbox clients are very mailbox provider specific. Your client driver
is unlikely to be reuseable over another controller+remote combo.
Your client has to know already what a physical channel can do (RX, TX
or RXTX). There is no api to provide that info.
thanks
WARNING: multiple messages have this Message-ID (diff)
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, ",
linux-arm-kernel"@lists.infradead.org, ",
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
srv_heupstream"
<linux-mediatek@lists.infradead.org>srv_heupstream
<linux-arm-kernel@lists.infradead.org>,
Devicetree List <devicetree@vger.kernel.org>,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver
Date: Wed, 28 Feb 2018 23:44:18 +0530 [thread overview]
Message-ID: <CABb+yY3nfVxoA9wy1ym4mtCTKCZtJjepUTr7OP1uUPmzOEzniA@mail.gmail.com> (raw)
In-Reply-To: <d9e14058-6ffb-e54a-1565-f228342ee1f0@sholland.org>
On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland <samuel@sholland.org> wrote:
> Hi,
>
> On 02/28/18 03:16, Jassi Brar wrote:
>> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland <samuel@sholland.org> wrote:
>> ....
>>
>>> +/*
>>> + * The message box hardware provides 8 unidirectional channels. As the mailbox
>>> + * framework expects them to be bidirectional
>>>
>> That is incorrect. Mailbox framework does not require a channel to be
>> TX and RX capable.
>
> Sorry, it would be more accurate to say that the intended mailbox _client_
> expects the channels to be bidirectional.
>
Mailbox clients are very mailbox provider specific. Your client driver
is unlikely to be reuseable over another controller+remote combo.
Your client has to know already what a physical channel can do (RX, TX
or RXTX). There is no api to provide that info.
thanks
WARNING: multiple messages have this Message-ID (diff)
From: jassisinghbrar@gmail.com (Jassi Brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver
Date: Wed, 28 Feb 2018 23:44:18 +0530 [thread overview]
Message-ID: <CABb+yY3nfVxoA9wy1ym4mtCTKCZtJjepUTr7OP1uUPmzOEzniA@mail.gmail.com> (raw)
In-Reply-To: <d9e14058-6ffb-e54a-1565-f228342ee1f0@sholland.org>
On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland <samuel@sholland.org> wrote:
> Hi,
>
> On 02/28/18 03:16, Jassi Brar wrote:
>> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland <samuel@sholland.org> wrote:
>> ....
>>
>>> +/*
>>> + * The message box hardware provides 8 unidirectional channels. As the mailbox
>>> + * framework expects them to be bidirectional
>>>
>> That is incorrect. Mailbox framework does not require a channel to be
>> TX and RX capable.
>
> Sorry, it would be more accurate to say that the intended mailbox _client_
> expects the channels to be bidirectional.
>
Mailbox clients are very mailbox provider specific. Your client driver
is unlikely to be reuseable over another controller+remote combo.
Your client has to know already what a physical channel can do (RX, TX
or RXTX). There is no api to provide that info.
thanks
next prev parent reply other threads:[~2018-02-28 18:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 2:27 [PATCH 0/3] Allwinner sunxi message box support Samuel Holland
2018-02-28 2:27 ` Samuel Holland
2018-02-28 2:27 ` [PATCH 1/3] dt-bindings: Add a binding for the sunxi message box Samuel Holland
2018-02-28 2:27 ` Samuel Holland
2018-02-28 8:28 ` Maxime Ripard
2018-02-28 8:28 ` Maxime Ripard
2018-02-28 17:17 ` Andre Przywara
2018-02-28 17:17 ` Andre Przywara
2018-03-01 10:03 ` Maxime Ripard
2018-03-01 10:03 ` Maxime Ripard
2018-02-28 17:52 ` Samuel Holland
2018-02-28 17:52 ` Samuel Holland
2018-02-28 2:27 ` [PATCH 2/3] mailbox: Avoid NULL dereference in mbox_chan_received_data Samuel Holland
2018-02-28 2:27 ` Samuel Holland
2018-02-28 17:17 ` Andre Przywara
2018-02-28 17:17 ` Andre Przywara
2018-03-01 13:32 ` Jassi Brar
2018-03-01 13:32 ` Jassi Brar
2018-02-28 2:27 ` [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver Samuel Holland
2018-02-28 2:27 ` Samuel Holland
2018-02-28 8:32 ` Maxime Ripard
2018-02-28 8:32 ` Maxime Ripard
2018-02-28 17:19 ` Samuel Holland
2018-02-28 17:19 ` Samuel Holland
2018-03-01 10:32 ` Maxime Ripard
2018-03-01 10:32 ` Maxime Ripard
2018-03-01 11:32 ` Andre Przywara
2018-03-01 11:32 ` Andre Przywara
2018-03-01 11:51 ` Maxime Ripard
2018-03-01 11:51 ` Maxime Ripard
2018-02-28 9:16 ` Jassi Brar
2018-02-28 9:16 ` Jassi Brar
2018-02-28 17:51 ` Samuel Holland
2018-02-28 17:51 ` Samuel Holland
2018-02-28 18:14 ` Jassi Brar [this message]
2018-02-28 18:14 ` Jassi Brar
2018-02-28 18:14 ` Jassi Brar
2018-02-28 18:56 ` Samuel Holland
2018-02-28 18:56 ` Samuel Holland
2018-02-28 18:56 ` Samuel Holland
2018-03-01 5:22 ` Jassi Brar
2018-03-01 5:22 ` Jassi Brar
2018-03-01 5:22 ` Jassi Brar
2018-02-28 8:24 ` [PATCH 0/3] Allwinner sunxi message box support Maxime Ripard
2018-02-28 8:24 ` Maxime Ripard
2018-02-28 17:18 ` Samuel Holland
2018-02-28 17:18 ` Samuel Holland
2018-03-01 10:28 ` Maxime Ripard
2018-03-01 10:28 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABb+yY3nfVxoA9wy1ym4mtCTKCZtJjepUTr7OP1uUPmzOEzniA@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=", linux-arm-kernel"@lists.infradead.org \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.