From: Anmol karn <anmol.karan123@gmail.com> To: Jan Kara <jack@suse.cz> Cc: jeffm@suse.com, open list <linux-kernel@vger.kernel.org>, reiserfs-devel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, syzkaller-bugs@googlegroups.com, syzbot+9b33c9b118d77ff59b6f@syzkaller.appspotmail.com Subject: Re: [Linux-kernel-mentees] [PATCH] fs: reiserfs: xattr: Fix null pointer derefernce in open_xa_root() Date: Thu, 1 Oct 2020 16:14:23 +0530 [thread overview] Message-ID: <CAC+yH-Z3243vRB6Nr7Y1FrfsQcmyjM0qH8D1FKSzSPEi=xa0uw@mail.gmail.com> (raw) In-Reply-To: <20201001092841.GC17860@quack2.suse.cz> On Thu, Oct 1, 2020 at 2:58 PM Jan Kara <jack@suse.cz> wrote: > > On Thu 01-10-20 14:35:47, Anmol Karn wrote: > > d_really_is_negative() checks for the dentry->d_inode whether it's NULL > > or not, but in open_xa_root(), when it checks 'privroot->d_inode', it > > doesn't check whether privroot is NULL or not, this leads to a null > > pointer dereference while calling it from open_xa_dir() while > > initializing xaroot. > > > > - fs/reiserfs/xattr.c > > The bug seems to get triggered at this line: > > > > if (d_really_is_negative(privroot)) > > return ERR_PTR(-EOPNOTSUPP); > > > > Fix it by adding a NULL check for privroot. > > > > Reported-and-tested-by: syzbot+9b33c9b118d77ff59b6f@syzkaller.appspotmail.com > > Link: https://syzkaller.appspot.com/bug?extid=9b33c9b118d77ff59b6f > > Signed-off-by: Anmol Karn <anmol.karan123@gmail.com> > > Thanks for the patch! I've already fixed the problem myself (slightly > differently) but I'll comment about your patch below for educational > purposes :). See > https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git/commit/?h=for_next&id=c2bb80b8bdd04dfe32364b78b61b6a47f717af52 Ah, no worries, I am glad that, the bug is fixed :). I will mark this as fixed on syzbot. > > > diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c > > index 28b241cd6987..a75480d0ee7e 100644 > > --- a/fs/reiserfs/xattr.c > > +++ b/fs/reiserfs/xattr.c > > @@ -121,8 +121,9 @@ static struct dentry *open_xa_root(struct super_block *sb, int flags) > > struct dentry *privroot = REISERFS_SB(sb)->priv_root; > > struct dentry *xaroot; > > > > - if (d_really_is_negative(privroot)) > > + if (!privroot || d_really_is_negative(privroot)) { > > return ERR_PTR(-EOPNOTSUPP); > > I don't think EOPNOTSUPP is correct return code for !privroot case. AFAICS > it would propagate out of reiserfs xattr code and would result in denying > access to lookup_one_len() so xattr dir could never be initialized for such > filesystem. So we need to return 0 (success, no xattrs present) in this > case and because this is just a special case when we are initializing xattr > dir and recurse back into xattr code, I've decided to perform this check > directly in reiserfs_xattr_get(). Thanks for the review and information, sir. > > > + } > > There's no need for additional braces in this 'if'. > > > > inode_lock_nested(d_inode(privroot), I_MUTEX_XATTR); > > Honza > -- > Jan Kara <jack@suse.com> > SUSE Labs, CR Anmol
WARNING: multiple messages have this Message-ID (diff)
From: Anmol karn <anmol.karan123@gmail.com> To: Jan Kara <jack@suse.cz> Cc: syzkaller-bugs@googlegroups.com, jeffm@suse.com, syzbot+9b33c9b118d77ff59b6f@syzkaller.appspotmail.com, open list <linux-kernel@vger.kernel.org>, reiserfs-devel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH] fs: reiserfs: xattr: Fix null pointer derefernce in open_xa_root() Date: Thu, 1 Oct 2020 16:14:23 +0530 [thread overview] Message-ID: <CAC+yH-Z3243vRB6Nr7Y1FrfsQcmyjM0qH8D1FKSzSPEi=xa0uw@mail.gmail.com> (raw) In-Reply-To: <20201001092841.GC17860@quack2.suse.cz> On Thu, Oct 1, 2020 at 2:58 PM Jan Kara <jack@suse.cz> wrote: > > On Thu 01-10-20 14:35:47, Anmol Karn wrote: > > d_really_is_negative() checks for the dentry->d_inode whether it's NULL > > or not, but in open_xa_root(), when it checks 'privroot->d_inode', it > > doesn't check whether privroot is NULL or not, this leads to a null > > pointer dereference while calling it from open_xa_dir() while > > initializing xaroot. > > > > - fs/reiserfs/xattr.c > > The bug seems to get triggered at this line: > > > > if (d_really_is_negative(privroot)) > > return ERR_PTR(-EOPNOTSUPP); > > > > Fix it by adding a NULL check for privroot. > > > > Reported-and-tested-by: syzbot+9b33c9b118d77ff59b6f@syzkaller.appspotmail.com > > Link: https://syzkaller.appspot.com/bug?extid=9b33c9b118d77ff59b6f > > Signed-off-by: Anmol Karn <anmol.karan123@gmail.com> > > Thanks for the patch! I've already fixed the problem myself (slightly > differently) but I'll comment about your patch below for educational > purposes :). See > https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git/commit/?h=for_next&id=c2bb80b8bdd04dfe32364b78b61b6a47f717af52 Ah, no worries, I am glad that, the bug is fixed :). I will mark this as fixed on syzbot. > > > diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c > > index 28b241cd6987..a75480d0ee7e 100644 > > --- a/fs/reiserfs/xattr.c > > +++ b/fs/reiserfs/xattr.c > > @@ -121,8 +121,9 @@ static struct dentry *open_xa_root(struct super_block *sb, int flags) > > struct dentry *privroot = REISERFS_SB(sb)->priv_root; > > struct dentry *xaroot; > > > > - if (d_really_is_negative(privroot)) > > + if (!privroot || d_really_is_negative(privroot)) { > > return ERR_PTR(-EOPNOTSUPP); > > I don't think EOPNOTSUPP is correct return code for !privroot case. AFAICS > it would propagate out of reiserfs xattr code and would result in denying > access to lookup_one_len() so xattr dir could never be initialized for such > filesystem. So we need to return 0 (success, no xattrs present) in this > case and because this is just a special case when we are initializing xattr > dir and recurse back into xattr code, I've decided to perform this check > directly in reiserfs_xattr_get(). Thanks for the review and information, sir. > > > + } > > There's no need for additional braces in this 'if'. > > > > inode_lock_nested(d_inode(privroot), I_MUTEX_XATTR); > > Honza > -- > Jan Kara <jack@suse.com> > SUSE Labs, CR Anmol _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-01 10:44 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-01 9:05 [Linux-kernel-mentees] [PATCH] fs: reiserfs: xattr: Fix null pointer derefernce in open_xa_root() Anmol Karn 2020-10-01 9:05 ` Anmol Karn 2020-10-01 9:28 ` Jan Kara 2020-10-01 9:28 ` Jan Kara 2020-10-01 10:44 ` Anmol karn [this message] 2020-10-01 10:44 ` Anmol karn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAC+yH-Z3243vRB6Nr7Y1FrfsQcmyjM0qH8D1FKSzSPEi=xa0uw@mail.gmail.com' \ --to=anmol.karan123@gmail.com \ --cc=jack@suse.cz \ --cc=jeffm@suse.com \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=reiserfs-devel@vger.kernel.org \ --cc=syzbot+9b33c9b118d77ff59b6f@syzkaller.appspotmail.com \ --cc=syzkaller-bugs@googlegroups.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.