[PATCH] staging: media: davinci_vpfe: Change to "%s...", __func__

[PATCH] staging: media: davinci_vpfe: Change to "%s...", __func__

[Nishka Dasgupta]

Change string explicitly mentioning function name to "%s...", __func__.
Issue found with checkpatch.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 6a3434c..7d3349b 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -696,7 +696,7 @@ static int ipipe_get_gamma_params(struct vpfe_ipipe_device *ipipe, void *param)
 
 	if (!gamma->bypass_r && !gamma_param->table_r) {
 		dev_err(dev,
-			"ipipe_get_gamma_params: table ptr empty for R\n");
+			"%s: table ptr empty for R\n", __func__);
 		return -EINVAL;
 	}
 	memcpy(gamma_param->table_r, gamma->table_r,
-- 
2.7.4

Re: [PATCH] staging: media: davinci_vpfe: Change to "%s...", __func__

[Nishka Dasgupta]

Resending a patch. (I cannot locate it in my commit history, so I
can't resend it the proper way; I apologise for the inconvenience.)

Thanking you,
Nishka Dasgupta


On Mon, Mar 12, 2018 at 6:14 PM, Nishka Dasgupta
<nishka.dasgupta_ug18@ashoka.edu.in> wrote:
> Change string explicitly mentioning function name to "%s...", __func__.
> Issue found with checkpatch.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> ---
>  drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> index 6a3434c..7d3349b 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -696,7 +696,7 @@ static int ipipe_get_gamma_params(struct vpfe_ipipe_device *ipipe, void *param)
>
>         if (!gamma->bypass_r && !gamma_param->table_r) {
>                 dev_err(dev,
> -                       "ipipe_get_gamma_params: table ptr empty for R\n");
> +                       "%s: table ptr empty for R\n", __func__);
>                 return -EINVAL;
>         }
>         memcpy(gamma_param->table_r, gamma->table_r,
> --
> 2.7.4
>

Re: [Outreachy kernel] Re: [PATCH] staging: media: davinci_vpfe: Change to "%s...", __func__

[Julia Lawall]

On Mon, 19 Mar 2018, Nishka Dasgupta wrote:

> Resending a patch. (I cannot locate it in my commit history, so I
> can't resend it the proper way; I apologise for the inconvenience.)

You need to make the change again, and send the patch again.  This can't
be applied.

julia

>
> Thanking you,
> Nishka Dasgupta
>
>
> On Mon, Mar 12, 2018 at 6:14 PM, Nishka Dasgupta
> <nishka.dasgupta_ug18@ashoka.edu.in> wrote:
> > Change string explicitly mentioning function name to "%s...", __func__.
> > Issue found with checkpatch.
> >
> > Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> > ---
> >  drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> > index 6a3434c..7d3349b 100644
> > --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> > +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> > @@ -696,7 +696,7 @@ static int ipipe_get_gamma_params(struct vpfe_ipipe_device *ipipe, void *param)
> >
> >         if (!gamma->bypass_r && !gamma_param->table_r) {
> >                 dev_err(dev,
> > -                       "ipipe_get_gamma_params: table ptr empty for R\n");
> > +                       "%s: table ptr empty for R\n", __func__);
> >                 return -EINVAL;
> >         }
> >         memcpy(gamma_param->table_r, gamma->table_r,
> > --
> > 2.7.4
> >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAC4%2B%2BKCx8_PewSvZx9v%3DGsFZ8f%2Bqb29SO8qYRGXS_YFmAmveHw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>