From: Rajat Jain <rajatja@google.com> To: "Alex G." <mr.nuke.me@gmail.com> Cc: Bjorn Helgaas <bhelgaas@google.com>, Jonathan Corbet <corbet@lwn.net>, Philippe Ombredanne <pombredanne@nexb.com>, Kate Stewart <kstewart@linuxfoundation.org>, Thomas Gleixner <tglx@linutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Frederick Lawler <fred@fredlawl.com>, Oza Pawandeep <poza@codeaurora.org>, Keith Busch <keith.busch@intel.com>, Gabriele Paoloni <gabriele.paoloni@huawei.com>, Thomas Tai <thomas.tai@oracle.com>, "Steven Rostedt (VMware)" <rostedt@goodmis.org>, linux-pci <linux-pci@vger.kernel.org>, linux-doc@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Jes Sorensen <jsorensen@fb.com>, Kyle McMartin <jkkm@fb.com>, Rajat Jain <rajatxjain@gmail.com> Subject: Re: [PATCH 5/5] Documentation/PCI: Add details of PCI AER statistics Date: Tue, 22 May 2018 16:18:45 -0700 [thread overview] Message-ID: <CACK8Z6E7Ax=_Ai7XOic5hWMRqQXiOox2z-w23j0S3O9P5AnCLw@mail.gmail.com> (raw) In-Reply-To: <cffe5b81-a05c-a249-8c36-70a9c4d61e7f@gmail.com> Hi, On Tue, May 22, 2018 at 3:52 PM, Alex G. <mr.nuke.me@gmail.com> wrote: > On 05/22/2018 05:28 PM, Rajat Jain wrote: >> Add the PCI AER statistics details to >> Documentation/PCI/pcieaer-howto.txt >> >> Signed-off-by: Rajat Jain <rajatja@google.com> >> --- >> Documentation/PCI/pcieaer-howto.txt | 35 +++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/Documentation/PCI/pcieaer-howto.txt b/Documentation/PCI/pcieaer-howto.txt >> index acd0dddd6bb8..86ee9f9ff5e1 100644 >> --- a/Documentation/PCI/pcieaer-howto.txt >> +++ b/Documentation/PCI/pcieaer-howto.txt >> @@ -73,6 +73,41 @@ In the example, 'Requester ID' means the ID of the device who sends >> the error message to root port. Pls. refer to pci express specs for >> other fields. >> >> +2.4 AER statistics >> + >> +When AER messages are captured, the statistics are exposed via the following >> +sysfs attributes under the "aer_stats" folder for the device: >> + >> +2.4.1 Device sysfs Attributes >> + >> +These attributes show up under all the devices that are AER capable. These >> +indicate the errors "as seen by the device". Note that this may mean that if >> +an end point is causing problems, the AER counters may increment at its link >> +partner (e.g. root port) because the errors will be "seen" by the link partner >> +and not the the problematic end point itself (which may report all counters >> +as 0 as it never saw any problems). > > I was afraid of that. Is there a way to look at the requester ID to log > AER errors to the correct device? I do not think it is possible to pin point the source of the problem. Errors may be caused due to sub optimal link tuning, or signal integrity, or either of the link partners. Both the link partners will detect and report the errors that they "see". The bits and errors defined by the PCIe spec, follow the same semantics i.e. => the spec defines the different error conditions "as seen/encountered by the device", => Thus the device reports those errors to the root port => which is what we are counting and reporting here. IMHO, any interpretation / analysis of this error data / counters should be left to the user so that he can look at different devices and the errors they see, and then conclude on what might be the problem. Thanks, Rajat > > Alex
WARNING: multiple messages have this Message-ID (diff)
From: Rajat Jain <rajatja@google.com> To: "Alex G." <mr.nuke.me@gmail.com> Cc: Bjorn Helgaas <bhelgaas@google.com>, Jonathan Corbet <corbet@lwn.net>, Philippe Ombredanne <pombredanne@nexb.com>, Kate Stewart <kstewart@linuxfoundation.org>, Thomas Gleixner <tglx@linutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Frederick Lawler <fred@fredlawl.com>, Oza Pawandeep <poza@codeaurora.org>, Keith Busch <keith.busch@intel.com>, Gabriele Paoloni <gabriele.paoloni@huawei.com>, Thomas Tai <thomas.tai@oracle.com>, "Steven Rostedt (VMware)" <rostedt@goodmis.org>, linux-pci <linux-pci@vger.kernel.org>, linux-doc@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Jes Sorensen <jsorensen@fb.com>, Kyle McMartin <jkkm@fb.com>, Rajat Jain <rajatxjain@gmail.com> Subject: Re: [PATCH 5/5] Documentation/PCI: Add details of PCI AER statistics Date: Tue, 22 May 2018 16:18:45 -0700 [thread overview] Message-ID: <CACK8Z6E7Ax=_Ai7XOic5hWMRqQXiOox2z-w23j0S3O9P5AnCLw@mail.gmail.com> (raw) In-Reply-To: <cffe5b81-a05c-a249-8c36-70a9c4d61e7f@gmail.com> Hi, On Tue, May 22, 2018 at 3:52 PM, Alex G. <mr.nuke.me@gmail.com> wrote: > On 05/22/2018 05:28 PM, Rajat Jain wrote: >> Add the PCI AER statistics details to >> Documentation/PCI/pcieaer-howto.txt >> >> Signed-off-by: Rajat Jain <rajatja@google.com> >> --- >> Documentation/PCI/pcieaer-howto.txt | 35 +++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/Documentation/PCI/pcieaer-howto.txt b/Documentation/PCI/pcieaer-howto.txt >> index acd0dddd6bb8..86ee9f9ff5e1 100644 >> --- a/Documentation/PCI/pcieaer-howto.txt >> +++ b/Documentation/PCI/pcieaer-howto.txt >> @@ -73,6 +73,41 @@ In the example, 'Requester ID' means the ID of the device who sends >> the error message to root port. Pls. refer to pci express specs for >> other fields. >> >> +2.4 AER statistics >> + >> +When AER messages are captured, the statistics are exposed via the following >> +sysfs attributes under the "aer_stats" folder for the device: >> + >> +2.4.1 Device sysfs Attributes >> + >> +These attributes show up under all the devices that are AER capable. These >> +indicate the errors "as seen by the device". Note that this may mean that if >> +an end point is causing problems, the AER counters may increment at its link >> +partner (e.g. root port) because the errors will be "seen" by the link partner >> +and not the the problematic end point itself (which may report all counters >> +as 0 as it never saw any problems). > > I was afraid of that. Is there a way to look at the requester ID to log > AER errors to the correct device? I do not think it is possible to pin point the source of the problem. Errors may be caused due to sub optimal link tuning, or signal integrity, or either of the link partners. Both the link partners will detect and report the errors that they "see". The bits and errors defined by the PCIe spec, follow the same semantics i.e. => the spec defines the different error conditions "as seen/encountered by the device", => Thus the device reports those errors to the root port => which is what we are counting and reporting here. IMHO, any interpretation / analysis of this error data / counters should be left to the user so that he can look at different devices and the errors they see, and then conclude on what might be the problem. Thanks, Rajat > > Alex -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-22 23:18 UTC|newest] Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-22 22:28 [PATCH 0/5] Expose PCIe AER stats via sysfs Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-22 22:28 ` [PATCH 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-23 8:27 ` Greg Kroah-Hartman 2018-05-23 8:27 ` Greg Kroah-Hartman 2018-05-23 14:20 ` Jes Sorensen 2018-05-23 14:20 ` Jes Sorensen 2018-05-23 14:26 ` Alex G. 2018-05-23 14:26 ` Alex G. 2018-05-23 14:28 ` Jes Sorensen 2018-05-23 14:28 ` Jes Sorensen 2018-05-23 14:26 ` Matthew Wilcox 2018-05-23 14:26 ` Matthew Wilcox 2018-05-23 14:32 ` Jes Sorensen 2018-05-23 14:32 ` Jes Sorensen 2018-05-23 14:33 ` Alex G. 2018-05-23 14:33 ` Alex G. 2018-05-23 14:46 ` Steven Rostedt 2018-05-23 14:46 ` Steven Rostedt 2018-05-22 22:28 ` [PATCH 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-22 22:50 ` Alex G. 2018-05-22 22:50 ` Alex G. 2018-05-22 23:27 ` Rajat Jain 2018-05-22 23:27 ` Rajat Jain 2018-05-22 23:30 ` Sinan Kaya 2018-05-22 23:30 ` Sinan Kaya 2018-05-23 8:22 ` Greg Kroah-Hartman 2018-05-23 8:22 ` Greg Kroah-Hartman 2018-05-23 8:24 ` Greg Kroah-Hartman 2018-05-23 8:24 ` Greg Kroah-Hartman 2018-05-22 22:28 ` [PATCH 3/5] PCP/AER: Add sysfs attributes to provide breakdown of AERs Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-23 8:25 ` Greg Kroah-Hartman 2018-05-23 8:25 ` Greg Kroah-Hartman 2018-05-22 22:28 ` [PATCH 4/5] PCI/AER: Add sysfs attributes for rootport cumulative stats Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-22 22:28 ` [PATCH 5/5] Documentation/PCI: Add details of PCI AER statistics Rajat Jain 2018-05-22 22:28 ` Rajat Jain 2018-05-22 22:52 ` Alex G. 2018-05-22 22:52 ` Alex G. 2018-05-22 23:18 ` Rajat Jain [this message] 2018-05-22 23:18 ` Rajat Jain 2018-05-23 8:23 ` Greg Kroah-Hartman 2018-05-23 8:23 ` Greg Kroah-Hartman 2018-05-23 17:58 ` [PATCH v2 0/5] Expose PCIe AER stats via sysfs Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-23 17:58 ` [PATCH v2 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-24 6:08 ` Greg Kroah-Hartman 2018-05-24 6:08 ` Greg Kroah-Hartman 2018-05-23 17:58 ` [PATCH v2 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-23 17:58 ` [PATCH v2 3/5] PCI/AER: Add sysfs attributes to provide breakdown of AERs Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-23 17:58 ` [PATCH v2 4/5] PCI/AER: Add sysfs attributes for rootport cumulative stats Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-05-23 17:58 ` [PATCH v2 5/5] Documentation/ABI: Add details of PCI AER statistics Rajat Jain 2018-05-23 17:58 ` Rajat Jain 2018-06-17 5:24 ` poza 2018-06-17 5:24 ` poza 2018-06-19 0:11 ` Rajat Jain 2018-06-19 0:11 ` Rajat Jain 2018-06-19 0:32 ` Rajat Jain 2018-06-19 0:32 ` Rajat Jain 2018-06-19 6:03 ` poza 2018-06-19 6:03 ` poza 2018-06-19 16:31 ` Rajat Jain 2018-06-19 16:31 ` Rajat Jain 2018-06-21 9:19 ` poza 2018-06-21 9:19 ` poza 2018-06-22 0:45 ` Rajat Jain 2018-06-22 0:45 ` Rajat Jain 2018-06-19 22:16 ` [PATCH v2 0/5] Expose PCIe AER stats via sysfs Bjorn Helgaas 2018-06-19 22:16 ` Bjorn Helgaas 2018-06-19 22:17 ` Rajat Jain 2018-06-19 22:17 ` Rajat Jain 2018-06-19 22:20 ` Alex G. 2018-06-19 22:20 ` Alex G. 2018-06-19 22:25 ` Steven Rostedt 2018-06-19 22:25 ` Steven Rostedt 2018-06-19 22:29 ` Alex G. 2018-06-19 22:29 ` Alex G. 2018-06-20 1:12 ` [PATCH v3 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 1:12 ` [PATCH v3 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 1:12 ` [PATCH v3 3/5] PCI/AER: Add sysfs attributes to provide breakdown of AERs Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 1:12 ` [PATCH v3 4/5] PCI/AER: Add sysfs attributes for rootport cumulative stats Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 3:13 ` kbuild test robot 2018-06-20 3:13 ` kbuild test robot 2018-06-20 1:12 ` [PATCH v3 5/5] Documentation/ABI: Add details of PCI AER statistics Rajat Jain 2018-06-20 1:12 ` Rajat Jain 2018-06-20 23:28 ` [PATCH v4 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Rajat Jain 2018-06-20 23:28 ` Rajat Jain 2018-06-20 23:28 ` [PATCH v4 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-06-20 23:28 ` Rajat Jain 2018-06-20 23:41 ` [PATCH v5 1/5] PCI/AER: Define and allocate aer_stats structure " Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-20 23:41 ` [PATCH v5 2/5] PCI/AER: Add sysfs stats " Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-20 23:41 ` [PATCH v5 3/5] PCI/AER: Add sysfs attributes to provide breakdown of AERs Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-21 18:48 ` Bjorn Helgaas 2018-06-21 18:48 ` Bjorn Helgaas 2018-06-21 21:25 ` Rajat Jain 2018-06-21 21:25 ` Rajat Jain 2018-06-22 16:38 ` Tyler Baicar 2018-06-22 16:38 ` Tyler Baicar 2018-06-22 17:27 ` Bjorn Helgaas 2018-06-22 17:27 ` Bjorn Helgaas 2018-06-20 23:41 ` [PATCH v5 4/5] PCI/AER: Add sysfs attributes for rootport cumulative stats Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-20 23:41 ` [PATCH v5 5/5] Documentation/ABI: Add details of PCI AER statistics Rajat Jain 2018-06-20 23:41 ` Rajat Jain 2018-06-21 13:17 ` [PATCH v5 1/5] PCI/AER: Define and allocate aer_stats structure for AER capable devices Bjorn Helgaas 2018-06-21 13:17 ` Bjorn Helgaas 2018-06-21 20:41 ` Rajat Jain 2018-06-21 20:41 ` Rajat Jain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACK8Z6E7Ax=_Ai7XOic5hWMRqQXiOox2z-w23j0S3O9P5AnCLw@mail.gmail.com' \ --to=rajatja@google.com \ --cc=bhelgaas@google.com \ --cc=corbet@lwn.net \ --cc=fred@fredlawl.com \ --cc=gabriele.paoloni@huawei.com \ --cc=gregkh@linuxfoundation.org \ --cc=jkkm@fb.com \ --cc=jsorensen@fb.com \ --cc=keith.busch@intel.com \ --cc=kstewart@linuxfoundation.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=mr.nuke.me@gmail.com \ --cc=pombredanne@nexb.com \ --cc=poza@codeaurora.org \ --cc=rajatxjain@gmail.com \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=thomas.tai@oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.