From: Karol Herbst <kherbst@redhat.com>
To: Mika Westerberg <mika.westerberg@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lyude Paul <lyude@redhat.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Linux PCI <linux-pci@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
nouveau <nouveau@lists.freedesktop.org>
Subject: Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges
Date: Mon, 21 Oct 2019 14:00:46 +0200 [thread overview]
Message-ID: <CACO55tt2iGcySugTAb1khEYpiGoq6Os3upG5fGq+0PbE2gyyeQ@mail.gmail.com> (raw)
In-Reply-To: <20191021114017.GY2819@lahna.fi.intel.com>
On Mon, Oct 21, 2019 at 1:40 PM Mika Westerberg
<mika.westerberg@intel.com> wrote:
>
> Hi Karol,
>
> Sorry for commenting late, I just came back from vacation.
>
> On Wed, Oct 16, 2019 at 04:44:49PM +0200, Karol Herbst wrote:
> > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device
> > states.
> >
> > v2: convert to pci_dev quirk
> > put a proper technical explanation of the issue as a in-code comment
> > v3: disable it only for certain combinations of intel and nvidia hardware
> >
> > Signed-off-by: Karol Herbst <kherbst@redhat.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> > Cc: Mika Westerberg <mika.westerberg@intel.com>
> > Cc: linux-pci@vger.kernel.org
> > Cc: linux-pm@vger.kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: nouveau@lists.freedesktop.org
> > ---
> > drivers/pci/pci.c | 11 ++++++++++
> > drivers/pci/quirks.c | 52 ++++++++++++++++++++++++++++++++++++++++++++
>
> I may be missing something but why you can't do this in the nouveau
> driver itself?
What do you mean precisely? Move the quirk into nouveau, but keep the
changes to pci core?
WARNING: multiple messages have this Message-ID (diff)
From: Karol Herbst <kherbst@redhat.com>
To: Mika Westerberg <mika.westerberg@intel.com>
Cc: Linux PM <linux-pm@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
nouveau <nouveau@lists.freedesktop.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges
Date: Mon, 21 Oct 2019 14:00:46 +0200 [thread overview]
Message-ID: <CACO55tt2iGcySugTAb1khEYpiGoq6Os3upG5fGq+0PbE2gyyeQ@mail.gmail.com> (raw)
In-Reply-To: <20191021114017.GY2819@lahna.fi.intel.com>
On Mon, Oct 21, 2019 at 1:40 PM Mika Westerberg
<mika.westerberg@intel.com> wrote:
>
> Hi Karol,
>
> Sorry for commenting late, I just came back from vacation.
>
> On Wed, Oct 16, 2019 at 04:44:49PM +0200, Karol Herbst wrote:
> > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device
> > states.
> >
> > v2: convert to pci_dev quirk
> > put a proper technical explanation of the issue as a in-code comment
> > v3: disable it only for certain combinations of intel and nvidia hardware
> >
> > Signed-off-by: Karol Herbst <kherbst@redhat.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> > Cc: Mika Westerberg <mika.westerberg@intel.com>
> > Cc: linux-pci@vger.kernel.org
> > Cc: linux-pm@vger.kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: nouveau@lists.freedesktop.org
> > ---
> > drivers/pci/pci.c | 11 ++++++++++
> > drivers/pci/quirks.c | 52 ++++++++++++++++++++++++++++++++++++++++++++
>
> I may be missing something but why you can't do this in the nouveau
> driver itself?
What do you mean precisely? Move the quirk into nouveau, but keep the
changes to pci core?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-21 12:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 14:44 [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Karol Herbst
2019-10-16 14:44 ` Karol Herbst
2019-10-16 19:14 ` Bjorn Helgaas
2019-10-16 19:18 ` Karol Herbst
2019-10-16 21:37 ` Bjorn Helgaas
2019-10-16 21:37 ` Bjorn Helgaas
2019-10-16 21:48 ` Karol Herbst
2019-10-16 21:48 ` Karol Herbst
2019-10-16 22:03 ` Bjorn Helgaas
2019-10-16 22:03 ` Bjorn Helgaas
2019-10-21 13:33 ` Mika Westerberg
2019-10-21 13:54 ` Karol Herbst
2019-10-21 14:08 ` Mika Westerberg
2019-10-21 14:49 ` Karol Herbst
2019-10-21 15:46 ` Mika Westerberg
2019-10-21 15:46 ` Mika Westerberg
2019-10-21 16:40 ` Karol Herbst
2019-10-22 9:16 ` Karol Herbst
2019-10-22 12:44 ` Mika Westerberg
2019-10-22 12:51 ` Karol Herbst
2019-10-23 9:00 ` Mika Westerberg
2019-10-23 9:00 ` Mika Westerberg
2019-10-21 11:40 ` Mika Westerberg
2019-10-21 12:00 ` Karol Herbst [this message]
2019-10-21 12:00 ` Karol Herbst
2019-10-21 12:06 ` Mika Westerberg
2019-10-21 12:06 ` Mika Westerberg
2019-10-21 13:02 ` Karol Herbst
2019-10-21 13:02 ` Karol Herbst
2019-10-21 13:21 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACO55tt2iGcySugTAb1khEYpiGoq6Os3upG5fGq+0PbE2gyyeQ@mail.gmail.com \
--to=kherbst@redhat.com \
--cc=bhelgaas@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=mika.westerberg@intel.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.