Re: [linux dev-4.19 00/15] dd NPCM7xx patches to dev-4.19

[Joel Stanley <joel@jms.id.au>]

Hi Tomer,

On Tue, 15 Jan 2019 at 00:07, Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> Hi Joel,
>
> Please add the following NPCM7xx patches to dev-4.19:

I applied your series and it does not compile. I am using the
npcm7xx_defconfig you included:

arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function
`npcm_smb_calc_crc8':
drivers/i2c/busses/i2c-npcm7xx.c:423: undefined reference to `crc8'
arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function
`__npcm_i2c_init':
drivers/i2c/busses/i2c-npcm7xx.c:1668: undefined reference to
`crc8_populate_lsb'
drivers/i2c/busses/i2c-npcm7xx.c:1669: undefined reference to
`crc8_populate_msb'

Please test the patchset exactly as you intend to send before sending it.

In this case you needed to add `selects CRC8` to drivers/i2c/busses/Kconfig.

You also have some warnings. Please send follow up patches ASAP to
resolve these:

../drivers/iio/adc/npcm_adc.c: In function ‘npcm_adc_probe’:
../drivers/iio/adc/npcm_adc.c:301:9: warning: ‘ret’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
  return ret;
         ^~~

arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning (pci_bridge):
/ahb/axi-pcie@e1000000: node name is not "pci" or "pcie"
arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning
(pci_device_bus_num): Failed prerequisite 'pci_bridge'

I have done this for you and the tree now builds. I've merged the
patches into dev-4.19 and will push out once I've finished testing.

Cheers,

Joel