Re: [linux dev-4.19 00/15] dd NPCM7xx patches to dev-4.19

[Tomer Maimon <tmaimon77@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2331 bytes --]

Hi Joel,

Thanks a lot for applying the patches

On Wed, 16 Jan 2019 at 01:46, Joel Stanley <joel@jms.id.au> wrote:

> Hi Tomer,
>
> On Tue, 15 Jan 2019 at 00:07, Tomer Maimon <tmaimon77@gmail.com> wrote:
> >
> > Hi Joel,
> >
> > Please add the following NPCM7xx patches to dev-4.19:
>
> I applied your series and it does not compile. I am using the
> npcm7xx_defconfig you included:
>
> arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function
> `npcm_smb_calc_crc8':
> drivers/i2c/busses/i2c-npcm7xx.c:423: undefined reference to `crc8'
> arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function
> `__npcm_i2c_init':
> drivers/i2c/busses/i2c-npcm7xx.c:1668: undefined reference to
> `crc8_populate_lsb'
> drivers/i2c/busses/i2c-npcm7xx.c:1669: undefined reference to
> `crc8_populate_msb'
>
> Please test the patchset exactly as you intend to send before sending it.
>
>
I did test the patches with
https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads/8-2-2018-08
(gcc-arm-8.2-2018.08-x86_64-arm-linux-gnueabi)
So I do not understand why you get this failures


> In this case you needed to add `selects CRC8` to
> drivers/i2c/busses/Kconfig.
>
> You also have some warnings. Please send follow up patches ASAP to
> resolve these:
>
> ../drivers/iio/adc/npcm_adc.c: In function ‘npcm_adc_probe’:
> ../drivers/iio/adc/npcm_adc.c:301:9: warning: ‘ret’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>   return ret;
>          ^~~
>
> About the ADC patch you are right, somehow I didn't send the latest code
of the ADC driver. I will send it today.


> arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning (pci_bridge):
> /ahb/axi-pcie@e1000000: node name is not "pci" or "pcie"
> arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning
> (pci_device_bus_num): Failed prerequisite 'pci_bridge'
>
> In the patch set you can find patch
[linux dev-4.19 15/15] dts: npcm7xx: Modify NPCM7xx device tree
It's fix the above warnings and modify other node.
please apply it.

> I have done this for you and the tree now builds. I've merged the
> patches into dev-4.19 and will push out once I've finished testing.
>
> Cheers,
>
> Joel
>

I will make sure to send all the fixes today.

Thanks a lot,

Tomer

[-- Attachment #2: Type: text/html, Size: 3995 bytes --]