From: Linus Walleij <linus.walleij@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Kevin Hilman <khilman@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 1/3] pinctrl: rollback check for !dev->pins in pinctrl_pm_select*() APIs
Date: Sat, 27 Jul 2013 01:22:37 +0200 [thread overview]
Message-ID: <CACRpkdYZOFYNXDwMr6om=3Fuj9z3DnaXYHQ_3B-xfTk9dsWdnQ@mail.gmail.com> (raw)
In-Reply-To: <20130717154038.GK7656@atomide.com>
On Wed, Jul 17, 2013 at 5:40 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [130717 04:49]:
>> The pinctrl support in Device core assumed to be optional - so, It's
>> valid case, when there are no definition for default device's pinctrl
>> states in DT at all ("default", "active", "idle", "sleep").
>> And in this case dev->pins == NULL and pinctrl_pm_select*() API
>> should return 0 always.
>>
>> Now the checks for !dev->pins have been removed from
>> pinctrl_pm_select*() API mistakenly by the patch
>> pinctrl: Remove duplicate code in pinctrl_pm_select_state functions
>> http://www.spinics.net/lists/arm-kernel/msg258829.html
>>
>> Hence, rollback these checks in in pinctrl_pm_select*() APIs.
>
> Thanks, it's best that I fold this fix into my patch as it has not
> been committed yet.
I think I've applied the correct v2 version,
please check that linux-next is in good shape...
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] pinctrl: rollback check for !dev->pins in pinctrl_pm_select*() APIs
Date: Sat, 27 Jul 2013 01:22:37 +0200 [thread overview]
Message-ID: <CACRpkdYZOFYNXDwMr6om=3Fuj9z3DnaXYHQ_3B-xfTk9dsWdnQ@mail.gmail.com> (raw)
In-Reply-To: <20130717154038.GK7656@atomide.com>
On Wed, Jul 17, 2013 at 5:40 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [130717 04:49]:
>> The pinctrl support in Device core assumed to be optional - so, It's
>> valid case, when there are no definition for default device's pinctrl
>> states in DT at all ("default", "active", "idle", "sleep").
>> And in this case dev->pins == NULL and pinctrl_pm_select*() API
>> should return 0 always.
>>
>> Now the checks for !dev->pins have been removed from
>> pinctrl_pm_select*() API mistakenly by the patch
>> pinctrl: Remove duplicate code in pinctrl_pm_select_state functions
>> http://www.spinics.net/lists/arm-kernel/msg258829.html
>>
>> Hence, rollback these checks in in pinctrl_pm_select*() APIs.
>
> Thanks, it's best that I fold this fix into my patch as it has not
> been committed yet.
I think I've applied the correct v2 version,
please check that linux-next is in good shape...
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-07-26 23:22 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 11:41 [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 11:41 ` [PATCH 1/3] pinctrl: rollback check for !dev->pins in pinctrl_pm_select*() APIs Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 15:40 ` Tony Lindgren
2013-07-17 15:40 ` Tony Lindgren
2013-07-26 23:22 ` Linus Walleij [this message]
2013-07-26 23:22 ` Linus Walleij
2013-07-26 23:22 ` Linus Walleij
2013-07-17 11:41 ` [PATCH 2/3] ARM: OMAP2+: omap_device: add pinctrl handling Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 15:38 ` Tony Lindgren
2013-07-17 15:38 ` Tony Lindgren
2013-07-17 16:56 ` Grygorii Strashko
2013-07-17 16:56 ` Grygorii Strashko
2013-07-17 16:56 ` Grygorii Strashko
2013-07-18 8:14 ` Tony Lindgren
2013-07-18 8:14 ` Tony Lindgren
2013-07-18 11:22 ` Grygorii Strashko
2013-07-18 11:22 ` Grygorii Strashko
2013-07-18 11:22 ` Grygorii Strashko
2013-07-17 11:41 ` [PATCH 3/3] ARM: dts: omap4-sdp: add dynamic pin states for uart3/4 Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 15:32 ` Tony Lindgren
2013-07-17 15:32 ` Tony Lindgren
2013-07-17 15:32 ` Tony Lindgren
2013-07-17 16:41 ` Grygorii Strashko
2013-07-17 16:41 ` Grygorii Strashko
2013-07-17 16:41 ` Grygorii Strashko
2013-07-18 8:09 ` Tony Lindgren
2013-07-18 8:09 ` Tony Lindgren
2013-07-18 8:09 ` Tony Lindgren
2013-07-18 8:54 ` Grygorii Strashko
2013-07-18 8:54 ` Grygorii Strashko
2013-07-18 8:54 ` Grygorii Strashko
2013-07-18 9:04 ` Tony Lindgren
2013-07-18 9:04 ` Tony Lindgren
2013-07-18 12:01 ` Grygorii Strashko
2013-07-18 12:01 ` Grygorii Strashko
2013-07-18 12:01 ` Grygorii Strashko
2013-07-17 11:57 ` [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling Roger Quadros
2013-07-17 11:57 ` Roger Quadros
2013-07-17 11:57 ` Roger Quadros
2013-07-17 12:30 ` Grygorii Strashko
2013-07-17 12:30 ` Grygorii Strashko
2013-07-17 12:30 ` Grygorii Strashko
2013-07-18 6:44 ` Roger Quadros
2013-07-18 6:44 ` Roger Quadros
2013-07-18 6:44 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYZOFYNXDwMr6om=3Fuj9z3DnaXYHQ_3B-xfTk9dsWdnQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grygorii.strashko@ti.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.