All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	phone-devel@vger.kernel.org,
	"Noralf Trønnes" <noralf@tronnes.org>
Subject: Re: [PATCH 2/2 v4] drm/panel: ws2401: Add driver for WideChips WS2401
Date: Thu, 15 Jul 2021 09:55:35 +0200	[thread overview]
Message-ID: <CACRpkdauv+UUAFwOgOJdVGEo+5-z89QHH-ZisWRLNBFsbhmhAA@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=WnO+vH_6-KC8WZ4AyGY9knWz6ecK3Hwqy9CQX1RnZzQw@mail.gmail.com>

On Thu, Jul 15, 2021 at 4:25 AM Doug Anderson <dianders@chromium.org> wrote:

> > - Alter the logic so that we assign the backlight handle to
> >   panel->backlight directly and save some code.
>
> Officially this is disallowed according to comments. ...and I quote:
>
> /**
>  * @backlight:
>  *
>  * Backlight device, used to turn on backlight after the call
>  * to enable(), and to turn off backlight before the call to
>  * disable().
>  * backlight is set by drm_panel_of_backlight() or
>  * drm_panel_dp_aux_backlight() and drivers shall not assign it.
>  */
>
> I do not personally know the motivation of not letting drivers assign
> it, but with the words "shall not". Yikes!

I think it's a documentation bug. I trust Sam more than the docs.
I'll send a patch.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: "Noralf Trønnes" <noralf@tronnes.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH 2/2 v4] drm/panel: ws2401: Add driver for WideChips WS2401
Date: Thu, 15 Jul 2021 09:55:35 +0200	[thread overview]
Message-ID: <CACRpkdauv+UUAFwOgOJdVGEo+5-z89QHH-ZisWRLNBFsbhmhAA@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=WnO+vH_6-KC8WZ4AyGY9knWz6ecK3Hwqy9CQX1RnZzQw@mail.gmail.com>

On Thu, Jul 15, 2021 at 4:25 AM Doug Anderson <dianders@chromium.org> wrote:

> > - Alter the logic so that we assign the backlight handle to
> >   panel->backlight directly and save some code.
>
> Officially this is disallowed according to comments. ...and I quote:
>
> /**
>  * @backlight:
>  *
>  * Backlight device, used to turn on backlight after the call
>  * to enable(), and to turn off backlight before the call to
>  * disable().
>  * backlight is set by drm_panel_of_backlight() or
>  * drm_panel_dp_aux_backlight() and drivers shall not assign it.
>  */
>
> I do not personally know the motivation of not letting drivers assign
> it, but with the words "shall not". Yikes!

I think it's a documentation bug. I trust Sam more than the docs.
I'll send a patch.

Yours,
Linus Walleij

  reply	other threads:[~2021-07-15  7:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 22:50 [PATCH 1/2 v4] drm/panel: Add DT bindings for Samsung LMS380KF01 Linus Walleij
2021-07-14 22:50 ` Linus Walleij
2021-07-14 22:50 ` [PATCH 2/2 v4] drm/panel: ws2401: Add driver for WideChips WS2401 Linus Walleij
2021-07-14 22:50   ` Linus Walleij
2021-07-15  2:25   ` Doug Anderson
2021-07-15  2:25     ` Doug Anderson
2021-07-15  7:55     ` Linus Walleij [this message]
2021-07-15  7:55       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdauv+UUAFwOgOJdVGEo+5-z89QHH-ZisWRLNBFsbhmhAA@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=noralf@tronnes.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.