From: Rodrigo Campos <rodrigo@kinvolk.io>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
Linux Containers <containers@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>,
Alban Crequy <alban@kinvolk.io>
Subject: Re: [PATCH 1/1] seccomp: Always "goto wait" if the list is empty
Date: Tue, 13 Apr 2021 20:02:35 +0200 [thread overview]
Message-ID: <CACaBj2ZieT2vH3_ywSkzzWXjJuSdBr1ytXdazTJ9-8mmA7xNvg@mail.gmail.com> (raw)
In-Reply-To: <20210413175355.kttgdouoyiykug5i@wittgenstein>
On Tue, Apr 13, 2021 at 7:54 PM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
> > Fixes: 7cf97b1254550
> > Cc: stable@vger.kernel.org # 5.9+
> > Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
> > ---
>
> So the agent will see the return value from
> wait_for_completion_interruptible() and know that the addfd wasn't
> successful and the target will notice that no addfd request has actually
> been added and essentially try again. Seems like a decent fix and can be
Yes, exactly!
> backported cleanly. I assume seccomp testsuite passes.
Yes, seccomp selftests (tools/testing/selftests/seccomp/seccomp_bpf) passes fine
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Thanks!
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers
WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Campos <rodrigo@kinvolk.io>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: "Kees Cook" <keescook@chromium.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Will Drewry" <wad@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
"Linux Containers" <containers@lists.linux-foundation.org>,
"Sargun Dhillon" <sargun@sargun.me>,
"Mauricio Vásquez Bernal" <mauricio@kinvolk.io>,
"Alban Crequy" <alban@kinvolk.io>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] seccomp: Always "goto wait" if the list is empty
Date: Tue, 13 Apr 2021 20:02:35 +0200 [thread overview]
Message-ID: <CACaBj2ZieT2vH3_ywSkzzWXjJuSdBr1ytXdazTJ9-8mmA7xNvg@mail.gmail.com> (raw)
In-Reply-To: <20210413175355.kttgdouoyiykug5i@wittgenstein>
On Tue, Apr 13, 2021 at 7:54 PM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
> > Fixes: 7cf97b1254550
> > Cc: stable@vger.kernel.org # 5.9+
> > Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
> > ---
>
> So the agent will see the return value from
> wait_for_completion_interruptible() and know that the addfd wasn't
> successful and the target will notice that no addfd request has actually
> been added and essentially try again. Seems like a decent fix and can be
Yes, exactly!
> backported cleanly. I assume seccomp testsuite passes.
Yes, seccomp selftests (tools/testing/selftests/seccomp/seccomp_bpf) passes fine
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Thanks!
next prev parent reply other threads:[~2021-04-13 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 16:01 [PATCH 0/1] seccomp: Erroneous return on interrupted addfd ioctl() Rodrigo Campos
2021-04-13 16:01 ` Rodrigo Campos
2021-04-13 16:01 ` [PATCH 1/1] seccomp: Always "goto wait" if the list is empty Rodrigo Campos
2021-04-13 16:01 ` Rodrigo Campos
2021-04-13 17:53 ` Christian Brauner
2021-04-13 17:53 ` Christian Brauner
2021-04-13 18:02 ` Rodrigo Campos [this message]
2021-04-13 18:02 ` Rodrigo Campos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACaBj2ZieT2vH3_ywSkzzWXjJuSdBr1ytXdazTJ9-8mmA7xNvg@mail.gmail.com \
--to=rodrigo@kinvolk.io \
--cc=alban@kinvolk.io \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=stable@vger.kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.