From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
boris brezillon <b.brezillon@overkiz.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 3/8] at91: dt: Add at91sam9261 dt SoC support
Date: Thu, 13 Feb 2014 07:11:38 +0100 [thread overview]
Message-ID: <CACh+v5O0fJAvT0Ze9RkcVgLQ22Lod+m1ACj0K=GLLA=9r5tVvg@mail.gmail.com> (raw)
In-Reply-To: <20140212210446.GF11498@piout.net>
2014-02-12 22:04 GMT+01:00 Alexandre Belloni
<alexandre.belloni@free-electrons.com>:
> Sorry, one more comment on that patch:
>
> On 12/02/2014 at 11:06:42 +0100, Jean-Jacques Hiblot wrote :
>> + pinctrl@fffff400 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "atmel,at91rm9200-pinctrl", "simple-bus";
>> + ranges = <0xfffff400 0xfffff400 0xa00>;
>> +
> I believe you got the range wrong, shouldn't it be:
> ranges = <0xfffff400 0xfffff400 0x600>;
>
Yes you're right.
Thanks for the review
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: jjhiblot@traphandler.com (Jean-Jacques Hiblot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/8] at91: dt: Add at91sam9261 dt SoC support
Date: Thu, 13 Feb 2014 07:11:38 +0100 [thread overview]
Message-ID: <CACh+v5O0fJAvT0Ze9RkcVgLQ22Lod+m1ACj0K=GLLA=9r5tVvg@mail.gmail.com> (raw)
In-Reply-To: <20140212210446.GF11498@piout.net>
2014-02-12 22:04 GMT+01:00 Alexandre Belloni
<alexandre.belloni@free-electrons.com>:
> Sorry, one more comment on that patch:
>
> On 12/02/2014 at 11:06:42 +0100, Jean-Jacques Hiblot wrote :
>> + pinctrl at fffff400 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "atmel,at91rm9200-pinctrl", "simple-bus";
>> + ranges = <0xfffff400 0xfffff400 0xa00>;
>> +
> I believe you got the range wrong, shouldn't it be:
> ranges = <0xfffff400 0xfffff400 0x600>;
>
Yes you're right.
Thanks for the review
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
next prev parent reply other threads:[~2014-02-13 6:11 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 10:06 [PATCH v4 0/8] Device Tree support for the at91sam9261ek Jean-Jacques Hiblot
2014-02-12 10:06 ` Jean-Jacques Hiblot
2014-02-12 10:06 ` [PATCH v4 1/8] at91: dt: Adds support for the bus matrix declaration in the DT Jean-Jacques Hiblot
2014-02-12 10:06 ` Jean-Jacques Hiblot
2014-02-12 10:45 ` Gregory CLEMENT
2014-02-12 10:45 ` Gregory CLEMENT
2014-02-12 10:54 ` Nicolas Ferre
2014-02-12 10:54 ` Nicolas Ferre
2014-02-12 10:06 ` [PATCH v4 2/8] at91: pinctrl: don't request GPIOs used for interrupts but lock them as IRQ Jean-Jacques Hiblot
2014-02-12 10:06 ` Jean-Jacques Hiblot
2014-02-12 17:47 ` Nicolas Ferre
2014-02-12 17:47 ` Nicolas Ferre
2014-02-24 13:25 ` Linus Walleij
2014-02-24 13:25 ` Linus Walleij
2014-02-25 9:35 ` Jean-Jacques Hiblot
2014-02-25 9:35 ` Jean-Jacques Hiblot
2014-02-25 9:47 ` Jean-Jacques Hiblot
2014-02-25 9:47 ` Jean-Jacques Hiblot
2014-02-12 10:06 ` [PATCH v4 3/8] at91: dt: Add at91sam9261 dt SoC support Jean-Jacques Hiblot
2014-02-12 10:06 ` Jean-Jacques Hiblot
2014-02-12 17:28 ` Alexandre Belloni
2014-02-12 17:28 ` Alexandre Belloni
2014-02-12 19:47 ` Jean-Jacques Hiblot
2014-02-12 19:47 ` Jean-Jacques Hiblot
2014-02-13 8:10 ` Nicolas Ferre
2014-02-13 8:10 ` Nicolas Ferre
2014-02-13 8:54 ` Alexandre Belloni
2014-02-13 8:54 ` Alexandre Belloni
2014-02-12 21:04 ` Alexandre Belloni
2014-02-12 21:04 ` Alexandre Belloni
2014-02-13 6:11 ` Jean-Jacques Hiblot [this message]
2014-02-13 6:11 ` Jean-Jacques Hiblot
2014-02-12 10:06 ` [PATCH v4 4/8] at91: dt: defconfig: Added the sam9261 to the list of DT-enabled SOCs Jean-Jacques Hiblot
2014-02-12 10:06 ` Jean-Jacques Hiblot
2014-02-12 10:06 ` [PATCH v4 5/8] at91: dt: sam9261: Device Tree support for the at91sam9261ek Jean-Jacques Hiblot
2014-02-12 10:06 ` Jean-Jacques Hiblot
2014-02-12 10:06 ` [PATCH v4 6/8] at91: updated the at91_dt_defconfig with support for the ADS7846 Jean-Jacques Hiblot
2014-02-12 10:06 ` Jean-Jacques Hiblot
2014-02-12 10:06 ` [PATCH v4 7/8] ARM: at91: prepare common clk transition for sam9261 SoC Jean-Jacques Hiblot
2014-02-12 10:06 ` Jean-Jacques Hiblot
2014-02-12 10:06 ` [PATCH v4 8/8] ARM: at91: move sam9261 SoC to common clk Jean-Jacques Hiblot
2014-02-12 10:06 ` Jean-Jacques Hiblot
2014-02-12 11:14 ` [PATCH v4 0/8] Device Tree support for the at91sam9261ek Gregory CLEMENT
2014-02-12 11:14 ` Gregory CLEMENT
2014-02-12 12:34 ` Thomas Petazzoni
2014-02-12 12:34 ` Thomas Petazzoni
2014-02-12 12:36 ` Jean-Jacques Hiblot
2014-02-12 12:36 ` Jean-Jacques Hiblot
2014-02-12 12:44 ` Thomas Petazzoni
2014-02-12 12:44 ` Thomas Petazzoni
2014-02-12 13:01 ` Jean-Jacques Hiblot
2014-02-12 13:01 ` Jean-Jacques Hiblot
2014-02-12 12:35 ` Jean-Jacques Hiblot
2014-02-12 12:35 ` Jean-Jacques Hiblot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACh+v5O0fJAvT0Ze9RkcVgLQ22Lod+m1ACj0K=GLLA=9r5tVvg@mail.gmail.com' \
--to=jjhiblot@traphandler.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=b.brezillon@overkiz.com \
--cc=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.