Re: [PATCH] bgmac: fix unaligned accesses to network headers

["Rafał Miłecki" <zajec5@gmail.com>]

2013/2/16 Hauke Mehrtens <hauke@hauke-m.de>:
> Without this patch I get many unaligned access warnings per packet,
> this patches fixes them all. This should improve performance ony some
> systems like mips.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  drivers/net/ethernet/broadcom/bgmac.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index d341090..f9b1bc8 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -301,8 +301,9 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
>                         bgmac_err(bgmac, "Found poisoned packet at slot %d, DMA issue!\n",
>                                   ring->start);
>                 } else {
> -                       new_skb = netdev_alloc_skb(bgmac->net_dev, len);
> +                       new_skb = netdev_alloc_skb(bgmac->net_dev, len + 2);
>                         if (new_skb) {
> +                               skb_reserve(new_skb, 2);

I never understood that code in b44, glad you hit that warnings! ;)

The version with netdev_alloc_skb_ip_align looks much better (no more
magic numbers), b44 should be converted too.

Thanks for your patch!

-- 
Rafał