* [PATCH] bgmac: fix unaligned accesses to network headers
@ 2013-02-16 14:32 Hauke Mehrtens
2013-02-16 18:36 ` Stephen Hemminger
2013-02-18 16:14 ` Rafał Miłecki
0 siblings, 2 replies; 4+ messages in thread
From: Hauke Mehrtens @ 2013-02-16 14:32 UTC (permalink / raw)
To: davem; +Cc: zajec5, netdev, Hauke Mehrtens
Without this patch I get many unaligned access warnings per packet,
this patches fixes them all. This should improve performance ony some
systems like mips.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/net/ethernet/broadcom/bgmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index d341090..f9b1bc8 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -301,8 +301,9 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
bgmac_err(bgmac, "Found poisoned packet at slot %d, DMA issue!\n",
ring->start);
} else {
- new_skb = netdev_alloc_skb(bgmac->net_dev, len);
+ new_skb = netdev_alloc_skb(bgmac->net_dev, len + 2);
if (new_skb) {
+ skb_reserve(new_skb, 2);
skb_put(new_skb, len);
skb_copy_from_linear_data_offset(skb, BGMAC_RX_FRAME_OFFSET,
new_skb->data,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] bgmac: fix unaligned accesses to network headers
2013-02-16 14:32 [PATCH] bgmac: fix unaligned accesses to network headers Hauke Mehrtens
@ 2013-02-16 18:36 ` Stephen Hemminger
2013-02-16 19:01 ` Hauke Mehrtens
2013-02-18 16:14 ` Rafał Miłecki
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2013-02-16 18:36 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: davem, zajec5, netdev
On Sat, 16 Feb 2013 15:32:34 +0100
Hauke Mehrtens <hauke@hauke-m.de> wrote:
> Without this patch I get many unaligned access warnings per packet,
> this patches fixes them all. This should improve performance ony some
> systems like mips.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/ethernet/broadcom/bgmac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index d341090..f9b1bc8 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -301,8 +301,9 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
> bgmac_err(bgmac, "Found poisoned packet at slot %d, DMA issue!\n",
> ring->start);
> } else {
> - new_skb = netdev_alloc_skb(bgmac->net_dev, len);
> + new_skb = netdev_alloc_skb(bgmac->net_dev, len + 2);
> if (new_skb) {
> + skb_reserve(new_skb, 2);
> skb_put(new_skb, len);
> skb_copy_from_linear_data_offset(skb, BGMAC_RX_FRAME_OFFSET,
> new_skb->data,
NAK. Use netdev_alloc_skb_ip_align instead.
It is less error prone, and handles case of architectures where unaligned is faster.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bgmac: fix unaligned accesses to network headers
2013-02-16 18:36 ` Stephen Hemminger
@ 2013-02-16 19:01 ` Hauke Mehrtens
0 siblings, 0 replies; 4+ messages in thread
From: Hauke Mehrtens @ 2013-02-16 19:01 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: davem, zajec5, netdev
On 02/16/2013 07:36 PM, Stephen Hemminger wrote:
> On Sat, 16 Feb 2013 15:32:34 +0100
> Hauke Mehrtens <hauke@hauke-m.de> wrote:
>
>> Without this patch I get many unaligned access warnings per packet,
>> this patches fixes them all. This should improve performance ony some
>> systems like mips.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
>> drivers/net/ethernet/broadcom/bgmac.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
>> index d341090..f9b1bc8 100644
>> --- a/drivers/net/ethernet/broadcom/bgmac.c
>> +++ b/drivers/net/ethernet/broadcom/bgmac.c
>> @@ -301,8 +301,9 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
>> bgmac_err(bgmac, "Found poisoned packet at slot %d, DMA issue!\n",
>> ring->start);
>> } else {
>> - new_skb = netdev_alloc_skb(bgmac->net_dev, len);
>> + new_skb = netdev_alloc_skb(bgmac->net_dev, len + 2);
>> if (new_skb) {
>> + skb_reserve(new_skb, 2);
>> skb_put(new_skb, len);
>> skb_copy_from_linear_data_offset(skb, BGMAC_RX_FRAME_OFFSET,
>> new_skb->data,
>
> NAK. Use netdev_alloc_skb_ip_align instead.
> It is less error prone, and handles case of architectures where unaligned is faster.
Thanks for the hint, I will send a better version of this patch.
Hauke
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bgmac: fix unaligned accesses to network headers
2013-02-16 14:32 [PATCH] bgmac: fix unaligned accesses to network headers Hauke Mehrtens
2013-02-16 18:36 ` Stephen Hemminger
@ 2013-02-18 16:14 ` Rafał Miłecki
1 sibling, 0 replies; 4+ messages in thread
From: Rafał Miłecki @ 2013-02-18 16:14 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: davem, netdev
2013/2/16 Hauke Mehrtens <hauke@hauke-m.de>:
> Without this patch I get many unaligned access warnings per packet,
> this patches fixes them all. This should improve performance ony some
> systems like mips.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/ethernet/broadcom/bgmac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index d341090..f9b1bc8 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -301,8 +301,9 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
> bgmac_err(bgmac, "Found poisoned packet at slot %d, DMA issue!\n",
> ring->start);
> } else {
> - new_skb = netdev_alloc_skb(bgmac->net_dev, len);
> + new_skb = netdev_alloc_skb(bgmac->net_dev, len + 2);
> if (new_skb) {
> + skb_reserve(new_skb, 2);
I never understood that code in b44, glad you hit that warnings! ;)
The version with netdev_alloc_skb_ip_align looks much better (no more
magic numbers), b44 should be converted too.
Thanks for your patch!
--
Rafał
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-18 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-16 14:32 [PATCH] bgmac: fix unaligned accesses to network headers Hauke Mehrtens
2013-02-16 18:36 ` Stephen Hemminger
2013-02-16 19:01 ` Hauke Mehrtens
2013-02-18 16:14 ` Rafał Miłecki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.