From: Doug Anderson <dianders@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Kuogee Hsieh <khsieh@codeaurora.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Vara Reddy <varar@codeaurora.org>,
freedreno <freedreno@lists.freedesktop.org>,
Chandan Uddaraju <chandanu@codeaurora.org>
Subject: Re: [RFC] drm/msm/dp: Allow attaching a drm_panel
Date: Fri, 27 Aug 2021 13:52:10 -0700 [thread overview]
Message-ID: <CAD=FV=UGtHXD==Yy8CVCOioYGb=2hqGQOoNWftD1Jj7OiEp51g@mail.gmail.com> (raw)
In-Reply-To: <20210726231351.655302-1-bjorn.andersson@linaro.org>
Hi,
On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> +static int dp_parser_find_panel(struct dp_parser *parser)
> +{
> + struct device_node *np = parser->pdev->dev.of_node;
> + int rc;
> +
> + rc = drm_of_find_panel_or_bridge(np, 2, 0, &parser->drm_panel, NULL);
Why port 2? Shouldn't this just be port 1 always? The yaml says that
port 1 is "Output endpoint of the controller". We should just use port
1 here, right?
-Doug
next prev parent reply other threads:[~2021-08-27 20:59 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 23:13 [RFC] drm/msm/dp: Allow attaching a drm_panel Bjorn Andersson
2021-07-26 23:13 ` Bjorn Andersson
2021-07-29 9:59 ` Dmitry Baryshkov
2021-07-29 9:59 ` Dmitry Baryshkov
2021-08-25 23:28 ` Bjorn Andersson
2021-08-26 1:31 ` Stephen Boyd
2021-08-26 1:31 ` Stephen Boyd
2021-08-26 20:36 ` Doug Anderson
2021-08-26 20:36 ` Doug Anderson
2021-08-26 20:29 ` Doug Anderson
2021-08-26 20:29 ` Doug Anderson
2021-08-27 20:52 ` Doug Anderson [this message]
2021-08-27 20:52 ` Doug Anderson
2021-08-28 14:40 ` Bjorn Andersson
2021-08-30 16:01 ` Doug Anderson
2021-08-30 16:01 ` Doug Anderson
2021-10-01 21:02 ` Bjorn Andersson
2021-10-05 0:36 ` Doug Anderson
2021-10-05 1:11 ` Bjorn Andersson
2021-10-05 1:50 ` Stephen Boyd
2021-10-05 2:11 ` Bjorn Andersson
2021-10-05 15:39 ` Doug Anderson
2021-10-05 17:34 ` Bjorn Andersson
2021-10-05 23:09 ` Doug Anderson
2021-10-06 2:29 ` Bjorn Andersson
2021-10-06 15:12 ` Doug Anderson
2021-10-06 20:26 ` Prashant Malani
2021-10-07 10:17 ` Heikki Krogerus
2021-10-07 16:15 ` Bjorn Andersson
2021-10-08 12:38 ` Heikki Krogerus
2023-05-22 20:51 ` Bjorn Andersson
2023-05-22 20:51 ` Bjorn Andersson
2023-05-22 21:53 ` Bjorn Andersson
2023-05-22 21:53 ` Bjorn Andersson
2023-05-24 9:50 ` Heikki Krogerus
2023-05-24 9:50 ` Heikki Krogerus
2021-12-06 22:31 ` Bjorn Andersson
2021-12-06 22:31 ` Bjorn Andersson
2021-12-07 12:26 ` Heikki Krogerus
2021-12-07 12:26 ` Heikki Krogerus
2021-12-07 16:56 ` Hans de Goede
2021-12-07 16:56 ` Hans de Goede
2021-12-07 17:29 ` Bjorn Andersson
2021-12-07 17:29 ` Bjorn Andersson
2021-12-07 17:54 ` Imre Deak
2021-12-07 17:54 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UGtHXD==Yy8CVCOioYGb=2hqGQOoNWftD1Jj7OiEp51g@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=chandanu@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=varar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.