From: Doug Anderson <dianders@chromium.org> To: Thierry Reding <thierry.reding@gmail.com> Cc: Dmitry Osipenko <digetx@gmail.com>, Thomas Graichen <thomas.graichen@gmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Jon Hunter <jonathanh@nvidia.com>, dri-devel <dri-devel@lists.freedesktop.org>, "open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@vger.kernel.org> Subject: Re: [PATCH 1/2] drm/tegra: dpaux: Populate AUX bus Date: Wed, 5 Jan 2022 17:02:53 -0800 [thread overview] Message-ID: <CAD=FV=VeN=rODkhO3gYNZ5rFW1iabirHopR0Ra5UFAKLNn1zYA@mail.gmail.com> (raw) In-Reply-To: <20211220104855.428290-2-thierry.reding@gmail.com> Hi, On Mon, Dec 20, 2021 at 2:49 AM Thierry Reding <thierry.reding@gmail.com> wrote: > > From: Thierry Reding <treding@nvidia.com> > > The DPAUX hardware block exposes an DP AUX interface that provides > access to an AUX bus and the devices on that bus. Use the DP AUX bus > infrastructure that was recently introduced to probe devices on this > bus from DT. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/gpu/drm/tegra/Kconfig | 1 + > drivers/gpu/drm/tegra/dpaux.c | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig > index 8cf5aeb9db6c..201f5175ecfe 100644 > --- a/drivers/gpu/drm/tegra/Kconfig > +++ b/drivers/gpu/drm/tegra/Kconfig > @@ -5,6 +5,7 @@ config DRM_TEGRA > depends on COMMON_CLK > depends on DRM > depends on OF > + select DRM_DP_AUX_BUS > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL > diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c > index 1f96e416fa08..9da1edcdc835 100644 > --- a/drivers/gpu/drm/tegra/dpaux.c > +++ b/drivers/gpu/drm/tegra/dpaux.c > @@ -18,6 +18,7 @@ > #include <linux/reset.h> > #include <linux/workqueue.h> > > +#include <drm/drm_dp_aux_bus.h> > #include <drm/drm_dp_helper.h> > #include <drm/drm_panel.h> > > @@ -570,6 +571,12 @@ static int tegra_dpaux_probe(struct platform_device *pdev) > list_add_tail(&dpaux->list, &dpaux_list); > mutex_unlock(&dpaux_lock); > > + err = devm_of_dp_aux_populate_ep_devices(&dpaux->aux); > + if (err < 0) { > + dev_err(dpaux->dev, "failed to populate AUX bus: %d\n", err); > + return err; nit: if (err < 0) return dev_err_probe(dpaux->dev, err, "failed to populate AUX bus\n"); That's more concise and gives the pretty formatting for the error code (not that devm_of_dp_aux_populate_ep_devices() currently returns anything other than 0). > + } I think you need to use of_dp_aux_populate_ep_devices() and then depopulate in your remove, right? Otherwise the ordering won't be right. Either that or fully transition your probe to devm (and get rid of your remove) by adding some devm_add_action_or_reset() helpers... Hrm, I guess looking closer it's also a little concerning that if devm_of_dp_aux_populate_ep_devices() returns an error then you'll totally skip all the things that tegra_dpaux_remove() is supposed to handle. I guess that's a pre-existing bug (earlier error cases in the probe don't, for instance, undo the pm_runtime state) but this makes it worse. -Doug
WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org> To: Thierry Reding <thierry.reding@gmail.com> Cc: Thomas Graichen <thomas.graichen@gmail.com>, dri-devel <dri-devel@lists.freedesktop.org>, Jon Hunter <jonathanh@nvidia.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, "open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@vger.kernel.org>, Dmitry Osipenko <digetx@gmail.com> Subject: Re: [PATCH 1/2] drm/tegra: dpaux: Populate AUX bus Date: Wed, 5 Jan 2022 17:02:53 -0800 [thread overview] Message-ID: <CAD=FV=VeN=rODkhO3gYNZ5rFW1iabirHopR0Ra5UFAKLNn1zYA@mail.gmail.com> (raw) In-Reply-To: <20211220104855.428290-2-thierry.reding@gmail.com> Hi, On Mon, Dec 20, 2021 at 2:49 AM Thierry Reding <thierry.reding@gmail.com> wrote: > > From: Thierry Reding <treding@nvidia.com> > > The DPAUX hardware block exposes an DP AUX interface that provides > access to an AUX bus and the devices on that bus. Use the DP AUX bus > infrastructure that was recently introduced to probe devices on this > bus from DT. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/gpu/drm/tegra/Kconfig | 1 + > drivers/gpu/drm/tegra/dpaux.c | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig > index 8cf5aeb9db6c..201f5175ecfe 100644 > --- a/drivers/gpu/drm/tegra/Kconfig > +++ b/drivers/gpu/drm/tegra/Kconfig > @@ -5,6 +5,7 @@ config DRM_TEGRA > depends on COMMON_CLK > depends on DRM > depends on OF > + select DRM_DP_AUX_BUS > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL > diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c > index 1f96e416fa08..9da1edcdc835 100644 > --- a/drivers/gpu/drm/tegra/dpaux.c > +++ b/drivers/gpu/drm/tegra/dpaux.c > @@ -18,6 +18,7 @@ > #include <linux/reset.h> > #include <linux/workqueue.h> > > +#include <drm/drm_dp_aux_bus.h> > #include <drm/drm_dp_helper.h> > #include <drm/drm_panel.h> > > @@ -570,6 +571,12 @@ static int tegra_dpaux_probe(struct platform_device *pdev) > list_add_tail(&dpaux->list, &dpaux_list); > mutex_unlock(&dpaux_lock); > > + err = devm_of_dp_aux_populate_ep_devices(&dpaux->aux); > + if (err < 0) { > + dev_err(dpaux->dev, "failed to populate AUX bus: %d\n", err); > + return err; nit: if (err < 0) return dev_err_probe(dpaux->dev, err, "failed to populate AUX bus\n"); That's more concise and gives the pretty formatting for the error code (not that devm_of_dp_aux_populate_ep_devices() currently returns anything other than 0). > + } I think you need to use of_dp_aux_populate_ep_devices() and then depopulate in your remove, right? Otherwise the ordering won't be right. Either that or fully transition your probe to devm (and get rid of your remove) by adding some devm_add_action_or_reset() helpers... Hrm, I guess looking closer it's also a little concerning that if devm_of_dp_aux_populate_ep_devices() returns an error then you'll totally skip all the things that tegra_dpaux_remove() is supposed to handle. I guess that's a pre-existing bug (earlier error cases in the probe don't, for instance, undo the pm_runtime state) but this makes it worse. -Doug
next prev parent reply other threads:[~2022-01-06 1:03 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-20 10:48 [PATCH 0/2] drm/tegra: Fix panel support on Venice 2 and Nyan Thierry Reding 2021-12-20 10:48 ` Thierry Reding 2021-12-20 10:48 ` [PATCH 1/2] drm/tegra: dpaux: Populate AUX bus Thierry Reding 2021-12-20 10:48 ` Thierry Reding 2021-12-22 19:48 ` Dmitry Osipenko 2021-12-22 19:48 ` Dmitry Osipenko 2022-01-06 1:02 ` Doug Anderson [this message] 2022-01-06 1:02 ` Doug Anderson 2021-12-20 10:48 ` [PATCH 2/2] ARM: tegra: Move panels to " Thierry Reding 2021-12-20 10:48 ` Thierry Reding 2021-12-22 19:30 ` Dmitry Osipenko 2021-12-22 19:30 ` Dmitry Osipenko 2022-03-06 17:59 ` Dmitry Osipenko 2022-03-06 17:59 ` Dmitry Osipenko 2022-03-07 7:45 ` Thierry Reding 2022-03-07 7:45 ` Thierry Reding 2022-01-06 1:02 ` Doug Anderson 2022-01-06 1:02 ` Doug Anderson 2021-12-20 14:45 ` [PATCH 0/2] drm/tegra: Fix panel support on Venice 2 and Nyan Dmitry Osipenko 2021-12-20 14:45 ` Dmitry Osipenko 2021-12-20 15:27 ` Thierry Reding 2021-12-20 15:27 ` Thierry Reding 2021-12-20 16:12 ` Dmitry Osipenko 2021-12-20 16:12 ` Dmitry Osipenko 2021-12-20 16:55 ` Dmitry Osipenko 2021-12-20 16:55 ` Dmitry Osipenko 2021-12-21 5:35 ` Dmitry Osipenko 2021-12-21 5:35 ` Dmitry Osipenko 2021-12-21 10:58 ` Thierry Reding 2021-12-21 10:58 ` Thierry Reding 2021-12-21 15:47 ` Dmitry Osipenko 2021-12-21 15:47 ` Dmitry Osipenko 2021-12-21 16:17 ` Thierry Reding 2021-12-21 16:17 ` Thierry Reding 2021-12-21 16:45 ` Dmitry Osipenko 2021-12-21 16:45 ` Dmitry Osipenko 2021-12-21 18:01 ` Thierry Reding 2021-12-21 18:01 ` Thierry Reding 2021-12-22 3:01 ` Dmitry Osipenko 2021-12-22 3:01 ` Dmitry Osipenko 2021-12-22 11:53 ` Thierry Reding 2021-12-22 11:53 ` Thierry Reding 2021-12-22 19:26 ` Dmitry Osipenko 2021-12-22 19:26 ` Dmitry Osipenko 2022-01-06 1:11 ` Doug Anderson 2022-01-06 1:11 ` Doug Anderson 2022-01-14 11:35 ` Dmitry Osipenko 2022-01-14 11:35 ` Dmitry Osipenko 2022-02-22 10:39 ` Dmitry Osipenko 2022-02-22 10:39 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAD=FV=VeN=rODkhO3gYNZ5rFW1iabirHopR0Ra5UFAKLNn1zYA@mail.gmail.com' \ --to=dianders@chromium.org \ --cc=digetx@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jonathanh@nvidia.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-tegra@vger.kernel.org \ --cc=thierry.reding@gmail.com \ --cc=thomas.graichen@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.