All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Thierry Reding <treding@nvidia.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Yakir Yang <ykk@rock-chips.com>, Inki Dae <inki.dae@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Mark Yao <mark.yao@rock-chips.com>,
	Russell King <linux@arm.linux.org.uk>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Sean Paul <seanpaul@chromium.org>, Kukjin Kim <kgene@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Pawel Moll <pawel.moll@arm.com>, Ajay kumar <ajaynumb@gmail.com>,
	Rob Herring <robherring2@gmail.com>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Andy Yan <andy.yan@rock-chips.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory
Date: Thu, 31 Mar 2016 09:02:47 -0700	[thread overview]
Message-ID: <CAD=FV=VqWqtraAbMTN-Qn7gEOgLmrsXRAeRtxtB0qRj84JREeA@mail.gmail.com> (raw)
In-Reply-To: <20160331095600.GD26032@ulmo.nvidia.com>

Hi,

On Thu, Mar 31, 2016 at 2:56 AM, Thierry Reding <treding@nvidia.com> wrote:
> Ugh... most of these functions shouldn't be there in the first place. We
> have helpers in the core that already do this. Most of the functionality
> is duplicated in this driver.
>
> I realize that this is a problem that existed in the Exynos DP driver,
> but somebody really ought to rewrite those parts to make use of the DRM
> DP helpers.

As I understand it from discussions in
<http://article.gmane.org/gmane.linux.drivers.devicetree/162059> and
<http://article.gmane.org/gmane.linux.kernel.samsung-soc/53048>, we
shouldn't block merging the series but someone should pick up this
work after the merge.

So probably Yakir should fixup the problem pointed out by Guenter and
send a new pull.

-Doug

WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
	Yakir Yang <ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Inki Dae <inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Joonyoung Shim
	<jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Seung-Woo Kim
	<sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Kyungmin Park
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Jingoo Han <jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Krzysztof Kozlowski
	<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	Mark Yao <mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Emil Velikov
	<emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Gustavo Padovan
	<gustavo.padovan-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
	Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Ajay kumar <ajaynumb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>Ro
Subject: Re: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory
Date: Thu, 31 Mar 2016 09:02:47 -0700	[thread overview]
Message-ID: <CAD=FV=VqWqtraAbMTN-Qn7gEOgLmrsXRAeRtxtB0qRj84JREeA@mail.gmail.com> (raw)
In-Reply-To: <20160331095600.GD26032-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>

Hi,

On Thu, Mar 31, 2016 at 2:56 AM, Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
> Ugh... most of these functions shouldn't be there in the first place. We
> have helpers in the core that already do this. Most of the functionality
> is duplicated in this driver.
>
> I realize that this is a problem that existed in the Exynos DP driver,
> but somebody really ought to rewrite those parts to make use of the DRM
> DP helpers.

As I understand it from discussions in
<http://article.gmane.org/gmane.linux.drivers.devicetree/162059> and
<http://article.gmane.org/gmane.linux.kernel.samsung-soc/53048>, we
shouldn't block merging the series but someone should pick up this
work after the merge.

So probably Yakir should fixup the problem pointed out by Guenter and
send a new pull.

-Doug
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory
Date: Thu, 31 Mar 2016 09:02:47 -0700	[thread overview]
Message-ID: <CAD=FV=VqWqtraAbMTN-Qn7gEOgLmrsXRAeRtxtB0qRj84JREeA@mail.gmail.com> (raw)
In-Reply-To: <20160331095600.GD26032@ulmo.nvidia.com>

Hi,

On Thu, Mar 31, 2016 at 2:56 AM, Thierry Reding <treding@nvidia.com> wrote:
> Ugh... most of these functions shouldn't be there in the first place. We
> have helpers in the core that already do this. Most of the functionality
> is duplicated in this driver.
>
> I realize that this is a problem that existed in the Exynos DP driver,
> but somebody really ought to rewrite those parts to make use of the DRM
> DP helpers.

As I understand it from discussions in
<http://article.gmane.org/gmane.linux.drivers.devicetree/162059> and
<http://article.gmane.org/gmane.linux.kernel.samsung-soc/53048>, we
shouldn't block merging the series but someone should pick up this
work after the merge.

So probably Yakir should fixup the problem pointed out by Guenter and
send a new pull.

-Doug

  reply	other threads:[~2016-03-31 16:02 UTC|newest]

Thread overview: 157+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 11:08 [PATCH v14 0/17] Add Analogix Core Display Port Driver Yakir Yang
2016-02-15 11:08 ` Yakir Yang
2016-02-15 11:09 ` [PATCH v14 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Yakir Yang
2016-02-15 11:09   ` Yakir Yang
2016-03-17 21:47   ` [PATCH v14.1 " Heiko Stübner
2016-03-17 21:47     ` Heiko Stübner
2016-03-18  7:01     ` Caesar Wang
2016-03-18  7:01       ` Caesar Wang
2016-06-07 17:06     ` Javier Martinez Canillas
2016-06-07 17:06       ` Javier Martinez Canillas
2016-06-07 17:06       ` Javier Martinez Canillas
2016-06-08  1:28       ` Yakir Yang
2016-06-08  1:28         ` Yakir Yang
2016-06-08  1:28         ` Yakir Yang
2016-06-08  7:44         ` Marc Zyngier
2016-06-08  7:44           ` Marc Zyngier
2016-06-08  7:44           ` Marc Zyngier
2016-06-08 10:53           ` Yakir Yang
2016-06-08 10:53             ` Yakir Yang
2016-06-08 10:53             ` Yakir Yang
2016-06-08 14:19             ` Javier Martinez Canillas
2016-06-08 14:19               ` Javier Martinez Canillas
2016-06-08 14:19               ` Javier Martinez Canillas
2016-03-30 20:32   ` [v14, " Guenter Roeck
2016-03-30 20:32     ` Guenter Roeck
2016-03-30 20:32     ` Guenter Roeck
2016-03-31  9:56     ` Thierry Reding
2016-03-31  9:56       ` Thierry Reding
2016-03-31  9:56       ` Thierry Reding
2016-03-31 16:02       ` Doug Anderson [this message]
2016-03-31 16:02         ` Doug Anderson
2016-03-31 16:02         ` Doug Anderson
2016-04-05  2:15         ` Yakir Yang
2016-04-05  2:15           ` Yakir Yang
2016-04-05  2:15           ` Yakir Yang
2016-03-31 15:57     ` Doug Anderson
2016-03-31 15:57       ` Doug Anderson
2016-03-31 15:57       ` Doug Anderson
2016-04-05  1:49     ` Yakir Yang
2016-04-05  1:49       ` Yakir Yang
2016-04-05  1:49       ` Yakir Yang
2016-02-15 11:09 ` [PATCH v14 02/17] drm/exynos: dp: rename implementation specific driver part Yakir Yang
2016-02-15 11:09   ` Yakir Yang
2016-02-15 11:09 ` [PATCH v14 03/17] drm: bridge: analogix/dp: rename register constants Yakir Yang
2016-02-15 11:09   ` Yakir Yang
2016-02-15 11:09 ` [PATCH v14 04/17] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang
2016-02-15 11:09   ` Yakir Yang
2016-02-15 11:09   ` Yakir Yang
2016-03-17 21:48   ` Heiko Stübner
2016-03-17 21:48     ` Heiko Stübner
2016-03-17 21:48     ` Heiko Stübner
2016-03-17 21:50   ` [PATCH v14.1 " Heiko Stübner
2016-03-17 21:50     ` Heiko Stübner
2016-03-17 21:50     ` Heiko Stübner
2016-02-15 11:10 ` [PATCH v14 05/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang
2016-02-15 11:10   ` Yakir Yang
2016-02-15 11:10 ` [PATCH v14 06/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang
2016-02-15 11:10   ` Yakir Yang
2016-02-15 11:10 ` [PATCH v14 07/17] dt-bindings: add document for analogix display port driver Yakir Yang
2016-02-15 11:10   ` Yakir Yang
2016-02-15 11:10 ` [PATCH v14 08/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang
2016-02-15 11:10   ` Yakir Yang
2016-02-15 11:10 ` [PATCH v14 09/17] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang
2016-02-15 11:10   ` Yakir Yang
2016-03-17 21:51   ` [PATCH v14.1 " Heiko Stübner
2016-03-17 21:51     ` Heiko Stübner
2016-03-17 21:51     ` Heiko Stübner
2016-03-18  6:45     ` Caesar Wang
2016-03-18  6:45       ` Caesar Wang
2016-03-18  6:45       ` Caesar Wang
2016-03-23  1:08   ` [PATCH v14 " Mark yao
2016-03-23  1:08     ` Mark yao
2016-03-23  1:08     ` Mark yao
2016-02-15 11:10 ` [PATCH v14 10/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang
2016-02-15 11:10   ` Yakir Yang
2016-02-15 11:10 ` [PATCH v14 11/17] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang
2016-02-15 11:10   ` Yakir Yang
2016-03-18  6:56   ` Caesar Wang
2016-03-18  6:56     ` Caesar Wang
2016-03-18  6:56     ` Caesar Wang
2016-02-15 11:11 ` [PATCH v14 12/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang
2016-02-15 11:11   ` Yakir Yang
2016-02-15 11:11 ` [PATCH v14 13/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang
2016-02-15 11:11   ` Yakir Yang
2016-02-15 11:11 ` [PATCH v14 14/17] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang
2016-02-15 11:11   ` Yakir Yang
2016-02-15 11:11 ` [PATCH v14 15/17] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang
2016-02-15 11:11   ` Yakir Yang
2016-02-15 11:11 ` [PATCH v14 16/17] drm: bridge: analogix/dp: add panel prepare/unprepare in suspend/resume time Yakir Yang
2016-02-15 11:11   ` Yakir Yang
2016-02-15 11:11 ` [PATCH v14 17/17] drm: bridge: analogix/dp: Fix the possible dead lock in bridge disable time Yakir Yang
2016-02-15 11:11   ` Yakir Yang
2016-03-18  6:41 ` [PATCH v14 0/17] Add Analogix Core Display Port Driver Caesar Wang
2016-03-18  6:41   ` Caesar Wang
2016-03-18  6:41   ` Caesar Wang
2016-03-18 22:53   ` Doug Anderson
2016-03-18 22:53     ` Doug Anderson
2016-03-18 22:53     ` Doug Anderson
2016-03-22 19:19     ` Javier Martinez Canillas
2016-03-22 19:19       ` Javier Martinez Canillas
2016-03-22 19:19       ` Javier Martinez Canillas
2016-03-22 22:12       ` Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver] Heiko Stübner
2016-03-22 22:12         ` Heiko Stübner
2016-03-22 22:12         ` Heiko Stübner
2016-03-22 22:44         ` Inki Dae
2016-03-22 22:44           ` Inki Dae
2016-03-22 22:44           ` Inki Dae
2016-03-22 22:52           ` Heiko Stübner
2016-03-22 22:52             ` Heiko Stübner
2016-03-22 22:52             ` Heiko Stübner
2016-03-22 23:09             ` Inki Dae
2016-03-22 23:09               ` Inki Dae
2016-03-22 23:09               ` Inki Dae
2016-03-22 23:39               ` Russell King - ARM Linux
2016-03-22 23:39                 ` Russell King - ARM Linux
2016-03-22 23:39                 ` Russell King - ARM Linux
2016-03-22 23:54                 ` Inki Dae
2016-03-22 23:54                   ` Inki Dae
2016-03-22 23:54                   ` Inki Dae
2016-03-23  0:08                   ` Russell King - ARM Linux
2016-03-23  0:08                     ` Russell King - ARM Linux
2016-03-23  0:08                     ` Russell King - ARM Linux
2016-03-23  0:41                     ` Dave Airlie
2016-03-23  0:41                       ` Dave Airlie
2016-03-23  0:41                       ` Dave Airlie
2016-03-23  1:08                       ` Mark yao
2016-03-23  1:08                         ` Mark yao
2016-03-23  1:08                         ` Mark yao
2016-03-23 15:49                       ` Thierry Reding
2016-03-23 15:49                         ` Thierry Reding
2016-03-23 15:49                         ` Thierry Reding
2016-03-24 11:10                       ` Yakir Yang
2017-11-13  1:11                         ` Yakir Yang
2016-03-24 11:10                         ` Yakir Yang
2016-03-24 11:10                       ` Yakir Yang
2016-03-24 11:10                       ` Yakir Yang
     [not found]                       ` <CAPM=9tz9_rbGJFuv-+YN=Sicfng++tHTDLrOX5Ohtwft+VnwtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-24 11:10                         ` Yakir Yang
2016-03-24 11:11                       ` Yakir Yang
2016-03-24 15:00                       ` Yakir Yang
2016-03-24 13:01 ` [PATCH v14 0/17] Add Analogix Core Display Port Driver Heiko Stübner
2016-03-24 13:01   ` Heiko Stübner
2016-03-24 13:01   ` Heiko Stübner
2016-03-31 10:15 ` Daniel Vetter
2016-03-31 10:15   ` Daniel Vetter
2016-03-31 10:15   ` Daniel Vetter
2016-03-31 10:22   ` Thierry Reding
2016-03-31 10:22     ` Thierry Reding
2016-03-31 10:22     ` Thierry Reding
2016-04-05  2:06   ` Yakir Yang
2016-04-05  2:06     ` Yakir Yang
2016-04-05  2:06     ` Yakir Yang
2016-07-29  8:38     ` Tomeu Vizoso
2016-07-29  8:38       ` Tomeu Vizoso
2016-07-29  8:38       ` Tomeu Vizoso
2016-08-01  1:49       ` Yakir Yang
2016-08-01  1:49         ` Yakir Yang
2016-08-01  1:49         ` Yakir Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=VqWqtraAbMTN-Qn7gEOgLmrsXRAeRtxtB0qRj84JREeA@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=a.hajda@samsung.com \
    --cc=ajaynumb@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=inki.dae@samsung.com \
    --cc=javier@osg.samsung.com \
    --cc=jingoohan1@gmail.com \
    --cc=jy0922.shim@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kishon@ti.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@roeck-us.net \
    --cc=mark.yao@rock-chips.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=sw0312.kim@samsung.com \
    --cc=treding@nvidia.com \
    --cc=ykk@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.