All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	kgodara@codeaurora.org, Matthias Kaehlcke <mka@chromium.org>,
	Sibi Sankar <sibis@codeaurora.org>,
	Prasad Malisetty <pmaliset@codeaurora.org>,
	quic_rjendra@quicinc.com, Andy Gross <agross@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] arm64: dts: qcom: sc7280: Add herobrine-r1
Date: Mon, 31 Jan 2022 08:44:35 -0800	[thread overview]
Message-ID: <CAD=FV=W2zsd+jTFyPO_UxS=UxPvB1=iaMbDQY8X2p8tJgL685g@mail.gmail.com> (raw)
In-Reply-To: <CAE-0n50sX9-0MxcpF+3Rwqm75jSw5=aNwdsitLwE2sEA69jLJw@mail.gmail.com>

Hi,

On Thu, Jan 27, 2022 at 1:16 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> ----8<-----
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c
> b/drivers/cpufreq/cpufreq-dt-platdev.c
> index ca1d103ec449..32bfe453f8b4 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -179,25 +179,29 @@ static bool __init cpu0_node_has_opp_v2_prop(void)
>  static int __init cpufreq_dt_platdev_init(void)
>  {
>         struct device_node *np = of_find_node_by_path("/");
> +       struct device_node *soc_np = of_find_node_by_path("/soc");

Seems that some device trees have "/soc" and others "/soc@0". For at
least a little context, see commit a1875bf98290 ("arm64: dts: qcom:
sdm845: Add unit name to soc node"). Since (presumably) this would
only be for newer SoCs then I guess you should search for "/soc@0"?
...and then if we ever have a SoC that's not @0 then we would have to
iterate through all SoCs

-Doug

  parent reply	other threads:[~2022-01-31 16:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 22:44 [PATCH v2 0/5] arm64: dts: qcom: sc7280: Introduce herobrine-rev1 Douglas Anderson
2022-01-25 22:44 ` [PATCH v2 1/5] arm64: dts: qcom: sc7280: Fix gmu unit address Douglas Anderson
2022-02-01  7:27   ` Akhil P Oommen
2022-01-25 22:44 ` [PATCH v2 2/5] arm64: dts: qcom: sc7280: Move herobrine-r0 to its own dts Douglas Anderson
2022-01-25 22:44 ` [PATCH v2 3/5] arm64: dts: qcom: sc7280: Factor out Chrome common fragment Douglas Anderson
2022-02-01  5:19   ` (subset) " Bjorn Andersson
2022-01-25 22:44 ` [PATCH v2 4/5] arm64: dts: qcom: sc7280: Factor gpio.h include to sc7280.dtsi Douglas Anderson
2022-01-25 22:54   ` Stephen Boyd
2022-01-25 22:44 ` [PATCH v2 5/5] arm64: dts: qcom: sc7280: Add herobrine-r1 Douglas Anderson
2022-01-25 22:58   ` Stephen Boyd
2022-01-25 23:46     ` Doug Anderson
2022-01-26  3:01       ` Bjorn Andersson
2022-01-27 21:16         ` Stephen Boyd
2022-01-31 16:41           ` Bjorn Andersson
2022-01-31 16:50             ` Doug Anderson
2022-02-01  1:01               ` Doug Anderson
2022-02-02 21:32                 ` Doug Anderson
2022-02-03 21:55             ` Stephen Boyd
2022-01-31 16:44           ` Doug Anderson [this message]
2022-02-03 21:50             ` Stephen Boyd
2022-01-31 18:24 ` (subset) [PATCH v2 0/5] arm64: dts: qcom: sc7280: Introduce herobrine-rev1 Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=W2zsd+jTFyPO_UxS=UxPvB1=iaMbDQY8X2p8tJgL685g@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgodara@codeaurora.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=pmaliset@codeaurora.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sibis@codeaurora.org \
    --cc=swboyd@chromium.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.