Re: [PATCH] ARM: dts: nuvoton: Fix flash layout

From: Anton Kachalov <gmouse@google.com>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: Benjamin Fair <benjaminfair@google.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>, Rob Herring <robh+dt@kernel.org>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: nuvoton: Fix flash layout
Date: Mon, 22 Feb 2021 10:26:53 +0100	[thread overview]
Message-ID: <CADVsX89F6Tc0Zk6uB3CKRK0F8j_E+sVGHVb9FMAkHDQqJ+KBAQ@mail.gmail.com> (raw)
In-Reply-To: <CAP6Zq1jf4-XAhLQxqNx3LM7-YzDr8zaVPb-jznn8o=frxTotdQ@mail.gmail.com>

Hi, Tom.

Yes, I'm using it for testing on real hardware.

BTW. Recent u-boot doesn't work with SD cards. The card doesn't
detect. The last working version was this one:

https://github.com/Nuvoton-Israel/nuvoton-info/tree/master/npcm7xx-poleg/evaluation-board/sw_deliverables/npcm7xx_v2.3

However, u-boot from igps repo:

https://github.com/Nuvoton-Israel/igps/tree/master/ImageGeneration/versions

Has issues too. It doesn't allow me to read more than 4k bytes once at
a time. Thus, to flash the stuff I have manually read chunks from the
SD-card: fat load doesn't work at all and I write that data in raw
partition.

On Sun, 21 Feb 2021 at 17:40, Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> Hi Benjamin and Anton,
>
> Sorry for the late reply,
>
> The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
>
>
>
> Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
>
>
> On Thu, 18 Feb 2021 at 19:11, Benjamin Fair <benjaminfair@google.com> wrote:
>>
>> On Thu, 18 Feb 2021 at 04:42, <gmouse@google.com> wrote:
>> >
>> > From: "Anton D. Kachalov" <gmouse@google.com>
>> >
>> > This change satisfy OpenBMC requirements for flash layout.
>> >
>> > Signed-off-by: Anton D. Kachalov <gmouse@google.com>
>> > ---
>> >  arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28 +++++++----------------
>> >  1 file changed, 8 insertions(+), 20 deletions(-)
>> >
>> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> > index bd1eb6ee380f..741c1fee8552 100644
>> > --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
>> > @@ -182,8 +182,8 @@ bbuboot2@80000 {
>> >                                 reg = <0x0080000 0x80000>;
>> >                                 read-only;
>> >                                 };
>> > -                       envparam@100000 {
>> > -                               label = "env-param";
>> > +                       ubootenv@100000 {
>> > +                               label = "u-boot-env";
>> >                                 reg = <0x0100000 0x40000>;
>> >                                 read-only;
>> >                                 };
>> > @@ -195,25 +195,13 @@ kernel@200000 {
>> >                                 label = "kernel";
>> >                                 reg = <0x0200000 0x400000>;
>> >                                 };
>> > -                       rootfs@600000 {
>> > -                               label = "rootfs";
>> > -                               reg = <0x0600000 0x700000>;
>> > +                       rofs@780000 {
>> > +                               label = "rofs";
>> > +                               reg = <0x0780000 0x1680000>;
>> >                                 };
>> > -                       spare1@D00000 {
>> > -                               label = "spare1";
>> > -                               reg = <0x0D00000 0x200000>;
>> > -                               };
>> > -                       spare2@0F00000 {
>> > -                               label = "spare2";
>> > -                               reg = <0x0F00000 0x200000>;
>> > -                               };
>> > -                       spare3@1100000 {
>> > -                               label = "spare3";
>> > -                               reg = <0x1100000 0x200000>;
>> > -                               };
>> > -                       spare4@1300000 {
>> > -                               label = "spare4";
>> > -                               reg = <0x1300000 0x0>;
>> > +                       rwfs@1e00000 {
>> > +                               label = "rwfs";
>> > +                               reg = <0x1e00000 0x200000>;
>> >                         };
>>
>> I recommend just including the openbmc-flash-layout.dtsi file here
>> instead since that contains the common flash layout for most OpenBMC
>> systems.
>>
> Good solution,
> Do you mean nuvoton-openbmc-flash-layout?
>>
>> >                 };
>> >         };
>> > --
>> > 2.30.0.478.g8a0d178c01-goog
>> >
>
>
> Thanks,
>
> Tomer