* Re: [PATCHv1 1/1] docker: fix dependency issues with deb packaging
[not found] <1491204611-40395-1-git-send-email-adrian.calianu@enea.com>
@ 2017-04-03 11:15 ` Bruce Ashfield
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Ashfield @ 2017-04-03 11:15 UTC (permalink / raw)
To: Adrian Calianu; +Cc: meta-virtualization
[-- Attachment #1: Type: text/plain, Size: 2674 bytes --]
IMHO the deb backend (or a class to translate things) needs to happen here.
With this change, I can no longer do a preferred provider and have the
exclusion
of the opencontainer and docker variants.
So unless the above functionality can be provided, I don't see how I can
merge
this change.
Also, how is the deb backend dealing with virtual/kernel, virtual/libc, etc
?
Bruce
On Mon, Apr 3, 2017 at 3:30 AM, Adrian Calianu <adrian.calianu@enea.com>
wrote:
> dpkg-deb does not accept RDEPENDS += "virtual/xxxx"
>
> 'Provides' field, invalid package name 'virtual/containerd': character
> '/' not allowed (only letters, digits and characters '-+._')
>
> Signed-off-by: Adrian Calianu <adrian.calianu@enea.com>
> ---
> recipes-containers/containerd/containerd-docker_git.bb | 1 -
> recipes-containers/docker/docker_git.bb | 2 +-
> recipeSs-containers/runc/runc-docker_git.bb | 1 -
> 3 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/recipes-containers/containerd/containerd-docker_git.bb
> b/recipes-containers/containerd/containerd-docker_git.bb
> index f6dcaec..604ada3 100644
> --- a/recipes-containers/containerd/containerd-docker_git.bb
> +++ b/recipes-containers/containerd/containerd-docker_git.bb
> @@ -7,4 +7,3 @@ SRC_URI = "\
> CONTAINERD_VERSION = "0.2.3"
>
> PROVIDES += "virtual/containerd"
> -RPROVIDES_${PN} = "virtual/containerd"
> diff --git a/recipes-containers/docker/docker_git.bb
> b/recipes-containers/docker/docker_git.bb
> index 6b73cf3..16d1dad 100644
> --- a/recipes-containers/docker/docker_git.bb
> +++ b/recipes-containers/docker/docker_git.bb
> @@ -64,7 +64,7 @@ DEPENDS_append_class-target = " lvm2"
> RDEPENDS_${PN} = "curl aufs-util git util-linux iptables \
> ${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)}
> \
> "
> -RDEPENDS_${PN} += "virtual/containerd virtual/runc"
> +RDEPENDS_${PN} += "containerd-docker runc-docker"
>
> RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
> RSUGGESTS_${PN} = "lxc rt-tests"
> diff --git a/recipes-containers/runc/runc-docker_git.bb
> b/recipes-containers/runc/runc-docker_git.bb
> index 96d48ca..bf32953 100644
> --- a/recipes-containers/runc/runc-docker_git.bb
> +++ b/recipes-containers/runc/runc-docker_git.bb
> @@ -8,4 +8,3 @@ SRC_URI = "git://github.com/docker/runc.git;nobranch=1 \
>
> RUNC_VERSION = "1.0.0-rc2"
> PROVIDES += "virtual/runc"
> -RPROVIDES_${PN} = "virtual/runc"
> --
> 1.9.1
>
>
--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
[-- Attachment #2: Type: text/html, Size: 4934 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCHv1 1/1] docker: fix dependency issues with deb packaging
@ 2017-04-03 7:38 Adrian Calianu
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Calianu @ 2017-04-03 7:38 UTC (permalink / raw)
To: meta-virtualization
dpkg-deb does not accept RDEPENDS += "virtual/xxxx"
'Provides' field, invalid package name 'virtual/containerd': character
'/' not allowed (only letters, digits and characters '-+._')
Signed-off-by: Adrian Calianu <adrian.calianu@enea.com>
---
recipes-containers/containerd/containerd-docker_git.bb | 1 -
recipes-containers/docker/docker_git.bb | 2 +-
recipes-containers/runc/runc-docker_git.bb | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/recipes-containers/containerd/containerd-docker_git.bb b/recipes-containers/containerd/containerd-docker_git.bb
index f6dcaec..604ada3 100644
--- a/recipes-containers/containerd/containerd-docker_git.bb
+++ b/recipes-containers/containerd/containerd-docker_git.bb
@@ -7,4 +7,3 @@ SRC_URI = "\
CONTAINERD_VERSION = "0.2.3"
PROVIDES += "virtual/containerd"
-RPROVIDES_${PN} = "virtual/containerd"
diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
index 6b73cf3..16d1dad 100644
--- a/recipes-containers/docker/docker_git.bb
+++ b/recipes-containers/docker/docker_git.bb
@@ -64,7 +64,7 @@ DEPENDS_append_class-target = " lvm2"
RDEPENDS_${PN} = "curl aufs-util git util-linux iptables \
${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
"
-RDEPENDS_${PN} += "virtual/containerd virtual/runc"
+RDEPENDS_${PN} += "containerd-docker runc-docker"
RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
RSUGGESTS_${PN} = "lxc rt-tests"
diff --git a/recipes-containers/runc/runc-docker_git.bb b/recipes-containers/runc/runc-docker_git.bb
index 96d48ca..bf32953 100644
--- a/recipes-containers/runc/runc-docker_git.bb
+++ b/recipes-containers/runc/runc-docker_git.bb
@@ -8,4 +8,3 @@ SRC_URI = "git://github.com/docker/runc.git;nobranch=1 \
RUNC_VERSION = "1.0.0-rc2"
PROVIDES += "virtual/runc"
-RPROVIDES_${PN} = "virtual/runc"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCHv1 1/1] docker: fix dependency issues with deb packaging
@ 2017-04-03 7:36 Adrian Calianu
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Calianu @ 2017-04-03 7:36 UTC (permalink / raw)
To: meta-virtualization
dpkg-deb does not accept RDEPENDS += "virtual/xxxx"
'Provides' field, invalid package name 'virtual/containerd': character
'/' not allowed (only letters, digits and characters '-+._')
Signed-off-by: Adrian Calianu <adrian.calianu@enea.com>
---
recipes-containers/containerd/containerd-docker_git.bb | 1 -
recipes-containers/docker/docker_git.bb | 2 +-
recipes-containers/runc/runc-docker_git.bb | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/recipes-containers/containerd/containerd-docker_git.bb b/recipes-containers/containerd/containerd-docker_git.bb
index f6dcaec..604ada3 100644
--- a/recipes-containers/containerd/containerd-docker_git.bb
+++ b/recipes-containers/containerd/containerd-docker_git.bb
@@ -7,4 +7,3 @@ SRC_URI = "\
CONTAINERD_VERSION = "0.2.3"
PROVIDES += "virtual/containerd"
-RPROVIDES_${PN} = "virtual/containerd"
diff --git a/recipes-containers/docker/docker_git.bb b/recipes-containers/docker/docker_git.bb
index 6b73cf3..16d1dad 100644
--- a/recipes-containers/docker/docker_git.bb
+++ b/recipes-containers/docker/docker_git.bb
@@ -64,7 +64,7 @@ DEPENDS_append_class-target = " lvm2"
RDEPENDS_${PN} = "curl aufs-util git util-linux iptables \
${@bb.utils.contains('DISTRO_FEATURES','systemd','','cgroup-lite',d)} \
"
-RDEPENDS_${PN} += "virtual/containerd virtual/runc"
+RDEPENDS_${PN} += "containerd-docker runc-docker"
RRECOMMENDS_${PN} = "kernel-module-dm-thin-pool kernel-module-nf-nat"
RSUGGESTS_${PN} = "lxc rt-tests"
diff --git a/recipes-containers/runc/runc-docker_git.bb b/recipes-containers/runc/runc-docker_git.bb
index 96d48ca..bf32953 100644
--- a/recipes-containers/runc/runc-docker_git.bb
+++ b/recipes-containers/runc/runc-docker_git.bb
@@ -8,4 +8,3 @@ SRC_URI = "git://github.com/docker/runc.git;nobranch=1 \
RUNC_VERSION = "1.0.0-rc2"
PROVIDES += "virtual/runc"
-RPROVIDES_${PN} = "virtual/runc"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-03 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1491204611-40395-1-git-send-email-adrian.calianu@enea.com>
2017-04-03 11:15 ` [PATCHv1 1/1] docker: fix dependency issues with deb packaging Bruce Ashfield
2017-04-03 7:38 Adrian Calianu
-- strict thread matches above, loose matches on Subject: below --
2017-04-03 7:36 Adrian Calianu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.