From: Alex Deucher <alexdeucher@gmail.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>, "open list:EFIFB FRAMEBUFFER DRIVER" <linux-fbdev@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>, "open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>, pjones@redhat.com, Thomas Zimmermann <tzimmermann@suse.de>, Alex Deucher <alexander.deucher@amd.com> Subject: Re: [PATCH] efifb: Check efifb_pci_dev before using it Date: Tue, 13 Apr 2021 18:36:17 -0400 [thread overview] Message-ID: <CADnq5_MpDz9myx8HiKihq-6_Ud48sN=NXN1_ga7WZa9LguzSjA@mail.gmail.com> (raw) In-Reply-To: <CAKMK7uHR0VDk=C+u1d5qiiqQP+3ad5_gXQwvmPbJ56mG=3RjpQ@mail.gmail.com> On Tue, Apr 13, 2021 at 2:37 PM Daniel Vetter <daniel@ffwll.ch> wrote: > > On Tue, Apr 13, 2021 at 8:02 PM Alex Deucher <alexdeucher@gmail.com> wrote: > > > > On Tue, Apr 13, 2021 at 1:05 PM Kai-Heng Feng > > <kai.heng.feng@canonical.com> wrote: > > > > > > On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb is not > > > a PCI device. > > > > > > So make sure efifb_pci_dev is found before using it. > > > > > > Fixes: a6c0fd3d5a8b ("efifb: Ensure graphics device for efifb stays at PCI D0") > > > BugLink: https://bugs.launchpad.net/bugs/1922403 > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > > > Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > > fbdev is in drm-misc, so maybe you can push this one too? Yes, pushed. Thanks! Alex > -Daniel > > > > > > --- > > > drivers/video/fbdev/efifb.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > > > index f58a545b3bf3..8ea8f079cde2 100644 > > > --- a/drivers/video/fbdev/efifb.c > > > +++ b/drivers/video/fbdev/efifb.c > > > @@ -575,7 +575,8 @@ static int efifb_probe(struct platform_device *dev) > > > goto err_fb_dealoc; > > > } > > > fb_info(info, "%s frame buffer device\n", info->fix.id); > > > - pm_runtime_get_sync(&efifb_pci_dev->dev); > > > + if (efifb_pci_dev) > > > + pm_runtime_get_sync(&efifb_pci_dev->dev); > > > return 0; > > > > > > err_fb_dealoc: > > > @@ -602,7 +603,8 @@ static int efifb_remove(struct platform_device *pdev) > > > unregister_framebuffer(info); > > > sysfs_remove_groups(&pdev->dev.kobj, efifb_groups); > > > framebuffer_release(info); > > > - pm_runtime_put(&efifb_pci_dev->dev); > > > + if (efifb_pci_dev) > > > + pm_runtime_put(&efifb_pci_dev->dev); > > > > > > return 0; > > > } > > > -- > > > 2.30.2 > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>, "open list:EFIFB FRAMEBUFFER DRIVER" <linux-fbdev@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>, "open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>, pjones@redhat.com, Thomas Zimmermann <tzimmermann@suse.de>, Alex Deucher <alexander.deucher@amd.com> Subject: Re: [PATCH] efifb: Check efifb_pci_dev before using it Date: Tue, 13 Apr 2021 18:36:17 -0400 [thread overview] Message-ID: <CADnq5_MpDz9myx8HiKihq-6_Ud48sN=NXN1_ga7WZa9LguzSjA@mail.gmail.com> (raw) In-Reply-To: <CAKMK7uHR0VDk=C+u1d5qiiqQP+3ad5_gXQwvmPbJ56mG=3RjpQ@mail.gmail.com> On Tue, Apr 13, 2021 at 2:37 PM Daniel Vetter <daniel@ffwll.ch> wrote: > > On Tue, Apr 13, 2021 at 8:02 PM Alex Deucher <alexdeucher@gmail.com> wrote: > > > > On Tue, Apr 13, 2021 at 1:05 PM Kai-Heng Feng > > <kai.heng.feng@canonical.com> wrote: > > > > > > On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb is not > > > a PCI device. > > > > > > So make sure efifb_pci_dev is found before using it. > > > > > > Fixes: a6c0fd3d5a8b ("efifb: Ensure graphics device for efifb stays at PCI D0") > > > BugLink: https://bugs.launchpad.net/bugs/1922403 > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > > > Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > > fbdev is in drm-misc, so maybe you can push this one too? Yes, pushed. Thanks! Alex > -Daniel > > > > > > --- > > > drivers/video/fbdev/efifb.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > > > index f58a545b3bf3..8ea8f079cde2 100644 > > > --- a/drivers/video/fbdev/efifb.c > > > +++ b/drivers/video/fbdev/efifb.c > > > @@ -575,7 +575,8 @@ static int efifb_probe(struct platform_device *dev) > > > goto err_fb_dealoc; > > > } > > > fb_info(info, "%s frame buffer device\n", info->fix.id); > > > - pm_runtime_get_sync(&efifb_pci_dev->dev); > > > + if (efifb_pci_dev) > > > + pm_runtime_get_sync(&efifb_pci_dev->dev); > > > return 0; > > > > > > err_fb_dealoc: > > > @@ -602,7 +603,8 @@ static int efifb_remove(struct platform_device *pdev) > > > unregister_framebuffer(info); > > > sysfs_remove_groups(&pdev->dev.kobj, efifb_groups); > > > framebuffer_release(info); > > > - pm_runtime_put(&efifb_pci_dev->dev); > > > + if (efifb_pci_dev) > > > + pm_runtime_put(&efifb_pci_dev->dev); > > > > > > return 0; > > > } > > > -- > > > 2.30.2 > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-13 22:36 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-13 17:05 [PATCH] efifb: Check efifb_pci_dev before using it Kai-Heng Feng 2021-04-13 17:05 ` Kai-Heng Feng 2021-04-13 18:01 ` Alex Deucher 2021-04-13 18:01 ` Alex Deucher 2021-04-13 18:37 ` Daniel Vetter 2021-04-13 18:37 ` Daniel Vetter 2021-04-13 22:36 ` Alex Deucher [this message] 2021-04-13 22:36 ` Alex Deucher 2021-04-22 10:41 ` Sudeep Holla 2021-04-22 10:41 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADnq5_MpDz9myx8HiKihq-6_Ud48sN=NXN1_ga7WZa9LguzSjA@mail.gmail.com' \ --to=alexdeucher@gmail.com \ --cc=alexander.deucher@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kai.heng.feng@canonical.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pjones@redhat.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.