All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] riscv: Fix linking error when building u-boot-spl with no SMP support
@ 2020-06-29  8:27 Leo Yu-Chi Liang
  2020-07-07  9:45 ` Bin Meng
  0 siblings, 1 reply; 2+ messages in thread
From: Leo Yu-Chi Liang @ 2020-06-29  8:27 UTC (permalink / raw)
  To: u-boot

Switch off SMP support when building u-boot-spl would cause linking error as follow:
undefined reference to 'secondary hart relocate' and 'smp_call_function'.
Add macro to wrap up proper code region that needs SMP configuration on.

Signed-off by: Leo Liang <ycliang@andestech.com>
Cc: rick at andestech.com
---
 arch/riscv/cpu/start.S | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S
index 5f1c220..e3222b1 100644
--- a/arch/riscv/cpu/start.S
+++ b/arch/riscv/cpu/start.S
@@ -191,6 +191,7 @@ spl_stack_gd_setup:
 	mv	sp, s0
 #endif
 
+#if CONFIG_IS_ENABLED(SMP)
 	/* set new stack and global data pointer on secondary harts */
 spl_secondary_hart_stack_gd_setup:
 	la	a0, secondary_hart_relocate
@@ -205,6 +206,7 @@ spl_secondary_hart_stack_gd_setup:
 	la	a0, secondary_harts_relocation_error
 	jal	printf
 	jal	hang
+#endif
 
 	/* set new global data pointer on main hart */
 1:	mv	gp, s0
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 1/1] riscv: Fix linking error when building u-boot-spl with no SMP support
  2020-06-29  8:27 [PATCH 1/1] riscv: Fix linking error when building u-boot-spl with no SMP support Leo Yu-Chi Liang
@ 2020-07-07  9:45 ` Bin Meng
  0 siblings, 0 replies; 2+ messages in thread
From: Bin Meng @ 2020-07-07  9:45 UTC (permalink / raw)
  To: u-boot

On Mon, Jun 29, 2020 at 7:48 PM Leo Yu-Chi Liang <ycliang@andestech.com> wrote:
>
> Switch off SMP support when building u-boot-spl would cause linking error as follow:
> undefined reference to 'secondary hart relocate' and 'smp_call_function'.
> Add macro to wrap up proper code region that needs SMP configuration on.
>
> Signed-off by: Leo Liang <ycliang@andestech.com>
> Cc: rick at andestech.com
> ---
>  arch/riscv/cpu/start.S | 2 ++
>  1 file changed, 2 insertions(+)
>

Reviewed-by: Bin Meng <bin.meng@windriver.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-07  9:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29  8:27 [PATCH 1/1] riscv: Fix linking error when building u-boot-spl with no SMP support Leo Yu-Chi Liang
2020-07-07  9:45 ` Bin Meng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.