All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3-meson-g12a: fix usb2 PHY glue init when phy0 is disabled
Date: Thu, 3 Jun 2021 20:20:30 +0200	[thread overview]
Message-ID: <CAFBinCDeo=Mc=hjSuan_zE=SsZnz=vdjOwBY178PTnNcJBJK0g@mail.gmail.com> (raw)
In-Reply-To: <20210601084830.260196-1-narmstrong@baylibre.com>

On Tue, Jun 1, 2021 at 10:49 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> When only PHY1 is used (for example on Odroid-HC4), the regmap init code
> uses the usb2 ports when doesn't initialize the PHY1 regmap entry.
>
> This fixes:
> Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020
> ...
> pc : regmap_update_bits_base+0x40/0xa0
> lr : dwc3_meson_g12a_usb2_init_phy+0x4c/0xf8
> ...
> Call trace:
> regmap_update_bits_base+0x40/0xa0
> dwc3_meson_g12a_usb2_init_phy+0x4c/0xf8
> dwc3_meson_g12a_usb2_init+0x7c/0xc8
> dwc3_meson_g12a_usb_init+0x28/0x48
> dwc3_meson_g12a_probe+0x298/0x540
> platform_probe+0x70/0xe0
> really_probe+0xf0/0x4d8
> driver_probe_device+0xfc/0x168
> ...
>
> Fixes: 013af227f58a97 ("usb: dwc3: meson-g12a: handle the phy and glue registers separately")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
	 linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3-meson-g12a: fix usb2 PHY glue init when phy0 is disabled
Date: Thu, 3 Jun 2021 20:20:30 +0200	[thread overview]
Message-ID: <CAFBinCDeo=Mc=hjSuan_zE=SsZnz=vdjOwBY178PTnNcJBJK0g@mail.gmail.com> (raw)
In-Reply-To: <20210601084830.260196-1-narmstrong@baylibre.com>

On Tue, Jun 1, 2021 at 10:49 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> When only PHY1 is used (for example on Odroid-HC4), the regmap init code
> uses the usb2 ports when doesn't initialize the PHY1 regmap entry.
>
> This fixes:
> Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020
> ...
> pc : regmap_update_bits_base+0x40/0xa0
> lr : dwc3_meson_g12a_usb2_init_phy+0x4c/0xf8
> ...
> Call trace:
> regmap_update_bits_base+0x40/0xa0
> dwc3_meson_g12a_usb2_init_phy+0x4c/0xf8
> dwc3_meson_g12a_usb2_init+0x7c/0xc8
> dwc3_meson_g12a_usb_init+0x28/0x48
> dwc3_meson_g12a_probe+0x298/0x540
> platform_probe+0x70/0xe0
> really_probe+0xf0/0x4d8
> driver_probe_device+0xfc/0x168
> ...
>
> Fixes: 013af227f58a97 ("usb: dwc3: meson-g12a: handle the phy and glue registers separately")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
	 linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3-meson-g12a: fix usb2 PHY glue init when phy0 is disabled
Date: Thu, 3 Jun 2021 20:20:30 +0200	[thread overview]
Message-ID: <CAFBinCDeo=Mc=hjSuan_zE=SsZnz=vdjOwBY178PTnNcJBJK0g@mail.gmail.com> (raw)
In-Reply-To: <20210601084830.260196-1-narmstrong@baylibre.com>

On Tue, Jun 1, 2021 at 10:49 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> When only PHY1 is used (for example on Odroid-HC4), the regmap init code
> uses the usb2 ports when doesn't initialize the PHY1 regmap entry.
>
> This fixes:
> Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020
> ...
> pc : regmap_update_bits_base+0x40/0xa0
> lr : dwc3_meson_g12a_usb2_init_phy+0x4c/0xf8
> ...
> Call trace:
> regmap_update_bits_base+0x40/0xa0
> dwc3_meson_g12a_usb2_init_phy+0x4c/0xf8
> dwc3_meson_g12a_usb2_init+0x7c/0xc8
> dwc3_meson_g12a_usb_init+0x28/0x48
> dwc3_meson_g12a_probe+0x298/0x540
> platform_probe+0x70/0xe0
> really_probe+0xf0/0x4d8
> driver_probe_device+0xfc/0x168
> ...
>
> Fixes: 013af227f58a97 ("usb: dwc3: meson-g12a: handle the phy and glue registers separately")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2021-06-03 18:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01  8:48 [PATCH] usb: dwc3-meson-g12a: fix usb2 PHY glue init when phy0 is disabled Neil Armstrong
2021-06-01  8:48 ` Neil Armstrong
2021-06-01  8:48 ` Neil Armstrong
2021-06-03 18:20 ` Martin Blumenstingl [this message]
2021-06-03 18:20   ` Martin Blumenstingl
2021-06-03 18:20   ` Martin Blumenstingl
2021-06-04 10:58 ` Greg KH
2021-06-04 10:58   ` Greg KH
2021-06-04 10:58   ` Greg KH
2021-06-04 15:07   ` Konstantin Ryabitsev
2021-06-04 15:07     ` Konstantin Ryabitsev
2021-06-04 15:07     ` Konstantin Ryabitsev
2021-06-04 16:46     ` Konstantin Ryabitsev
2021-06-04 16:46       ` Konstantin Ryabitsev
2021-06-04 16:46       ` Konstantin Ryabitsev
2021-06-05  7:02       ` Greg KH
2021-06-05  7:02         ` Greg KH
2021-06-05  7:02         ` Greg KH
2021-06-07  6:46       ` Neil Armstrong
2021-06-07  6:46         ` Neil Armstrong
2021-06-07  6:46         ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFBinCDeo=Mc=hjSuan_zE=SsZnz=vdjOwBY178PTnNcJBJK0g@mail.gmail.com' \
    --to=martin.blumenstingl@googlemail.com \
    --cc=balbi@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.