All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PULL 0/2] hmp queue
@ 2017-10-30 20:23 Dr. David Alan Gilbert (git)
  2017-10-30 20:23 ` [Qemu-devel] [PULL 1/2] hmp: Replace error_report_err Dr. David Alan Gilbert (git)
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2017-10-30 20:23 UTC (permalink / raw)
  To: qemu-devel, groug, lu.zhipeng

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The following changes since commit abf6e752e55b2f5afb48303429dea2db7c3a62de:

  Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20171030' into staging (2017-10-30 13:02:45 +0000)

are available in the Git repository at:

  git://github.com/dagrh/qemu.git tags/pull-hmp-20171030

for you to fetch changes up to 751f8cfe2a556b3ef49f6af2860e2d1d2a1ec66a:

  monitor: fix dangling CPU pointer (2017-10-30 18:46:32 +0000)

----------------------------------------------------------------
hmp pull 2017-10-30

----------------------------------------------------------------
Greg Kurz (1):
      monitor: fix dangling CPU pointer

ZhiPeng Lu (1):
      hmp: Replace error_report_err

 hmp.c     | 26 ++++++++------------------
 monitor.c | 23 ++++++++++++++++++-----
 2 files changed, 26 insertions(+), 23 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Qemu-devel] [PULL 1/2] hmp: Replace error_report_err
  2017-10-30 20:23 [Qemu-devel] [PULL 0/2] hmp queue Dr. David Alan Gilbert (git)
@ 2017-10-30 20:23 ` Dr. David Alan Gilbert (git)
  2017-10-30 20:23 ` [Qemu-devel] [PULL 2/2] monitor: fix dangling CPU pointer Dr. David Alan Gilbert (git)
  2017-10-31 13:11 ` [Qemu-devel] [PULL 0/2] hmp queue Peter Maydell
  2 siblings, 0 replies; 15+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2017-10-30 20:23 UTC (permalink / raw)
  To: qemu-devel, groug, lu.zhipeng

From: ZhiPeng Lu <lu.zhipeng@zte.com.cn>

Use hmp_handle_error instend of error_report_err to set error.

Signed-off-by: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
Reviewed-by: Jiyun Fan <fan.jiyun@zte.com.cn>
Message-Id: <1508411793-22868-1-git-send-email-lu.zhipeng@zte.com.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 hmp.c | 26 ++++++++------------------
 1 file changed, 8 insertions(+), 18 deletions(-)

diff --git a/hmp.c b/hmp.c
index a01be50daa..35a7041824 100644
--- a/hmp.c
+++ b/hmp.c
@@ -670,7 +670,7 @@ void hmp_info_vnc(Monitor *mon, const QDict *qdict)
 
     info2l = qmp_query_vnc_servers(&err);
     if (err) {
-        error_report_err(err);
+        hmp_handle_error(mon, &err);
         return;
     }
     if (!info2l) {
@@ -785,7 +785,7 @@ void hmp_info_balloon(Monitor *mon, const QDict *qdict)
 
     info = qmp_query_balloon(&err);
     if (err) {
-        error_report_err(err);
+        hmp_handle_error(mon, &err);
         return;
     }
 
@@ -1128,7 +1128,7 @@ void hmp_ringbuf_read(Monitor *mon, const QDict *qdict)
 
     data = qmp_ringbuf_read(chardev, size, false, 0, &err);
     if (err) {
-        error_report_err(err);
+        hmp_handle_error(mon, &err);
         return;
     }
 
@@ -1195,9 +1195,7 @@ void hmp_balloon(Monitor *mon, const QDict *qdict)
     Error *err = NULL;
 
     qmp_balloon(value, &err);
-    if (err) {
-        error_report_err(err);
-    }
+    hmp_handle_error(mon, &err);
 }
 
 void hmp_block_resize(Monitor *mon, const QDict *qdict)
@@ -1534,10 +1532,7 @@ void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict)
     Error *err = NULL;
 
     qmp_migrate_set_cache_size(value, &err);
-    if (err) {
-        error_report_err(err);
-        return;
-    }
+    hmp_handle_error(mon, &err);
 }
 
 /* Kept for backwards compatibility */
@@ -1568,10 +1563,7 @@ void hmp_migrate_set_capability(Monitor *mon, const QDict *qdict)
 
 end:
     qapi_free_MigrationCapabilityStatusList(caps);
-
-    if (err) {
-        error_report_err(err);
-    }
+    hmp_handle_error(mon, &err);
 }
 
 void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
@@ -1680,9 +1672,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
  cleanup:
     qapi_free_MigrateSetParameters(p);
     visit_free(v);
-    if (err) {
-        error_report_err(err);
-    }
+    hmp_handle_error(mon, &err);
 }
 
 void hmp_client_migrate_info(Monitor *mon, const QDict *qdict)
@@ -1936,7 +1926,7 @@ void hmp_migrate(Monitor *mon, const QDict *qdict)
 
     qmp_migrate(uri, !!blk, blk, !!inc, inc, false, false, &err);
     if (err) {
-        error_report_err(err);
+        hmp_handle_error(mon, &err);
         return;
     }
 
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [Qemu-devel] [PULL 2/2] monitor: fix dangling CPU pointer
  2017-10-30 20:23 [Qemu-devel] [PULL 0/2] hmp queue Dr. David Alan Gilbert (git)
  2017-10-30 20:23 ` [Qemu-devel] [PULL 1/2] hmp: Replace error_report_err Dr. David Alan Gilbert (git)
@ 2017-10-30 20:23 ` Dr. David Alan Gilbert (git)
  2017-10-31 13:11 ` [Qemu-devel] [PULL 0/2] hmp queue Peter Maydell
  2 siblings, 0 replies; 15+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2017-10-30 20:23 UTC (permalink / raw)
  To: qemu-devel, groug, lu.zhipeng

From: Greg Kurz <groug@kaod.org>

If a CPU selected with the "cpu" command is hot-unplugged then "info cpus"
causes QEMU to exit:

(qemu) device_del cpu1
(qemu) info cpus
qemu:qemu_cpu_kick_thread: No such process

This happens because "cpu" stores the pointer to the selected CPU into
the monitor structure. When the CPU is hot-unplugged, we end up with a
dangling pointer. The "info cpus" command then does:

hmp_info_cpus()
 monitor_get_cpu_index()
  mon_get_cpu()
   cpu_synchronize_state() <--- called with dangling pointer

This could cause a QEMU crash as well.

This patch switches the monitor to store the QOM path instead of a
pointer to the current CPU. The path is then resolved when needed.
If the resolution fails, we assume that the CPU was removed and the
path is resetted to the default (ie, path of first_cpu).

Reported-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <150822818243.26242.12993827911736928961.stgit@bahia.lan>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 monitor.c | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/monitor.c b/monitor.c
index 7a802a345e..e36fb5308d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -200,7 +200,7 @@ struct Monitor {
 
     ReadLineState *rs;
     MonitorQMP qmp;
-    CPUState *mon_cpu;
+    gchar *mon_cpu_path;
     BlockCompletionFunc *password_completion_cb;
     void *password_opaque;
     mon_cmd_t *cmd_table;
@@ -579,6 +579,7 @@ static void monitor_data_init(Monitor *mon)
 
 static void monitor_data_destroy(Monitor *mon)
 {
+    g_free(mon->mon_cpu_path);
     qemu_chr_fe_deinit(&mon->chr, false);
     if (monitor_is_qmp(mon)) {
         json_message_parser_destroy(&mon->qmp.parser);
@@ -1047,20 +1048,32 @@ int monitor_set_cpu(int cpu_index)
     if (cpu == NULL) {
         return -1;
     }
-    cur_mon->mon_cpu = cpu;
+    g_free(cur_mon->mon_cpu_path);
+    cur_mon->mon_cpu_path = object_get_canonical_path(OBJECT(cpu));
     return 0;
 }
 
 CPUState *mon_get_cpu(void)
 {
-    if (!cur_mon->mon_cpu) {
+    CPUState *cpu;
+
+    if (cur_mon->mon_cpu_path) {
+        cpu = (CPUState *) object_resolve_path_type(cur_mon->mon_cpu_path,
+                                                    TYPE_CPU, NULL);
+        if (!cpu) {
+            g_free(cur_mon->mon_cpu_path);
+            cur_mon->mon_cpu_path = NULL;
+        }
+    }
+    if (!cur_mon->mon_cpu_path) {
         if (!first_cpu) {
             return NULL;
         }
         monitor_set_cpu(first_cpu->cpu_index);
+        cpu = first_cpu;
     }
-    cpu_synchronize_state(cur_mon->mon_cpu);
-    return cur_mon->mon_cpu;
+    cpu_synchronize_state(cpu);
+    return cpu;
 }
 
 CPUArchState *mon_get_cpu_env(void)
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [Qemu-devel] [PULL 0/2] hmp queue
  2017-10-30 20:23 [Qemu-devel] [PULL 0/2] hmp queue Dr. David Alan Gilbert (git)
  2017-10-30 20:23 ` [Qemu-devel] [PULL 1/2] hmp: Replace error_report_err Dr. David Alan Gilbert (git)
  2017-10-30 20:23 ` [Qemu-devel] [PULL 2/2] monitor: fix dangling CPU pointer Dr. David Alan Gilbert (git)
@ 2017-10-31 13:11 ` Peter Maydell
  2 siblings, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2017-10-31 13:11 UTC (permalink / raw)
  To: Dr. David Alan Gilbert (git); +Cc: QEMU Developers, Greg Kurz, lu.zhipeng

On 30 October 2017 at 20:23, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit abf6e752e55b2f5afb48303429dea2db7c3a62de:
>
>   Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20171030' into staging (2017-10-30 13:02:45 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/dagrh/qemu.git tags/pull-hmp-20171030
>
> for you to fetch changes up to 751f8cfe2a556b3ef49f6af2860e2d1d2a1ec66a:
>
>   monitor: fix dangling CPU pointer (2017-10-30 18:46:32 +0000)
>
> ----------------------------------------------------------------
> hmp pull 2017-10-30
>

applied, thanks
-- PMM

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Qemu-devel] [PULL 0/2] hmp queue
  2019-05-01 10:59 Dr. David Alan Gilbert (git)
@ 2019-05-02 11:04 ` Peter Maydell
  0 siblings, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2019-05-02 11:04 UTC (permalink / raw)
  To: Dr. David Alan Gilbert (git); +Cc: QEMU Developers, Cole Robinson

On Wed, 1 May 2019 at 12:00, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit f75d15231e56cb0f2bafe19faf1229c459a60731:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-04-30 17:06:57 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/dagrh/qemu.git tags/pull-hmp-20190501
>
> for you to fetch changes up to 574d96933ceff60b2d13fe97602572fc7e95f7c6:
>
>   hmp: gva2gpa debug command (2019-05-01 10:46:59 +0100)
>
> ----------------------------------------------------------------
> HMP pull
>
> New gva2gpa command
> delvm now uses hmp_handle_error so gets Error: prefix in messages
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.1
for any user-visible changes.

-- PMM

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Qemu-devel] [PULL 0/2] hmp queue
@ 2019-05-01 10:59 Dr. David Alan Gilbert (git)
  2019-05-02 11:04 ` Peter Maydell
  0 siblings, 1 reply; 15+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2019-05-01 10:59 UTC (permalink / raw)
  To: qemu-devel, crobinso

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The following changes since commit f75d15231e56cb0f2bafe19faf1229c459a60731:

  Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-04-30 17:06:57 +0100)

are available in the Git repository at:

  git://github.com/dagrh/qemu.git tags/pull-hmp-20190501

for you to fetch changes up to 574d96933ceff60b2d13fe97602572fc7e95f7c6:

  hmp: gva2gpa debug command (2019-05-01 10:46:59 +0100)

----------------------------------------------------------------
HMP pull

New gva2gpa command
delvm now uses hmp_handle_error so gets Error: prefix in messages

----------------------------------------------------------------
Cole Robinson (1):
      hmp: delvm: use hmp_handle_error

Dr. David Alan Gilbert (1):
      hmp: gva2gpa debug command

 hmp-commands.hx  | 15 +++++++++++++++
 hmp.c            |  7 ++++---
 monitor.c        | 22 ++++++++++++++++++++++
 tests/test-hmp.c |  1 +
 4 files changed, 42 insertions(+), 3 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Qemu-devel] [PULL 0/2] hmp queue
  2018-03-20 12:41 Dr. David Alan Gilbert (git)
@ 2018-03-20 19:02 ` Peter Maydell
  0 siblings, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2018-03-20 19:02 UTC (permalink / raw)
  To: Dr. David Alan Gilbert (git)
  Cc: QEMU Developers, Marc-André Lureau, jixiang_zhang

On 20 March 2018 at 12:41, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit 4bdc24fa018901892bb8a5bd1808ebd605f4c64d:
>
>   Merge remote-tracking branch 'remotes/ericb/tags/pull-qapi-2018-03-12-v4' into staging (2018-03-20 09:51:49 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/dagrh/qemu.git tags/pull-hmp-20180320
>
> for you to fetch changes up to 95372184b7acdfd82ee748b6f0c6df1d839982ba:
>
>   hmp: free sev info (2018-03-20 12:32:06 +0000)
>
> ----------------------------------------------------------------
> HMP fixes for 2.12
>
> ----------------------------------------------------------------
> Marc-André Lureau (1):
>       hmp: free sev info
>
> zhangjixiang (1):
>       HMP: Initialize err before using
>

Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Qemu-devel] [PULL 0/2] hmp queue
@ 2018-03-20 12:41 Dr. David Alan Gilbert (git)
  2018-03-20 19:02 ` Peter Maydell
  0 siblings, 1 reply; 15+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2018-03-20 12:41 UTC (permalink / raw)
  To: qemu-devel; +Cc: marcandre.lureau, jixiang_zhang

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The following changes since commit 4bdc24fa018901892bb8a5bd1808ebd605f4c64d:

  Merge remote-tracking branch 'remotes/ericb/tags/pull-qapi-2018-03-12-v4' into staging (2018-03-20 09:51:49 +0000)

are available in the Git repository at:

  git://github.com/dagrh/qemu.git tags/pull-hmp-20180320

for you to fetch changes up to 95372184b7acdfd82ee748b6f0c6df1d839982ba:

  hmp: free sev info (2018-03-20 12:32:06 +0000)

----------------------------------------------------------------
HMP fixes for 2.12

----------------------------------------------------------------
Marc-André Lureau (1):
      hmp: free sev info

zhangjixiang (1):
      HMP: Initialize err before using

 hmp.c                 | 2 +-
 target/i386/monitor.c | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Qemu-devel] [PULL 0/2] hmp queue
  2018-02-16 17:46 Dr. David Alan Gilbert (git)
@ 2018-02-19  9:46 ` Peter Maydell
  0 siblings, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2018-02-19  9:46 UTC (permalink / raw)
  To: Dr. David Alan Gilbert (git); +Cc: QEMU Developers, Thomas Huth, t.pagef.lt

On 16 February 2018 at 17:46, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit 5e8d6a12d643a38b82a0a713a77d1192117dbdca:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180216-pull-request' into staging (2018-02-16 15:55:45 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/dagrh/qemu.git tags/pull-hmp-20180216
>
> for you to fetch changes up to bf67f1c0b16c0de43b8a10cb53808dd62b0cdc04:
>
>   monitor.c: Fix infinite loop in monitor's auto-complete (2018-02-16 17:36:16 +0000)
>
> ----------------------------------------------------------------
> HMP pull 2018-02-16
>
> ----------------------------------------------------------------
> Dr. David Alan Gilbert (1):
>       monitor.c: Fix infinite loop in monitor's auto-complete
>
> Thomas Huth (1):
>       monitor: Remove legacy "-mon default=on" parameter

Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Qemu-devel] [PULL 0/2] hmp queue
@ 2018-02-16 17:46 Dr. David Alan Gilbert (git)
  2018-02-19  9:46 ` Peter Maydell
  0 siblings, 1 reply; 15+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2018-02-16 17:46 UTC (permalink / raw)
  To: qemu-devel, thuth, t.pagef.lt

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The following changes since commit 5e8d6a12d643a38b82a0a713a77d1192117dbdca:

  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180216-pull-request' into staging (2018-02-16 15:55:45 +0000)

are available in the Git repository at:

  git://github.com/dagrh/qemu.git tags/pull-hmp-20180216

for you to fetch changes up to bf67f1c0b16c0de43b8a10cb53808dd62b0cdc04:

  monitor.c: Fix infinite loop in monitor's auto-complete (2018-02-16 17:36:16 +0000)

----------------------------------------------------------------
HMP pull 2018-02-16

----------------------------------------------------------------
Dr. David Alan Gilbert (1):
      monitor.c: Fix infinite loop in monitor's auto-complete

Thomas Huth (1):
      monitor: Remove legacy "-mon default=on" parameter

 monitor.c     | 9 ++++-----
 qemu-doc.texi | 9 ---------
 vl.c          | 4 ----
 3 files changed, 4 insertions(+), 18 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Qemu-devel] [PULL 0/2] hmp queue
  2017-12-14 12:48 Dr. David Alan Gilbert (git)
  2017-12-14 16:39 ` Peter Maydell
@ 2017-12-14 16:56 ` no-reply
  1 sibling, 0 replies; 15+ messages in thread
From: no-reply @ 2017-12-14 16:56 UTC (permalink / raw)
  To: dgilbert; +Cc: famz, qemu-devel

Hi,

This series failed build test on ppc host. Please find the details below.

Message-id: 20171214124817.2567-1-dgilbert@redhat.com
Subject: [Qemu-devel] [PULL 0/2] hmp queue
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e
echo "=== ENV ==="
env
echo "=== PACKAGES ==="
rpm -qa
echo "=== TEST BEGIN ==="
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --prefix=$INSTALL
make -j100
# XXX: we need reliable clean up
# make check -j100 V=1
make install
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1513269392-23224-1-git-send-email-jianjay.zhou@huawei.com -> patchew/1513269392-23224-1-git-send-email-jianjay.zhou@huawei.com
 - [tag update]      patchew/20171214124817.2567-1-dgilbert@redhat.com -> patchew/20171214124817.2567-1-dgilbert@redhat.com
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Submodule 'pixman' (git://anongit.freedesktop.org/pixman) registered for path 'pixman'
Submodule 'roms/SLOF' (git://git.qemu-project.org/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (git://git.qemu-project.org/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (git://git.qemu-project.org/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (git://git.qemu-project.org/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (git://github.com/rth7680/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (git://git.qemu-project.org/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/sgabios' (git://git.qemu-project.org/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/u-boot' (git://git.qemu-project.org/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/vgabios' (git://git.qemu-project.org/vgabios.git/) registered for path 'roms/vgabios'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf'
Cloning into 'pixman'...
Submodule path 'pixman': checked out '87eea99e443b389c978cf37efc52788bf03a0ee0'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'e3d05727a074619fc12d0a67f05cf2c42c875cce'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out '04186319181298083ef28695a8309028b26fe83c'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 'e79bca64838c96ec44fd7acd508879c5284233dd'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 'c87a92639b28ac42bc8f6c67443543b405dc479b'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'e2fc41e24ee0ada60fc511d60b15a41b294538be'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out '23d474943dcd55d0550a3d20b3d30e9040a4f15b'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out '2072e7262965bb48d7fffb1e283101e6ed8b21a8'
Cloning into 'roms/vgabios'...
Submodule path 'roms/vgabios': checked out '19ea12c230ded95928ecaef0db47a82231c2e485'
warning: unable to rmdir pixman: Directory not empty
Switched to a new branch 'test'
M	dtc
M	roms/SLOF
M	roms/ipxe
M	roms/openbios
M	roms/qemu-palcode
M	roms/seabios
M	roms/sgabios
M	roms/u-boot
fatal: Not a valid branch point: '0ef0583d5adceb9138bdb47494dabd1549ac5b6d'.
Traceback (most recent call last):
  File "/home/patchew/patchew/patchew-cli", line 508, in test_one
    cwd=clone, stdout=logf, stderr=logf)
  File "/usr/lib64/python3.4/subprocess.py", line 558, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'branch', 'base', '0ef0583d5adceb9138bdb47494dabd1549ac5b6d']' returned non-zero exit status 128



---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Qemu-devel] [PULL 0/2] hmp queue
  2017-12-14 12:48 Dr. David Alan Gilbert (git)
@ 2017-12-14 16:39 ` Peter Maydell
  2017-12-14 16:56 ` no-reply
  1 sibling, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2017-12-14 16:39 UTC (permalink / raw)
  To: Dr. David Alan Gilbert (git); +Cc: QEMU Developers

On 14 December 2017 at 12:48, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639:
>
>   Update version for v2.11.0 release (2017-12-13 14:31:09 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/dagrh/qemu.git tags/pull-hmp-20171214
>
> for you to fetch changes up to 0eaf3b824745cacebfc321aef6787528d33d58fe:
>
>   tests: test-hmp: print command execution result (2017-12-14 11:09:42 +0000)
>
> ----------------------------------------------------------------
> HMP pull 2017-12-14
>
> ----------------------------------------------------------------
> Thomas Huth (1):
>       hmp-commands: Remove the deprecated usb_add and usb_del
>
> Vadim Galitsyn (1):
>       tests: test-hmp: print command execution result
>
Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Qemu-devel] [PULL 0/2] hmp queue
@ 2017-12-14 12:48 Dr. David Alan Gilbert (git)
  2017-12-14 16:39 ` Peter Maydell
  2017-12-14 16:56 ` no-reply
  0 siblings, 2 replies; 15+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2017-12-14 12:48 UTC (permalink / raw)
  To: qemu-devel

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639:

  Update version for v2.11.0 release (2017-12-13 14:31:09 +0000)

are available in the Git repository at:

  git://github.com/dagrh/qemu.git tags/pull-hmp-20171214

for you to fetch changes up to 0eaf3b824745cacebfc321aef6787528d33d58fe:

  tests: test-hmp: print command execution result (2017-12-14 11:09:42 +0000)

----------------------------------------------------------------
HMP pull 2017-12-14

----------------------------------------------------------------
Thomas Huth (1):
      hmp-commands: Remove the deprecated usb_add and usb_del

Vadim Galitsyn (1):
      tests: test-hmp: print command execution result

 hmp-commands.hx         | 33 ---------------------------------
 hw/usb/bus.c            | 22 ----------------------
 include/hw/usb.h        |  1 -
 include/sysemu/sysemu.h |  2 --
 qemu-doc.texi           |  8 --------
 tests/test-hmp.c        |  7 +++++--
 vl.c                    | 44 --------------------------------------------
 7 files changed, 5 insertions(+), 112 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Qemu-devel] [PULL 0/2] hmp queue
  2017-06-29 16:30 Dr. David Alan Gilbert (git)
@ 2017-06-30 10:58 ` Peter Maydell
  0 siblings, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2017-06-30 10:58 UTC (permalink / raw)
  To: Dr. David Alan Gilbert (git); +Cc: QEMU Developers

On 29 June 2017 at 17:30, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit 454d7dc9bc13e46084e0612076e6952c40f4afeb:
>
>   Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2017-06-29 16:21:45 +0100)
>
> are available in the git repository at:
>
>   git://github.com/dagrh/qemu.git tags/pull-hmp-20170629
>
> for you to fetch changes up to bd1d5ad9f9a1347d6f4338f294253617c565c89a:
>
>   Add chardev-send-break monitor command (2017-06-29 17:14:11 +0100)
>
> ----------------------------------------------------------------
> HMP pull 2017-06-29
>
> ----------------------------------------------------------------
> Stefan Fritsch (1):
>       Add chardev-send-break monitor command
>
> Suraj Jitindar Singh (1):
>       monitor: Add -a (all) option to info registers
>
>  chardev/char.c       | 12 ++++++++++++
>  hmp-commands-info.hx |  6 +++---
>  hmp-commands.hx      | 16 ++++++++++++++++
>  hmp.c                |  8 ++++++++
>  hmp.h                |  1 +
>  monitor.c            | 21 ++++++++++++++++-----
>  qapi-schema.json     | 20 ++++++++++++++++++++
>  tests/test-char.c    | 12 ++++++++++--
>  tests/test-hmp.c     |  1 +
>  9 files changed, 87 insertions(+), 10 deletions(-)
>
Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Qemu-devel] [PULL 0/2] hmp queue
@ 2017-06-29 16:30 Dr. David Alan Gilbert (git)
  2017-06-30 10:58 ` Peter Maydell
  0 siblings, 1 reply; 15+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2017-06-29 16:30 UTC (permalink / raw)
  To: qemu-devel

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The following changes since commit 454d7dc9bc13e46084e0612076e6952c40f4afeb:

  Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2017-06-29 16:21:45 +0100)

are available in the git repository at:

  git://github.com/dagrh/qemu.git tags/pull-hmp-20170629

for you to fetch changes up to bd1d5ad9f9a1347d6f4338f294253617c565c89a:

  Add chardev-send-break monitor command (2017-06-29 17:14:11 +0100)

----------------------------------------------------------------
HMP pull 2017-06-29

----------------------------------------------------------------
Stefan Fritsch (1):
      Add chardev-send-break monitor command

Suraj Jitindar Singh (1):
      monitor: Add -a (all) option to info registers

 chardev/char.c       | 12 ++++++++++++
 hmp-commands-info.hx |  6 +++---
 hmp-commands.hx      | 16 ++++++++++++++++
 hmp.c                |  8 ++++++++
 hmp.h                |  1 +
 monitor.c            | 21 ++++++++++++++++-----
 qapi-schema.json     | 20 ++++++++++++++++++++
 tests/test-char.c    | 12 ++++++++++--
 tests/test-hmp.c     |  1 +
 9 files changed, 87 insertions(+), 10 deletions(-)

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2019-05-02 11:05 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30 20:23 [Qemu-devel] [PULL 0/2] hmp queue Dr. David Alan Gilbert (git)
2017-10-30 20:23 ` [Qemu-devel] [PULL 1/2] hmp: Replace error_report_err Dr. David Alan Gilbert (git)
2017-10-30 20:23 ` [Qemu-devel] [PULL 2/2] monitor: fix dangling CPU pointer Dr. David Alan Gilbert (git)
2017-10-31 13:11 ` [Qemu-devel] [PULL 0/2] hmp queue Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2019-05-01 10:59 Dr. David Alan Gilbert (git)
2019-05-02 11:04 ` Peter Maydell
2018-03-20 12:41 Dr. David Alan Gilbert (git)
2018-03-20 19:02 ` Peter Maydell
2018-02-16 17:46 Dr. David Alan Gilbert (git)
2018-02-19  9:46 ` Peter Maydell
2017-12-14 12:48 Dr. David Alan Gilbert (git)
2017-12-14 16:39 ` Peter Maydell
2017-12-14 16:56 ` no-reply
2017-06-29 16:30 Dr. David Alan Gilbert (git)
2017-06-30 10:58 ` Peter Maydell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.