* [PATCH] Drivers:staging:speakup: Fixed checkpatch warning
@ 2014-11-26 11:14 Athira Lekshmi C V
2014-11-26 11:26 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: Athira Lekshmi C V @ 2014-11-26 11:14 UTC (permalink / raw)
To: gregkh
Cc: domagoj.trsan, aysemelikeyurtoglu, speakup, devel, linux-kernel,
Athira Lekshmi C V
Fixed the checkpatch warning:
WARNING: simple_strtoul is obsolete, use kstrtoul instead
Signed-off-by: Athira Lekshmi C V <andnlnbn18@gmail.com>
---
drivers/staging/speakup/varhandlers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
index 1b0d1c0..00fd67e 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
{
int val = 0;
- val = simple_strtoul(skip_spaces(start), &start, 10);
+ val = kstrtoul(skip_spaces(start), &start, 10);
if (*start == ',')
start++;
*dest = (u_char)val;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Drivers:staging:speakup: Fixed checkpatch warning
2014-11-26 11:14 [PATCH] Drivers:staging:speakup: Fixed checkpatch warning Athira Lekshmi C V
@ 2014-11-26 11:26 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2014-11-26 11:26 UTC (permalink / raw)
To: Athira Lekshmi C V
Cc: Greg KH, domagoj.trsan, aysemelikeyurtoglu, speakup, devel, LKML
On Wed, Nov 26, 2014 at 12:14 PM, Athira Lekshmi C V
<andnlnbn18@gmail.com> wrote:
> Fixed the checkpatch warning:
> WARNING: simple_strtoul is obsolete, use kstrtoul instead
>
> Signed-off-by: Athira Lekshmi C V <andnlnbn18@gmail.com>
> ---
> drivers/staging/speakup/varhandlers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
> index 1b0d1c0..00fd67e 100644
> --- a/drivers/staging/speakup/varhandlers.c
> +++ b/drivers/staging/speakup/varhandlers.c
> @@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
> {
> int val = 0;
>
> - val = simple_strtoul(skip_spaces(start), &start, 10);
> + val = kstrtoul(skip_spaces(start), &start, 10);
> if (*start == ',')
> start++;
> *dest = (u_char)val;
NACK.
Please test your patch or at least read the function signature kstrtoul().
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-26 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-26 11:14 [PATCH] Drivers:staging:speakup: Fixed checkpatch warning Athira Lekshmi C V
2014-11-26 11:26 ` Richard Weinberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.