All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ondrej Mosnacek <omosnace@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: rdunlap@infradead.org, sfr@canb.auug.org.au,
	linux-next@vger.kernel.org,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Eric Paris <eparis@redhat.com>,
	Linux-Audit Mailing List <linux-audit@redhat.com>
Subject: Re: linux-next: Tree for Jun 20 (kernel/auditsc.c)
Date: Thu, 21 Jun 2018 09:33:26 +0200	[thread overview]
Message-ID: <CAFqZXNsw8iWB74jDof39Z8KM29EDvnpvQ_AvxPbvdM9hZ1cXAQ@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhQv26uPWSYmhNdhJ4QM+AMKK=JFkMmDftLb1WpvOUyN8Q@mail.gmail.com>

st 20. 6. 2018 o 22:00 Paul Moore <paul@paul-moore.com> napísal(a):
>
> On Wed, Jun 20, 2018 at 11:48 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > On 06/19/2018 09:42 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Changes since 20180619:
> > >
> >
> > on x86_64:
> >
> > kernel/auditsc.o: In function `audit_filter_rules.isra.20':
> > auditsc.c:(.text+0x8c5): undefined reference to `groups_search'
> > auditsc.c:(.text+0x909): undefined reference to `groups_search'
> >
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > Full randconfig file is attached.
>
> Thanks Randy.
>
> I believe the issue is that when CONFIG_MULTIUSER is not enabled
> groups.{c.o} is not included.  Ondrej, please look into this and
> submit a fix as soon as possible, thank you.

I'm working on it, stay tuned... It should be an easy fix, but it will
(likely) need changes outside the audit code. We could work around it
locally, of course, but since this is just in -next, I believe it's
worth to fix it properly.

Cheers,
--
Ondrej Mosnacek <omosnace at redhat dot com>
Associate Software Engineer, Security Technologies
Red Hat, Inc.

WARNING: multiple messages have this Message-ID (diff)
From: Ondrej Mosnacek <omosnace@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: sfr@canb.auug.org.au, rdunlap@infradead.org,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Linux-Audit Mailing List <linux-audit@redhat.com>,
	linux-next@vger.kernel.org
Subject: Re: linux-next: Tree for Jun 20 (kernel/auditsc.c)
Date: Thu, 21 Jun 2018 09:33:26 +0200	[thread overview]
Message-ID: <CAFqZXNsw8iWB74jDof39Z8KM29EDvnpvQ_AvxPbvdM9hZ1cXAQ@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhQv26uPWSYmhNdhJ4QM+AMKK=JFkMmDftLb1WpvOUyN8Q@mail.gmail.com>

st 20. 6. 2018 o 22:00 Paul Moore <paul@paul-moore.com> napísal(a):
>
> On Wed, Jun 20, 2018 at 11:48 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > On 06/19/2018 09:42 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Changes since 20180619:
> > >
> >
> > on x86_64:
> >
> > kernel/auditsc.o: In function `audit_filter_rules.isra.20':
> > auditsc.c:(.text+0x8c5): undefined reference to `groups_search'
> > auditsc.c:(.text+0x909): undefined reference to `groups_search'
> >
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > Full randconfig file is attached.
>
> Thanks Randy.
>
> I believe the issue is that when CONFIG_MULTIUSER is not enabled
> groups.{c.o} is not included.  Ondrej, please look into this and
> submit a fix as soon as possible, thank you.

I'm working on it, stay tuned... It should be an easy fix, but it will
(likely) need changes outside the audit code. We could work around it
locally, of course, but since this is just in -next, I believe it's
worth to fix it properly.

Cheers,
--
Ondrej Mosnacek <omosnace at redhat dot com>
Associate Software Engineer, Security Technologies
Red Hat, Inc.

--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit

  reply	other threads:[~2018-06-21  7:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  4:42 linux-next: Tree for Jun 20 Stephen Rothwell
2018-06-20 15:48 ` linux-next: Tree for Jun 20 (kernel/auditsc.c) Randy Dunlap
2018-06-20 20:00   ` Paul Moore
2018-06-21  7:33     ` Ondrej Mosnacek [this message]
2018-06-21  7:33       ` Ondrej Mosnacek
2018-06-21  8:33     ` [PATCH -next] cred: conditionally declare groups-related functions Ondrej Mosnacek
2018-06-21  8:33       ` Ondrej Mosnacek
2018-06-21 17:11       ` Randy Dunlap
2018-06-21 21:17       ` Paul Moore
2018-06-22  7:47         ` Ondrej Mosnacek
2018-06-22 19:19           ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFqZXNsw8iWB74jDof39Z8KM29EDvnpvQ_AvxPbvdM9hZ1cXAQ@mail.gmail.com \
    --to=omosnace@redhat.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.