* [PATCH] ACPI / video: Add Dell Inspiron 5737 to the blacklist
@ 2014-07-08 2:14 Yidi Lin
2014-07-08 13:31 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Yidi Lin @ 2014-07-08 2:14 UTC (permalink / raw)
To: rjw, Len Brown, linux-acpi
With win8 capability, the ACPI backlight control is broken on this model.
The system also loses backlight setting when resuming from S3.
Add this model to the the ACPI video detect blacklist to make backlight
functionality work.
Although backlight functionality works via video.use_native_backlight=1,
this approach may be safer.
Signed-off-by: Edward Lin <yidi.lin@canonical.com>
---
drivers/acpi/video_detect.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 33e3db5..c42feb2 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -166,6 +166,14 @@ static struct dmi_system_id video_detect_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
},
},
+ {
+ .callback = video_detect_force_vendor,
+ .ident = "Dell Inspiron 5737",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"),
+ },
+ },
{ },
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI / video: Add Dell Inspiron 5737 to the blacklist
2014-07-08 2:14 [PATCH] ACPI / video: Add Dell Inspiron 5737 to the blacklist Yidi Lin
@ 2014-07-08 13:31 ` Rafael J. Wysocki
2014-07-08 15:04 ` Yidi Lin
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2014-07-08 13:31 UTC (permalink / raw)
To: Yidi Lin; +Cc: Len Brown, linux-acpi
On Tuesday, July 08, 2014 10:14:59 AM Yidi Lin wrote:
> With win8 capability, the ACPI backlight control is broken on this model.
> The system also loses backlight setting when resuming from S3.
>
> Add this model to the the ACPI video detect blacklist to make backlight
> functionality work.
>
> Although backlight functionality works via video.use_native_backlight=1,
> this approach may be safer.
>
> Signed-off-by: Edward Lin <yidi.lin@canonical.com>
I've applied this patch already it seems, haven't I?
> ---
> drivers/acpi/video_detect.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 33e3db5..c42feb2 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -166,6 +166,14 @@ static struct dmi_system_id video_detect_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
> },
> },
> + {
> + .callback = video_detect_force_vendor,
> + .ident = "Dell Inspiron 5737",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"),
> + },
> + },
> { },
> };
>
> --
> 1.7.9.5
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI / video: Add Dell Inspiron 5737 to the blacklist
2014-07-08 13:31 ` Rafael J. Wysocki
@ 2014-07-08 15:04 ` Yidi Lin
2014-07-08 20:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Yidi Lin @ 2014-07-08 15:04 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Len Brown, linux-acpi
Hi,
This patch is for win8 backlight issue on Dell Inspiron 5737.
Do you mix up with the patch [1] which is for Dell Inspiron 7737 ?
[1] http://marc.info/?l=linux-acpi&m=139950526523173&w=2
On Tue, Jul 8, 2014 at 9:31 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, July 08, 2014 10:14:59 AM Yidi Lin wrote:
>> With win8 capability, the ACPI backlight control is broken on this model.
>> The system also loses backlight setting when resuming from S3.
>>
>> Add this model to the the ACPI video detect blacklist to make backlight
>> functionality work.
>>
>> Although backlight functionality works via video.use_native_backlight=1,
>> this approach may be safer.
>>
>> Signed-off-by: Edward Lin <yidi.lin@canonical.com>
>
> I've applied this patch already it seems, haven't I?
>
>> ---
>> drivers/acpi/video_detect.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
>> index 33e3db5..c42feb2 100644
>> --- a/drivers/acpi/video_detect.c
>> +++ b/drivers/acpi/video_detect.c
>> @@ -166,6 +166,14 @@ static struct dmi_system_id video_detect_dmi_table[] = {
>> DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
>> },
>> },
>> + {
>> + .callback = video_detect_force_vendor,
>> + .ident = "Dell Inspiron 5737",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"),
>> + },
>> + },
>> { },
>> };
>>
>> --
>> 1.7.9.5
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI / video: Add Dell Inspiron 5737 to the blacklist
2014-07-08 15:04 ` Yidi Lin
@ 2014-07-08 20:38 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2014-07-08 20:38 UTC (permalink / raw)
To: Yidi Lin; +Cc: Len Brown, linux-acpi
On Tuesday, July 08, 2014 11:04:32 PM Yidi Lin wrote:
> Hi,
> This patch is for win8 backlight issue on Dell Inspiron 5737.
Yes.
> Do you mix up with the patch [1] which is for Dell Inspiron 7737 ?
>
> [1] http://marc.info/?l=linux-acpi&m=139950526523173&w=2
No.
Please check the linux-next branch of linux-pm.git.
> On Tue, Jul 8, 2014 at 9:31 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Tuesday, July 08, 2014 10:14:59 AM Yidi Lin wrote:
> >> With win8 capability, the ACPI backlight control is broken on this model.
> >> The system also loses backlight setting when resuming from S3.
> >>
> >> Add this model to the the ACPI video detect blacklist to make backlight
> >> functionality work.
> >>
> >> Although backlight functionality works via video.use_native_backlight=1,
> >> this approach may be safer.
> >>
> >> Signed-off-by: Edward Lin <yidi.lin@canonical.com>
> >
> > I've applied this patch already it seems, haven't I?
> >
> >> ---
> >> drivers/acpi/video_detect.c | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> >> index 33e3db5..c42feb2 100644
> >> --- a/drivers/acpi/video_detect.c
> >> +++ b/drivers/acpi/video_detect.c
> >> @@ -166,6 +166,14 @@ static struct dmi_system_id video_detect_dmi_table[] = {
> >> DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
> >> },
> >> },
> >> + {
> >> + .callback = video_detect_force_vendor,
> >> + .ident = "Dell Inspiron 5737",
> >> + .matches = {
> >> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> >> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"),
> >> + },
> >> + },
> >> { },
> >> };
> >>
> >> --
> >> 1.7.9.5
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> > --
> > I speak only for myself.
> > Rafael J. Wysocki, Intel Open Source Technology Center.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ACPI / video: Add Dell Inspiron 5737 to the blacklist
@ 2014-06-20 8:13 Edward Lin
0 siblings, 0 replies; 5+ messages in thread
From: Edward Lin @ 2014-06-20 8:13 UTC (permalink / raw)
To: rjw, lenb, linux-acpi; +Cc: yidi.lin
With win8 capabiltiy, the ACPI backlight control is broken.
The system also loses backlight setting when resuming from S3.
Add this model to the the ACPI video detect blacklist to make backlight
functionality work.
Although backlight functionality works via video.use_native_backlight=1,
this approach may be safer.
Signed-off-by: Edward Lin <yidi.lin@canonical.com>
---
drivers/acpi/video_detect.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 33e3db5..c42feb2 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -166,6 +166,14 @@ static struct dmi_system_id video_detect_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
},
},
+ {
+ .callback = video_detect_force_vendor,
+ .ident = "Dell Inspiron 5737",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"),
+ },
+ },
{ },
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-08 20:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-08 2:14 [PATCH] ACPI / video: Add Dell Inspiron 5737 to the blacklist Yidi Lin
2014-07-08 13:31 ` Rafael J. Wysocki
2014-07-08 15:04 ` Yidi Lin
2014-07-08 20:38 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2014-06-20 8:13 Edward Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.