From: Jann Horn <jannh@google.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-aio@kvack.org, linux-block@vger.kernel.org, Linux API <linux-api@vger.kernel.org>, hch@lst.de, jmoyer@redhat.com, Avi Kivity <avi@scylladb.com>, Al Viro <viro@zeniv.linux.org.uk> Subject: Re: [PATCH 06/19] io_uring: add fsync support Date: Fri, 8 Feb 2019 23:36:32 +0100 [thread overview] Message-ID: <CAG48ez1zUf9GqZyoD3XEEYyeg2zrBSAO5uKT3MKHOPMk6eujDQ@mail.gmail.com> (raw) In-Reply-To: <20190208173423.27014-7-axboe@kernel.dk> On Fri, Feb 8, 2019 at 6:34 PM Jens Axboe <axboe@kernel.dk> wrote: > From: Christoph Hellwig <hch@lst.de> > > Add a new fsync opcode, which either syncs a range if one is passed, > or the whole file if the offset and length fields are both cleared > to zero. A flag is provided to use fdatasync semantics, that is only > force out metadata which is required to retrieve the file data, but > not others like metadata. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Jens Axboe <axboe@kernel.dk> > --- [...] > +static int io_fsync(struct io_kiocb *req, const struct io_uring_sqe *sqe, > + bool force_nonblock) > +{ > + struct io_ring_ctx *ctx = req->ctx; > + loff_t sqe_off = READ_ONCE(sqe->off); > + loff_t sqe_len = READ_ONCE(sqe->len); > + loff_t end = sqe_off + sqe_len; > + unsigned fsync_flags; > + struct file *file; > + int ret, fd; > + > + /* fsync always requires a blocking context */ > + if (force_nonblock) > + return -EAGAIN; > + > + if (unlikely(sqe->addr || sqe->ioprio)) > + return -EINVAL; > + > + fsync_flags = READ_ONCE(sqe->fsync_flags); > + if (unlikely(fsync_flags & ~IORING_FSYNC_DATASYNC)) > + return -EINVAL; > + > + fd = READ_ONCE(sqe->fd); > + file = fget(fd); This always runs on the workqueue, right? Is it possible to call fget() on a workqueue? > + if (unlikely(!file)) > + return -EBADF; > + > + ret = vfs_fsync_range(file, sqe_off, end > 0 ? end : LLONG_MAX, > + fsync_flags & IORING_FSYNC_DATASYNC); > + > + fput(file); > + io_cqring_add_event(ctx, sqe->user_data, ret, 0); > + io_free_req(req); > + return 0; > +}
WARNING: multiple messages have this Message-ID (diff)
From: Jann Horn <jannh@google.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-aio@kvack.org, linux-block@vger.kernel.org, Linux API <linux-api@vger.kernel.org>, hch@lst.de, jmoyer@redhat.com, Avi Kivity <avi@scylladb.com>, Al Viro <viro@zeniv.linux.org.uk> Subject: Re: [PATCH 06/19] io_uring: add fsync support Date: Fri, 8 Feb 2019 23:36:32 +0100 [thread overview] Message-ID: <CAG48ez1zUf9GqZyoD3XEEYyeg2zrBSAO5uKT3MKHOPMk6eujDQ@mail.gmail.com> (raw) In-Reply-To: <20190208173423.27014-7-axboe@kernel.dk> On Fri, Feb 8, 2019 at 6:34 PM Jens Axboe <axboe@kernel.dk> wrote: > From: Christoph Hellwig <hch@lst.de> > > Add a new fsync opcode, which either syncs a range if one is passed, > or the whole file if the offset and length fields are both cleared > to zero. A flag is provided to use fdatasync semantics, that is only > force out metadata which is required to retrieve the file data, but > not others like metadata. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Jens Axboe <axboe@kernel.dk> > --- [...] > +static int io_fsync(struct io_kiocb *req, const struct io_uring_sqe *sqe, > + bool force_nonblock) > +{ > + struct io_ring_ctx *ctx = req->ctx; > + loff_t sqe_off = READ_ONCE(sqe->off); > + loff_t sqe_len = READ_ONCE(sqe->len); > + loff_t end = sqe_off + sqe_len; > + unsigned fsync_flags; > + struct file *file; > + int ret, fd; > + > + /* fsync always requires a blocking context */ > + if (force_nonblock) > + return -EAGAIN; > + > + if (unlikely(sqe->addr || sqe->ioprio)) > + return -EINVAL; > + > + fsync_flags = READ_ONCE(sqe->fsync_flags); > + if (unlikely(fsync_flags & ~IORING_FSYNC_DATASYNC)) > + return -EINVAL; > + > + fd = READ_ONCE(sqe->fd); > + file = fget(fd); This always runs on the workqueue, right? Is it possible to call fget() on a workqueue? > + if (unlikely(!file)) > + return -EBADF; > + > + ret = vfs_fsync_range(file, sqe_off, end > 0 ? end : LLONG_MAX, > + fsync_flags & IORING_FSYNC_DATASYNC); > + > + fput(file); > + io_cqring_add_event(ctx, sqe->user_data, ret, 0); > + io_free_req(req); > + return 0; > +} -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2019-02-08 22:37 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-08 17:34 [PATCHSET v13] io_uring IO interface Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-08 17:34 ` [PATCH 01/19] fs: add an iopoll method to struct file_operations Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:20 ` Hannes Reinecke 2019-02-09 9:20 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 02/19] block: wire up block device iopoll method Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:22 ` Hannes Reinecke 2019-02-09 9:22 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 03/19] block: add bio_set_polled() helper Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:24 ` Hannes Reinecke 2019-02-09 9:24 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 04/19] iomap: wire up the iopoll method Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:25 ` Hannes Reinecke 2019-02-09 9:25 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 05/19] Add io_uring IO interface Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-08 22:12 ` Jann Horn 2019-02-08 22:12 ` Jann Horn 2019-02-09 4:15 ` Jens Axboe 2019-02-09 4:15 ` Jens Axboe 2019-02-12 21:42 ` Jann Horn 2019-02-12 21:42 ` Jann Horn 2019-02-12 22:03 ` Jens Axboe 2019-02-12 22:03 ` Jens Axboe 2019-02-12 22:06 ` Jens Axboe 2019-02-12 22:06 ` Jens Axboe 2019-02-12 22:40 ` Jann Horn 2019-02-12 22:40 ` Jann Horn 2019-02-12 22:45 ` Jens Axboe 2019-02-12 22:45 ` Jens Axboe 2019-02-12 22:52 ` Jens Axboe 2019-02-12 22:52 ` Jens Axboe 2019-02-12 22:57 ` Jann Horn 2019-02-12 22:57 ` Jann Horn 2019-02-12 23:00 ` Jens Axboe 2019-02-12 23:00 ` Jens Axboe 2019-02-12 23:11 ` Jann Horn 2019-02-12 23:11 ` Jann Horn 2019-02-12 23:19 ` Jens Axboe 2019-02-12 23:19 ` Jens Axboe 2019-02-12 23:28 ` Jann Horn 2019-02-12 23:28 ` Jann Horn 2019-02-12 23:46 ` Jens Axboe 2019-02-12 23:46 ` Jens Axboe 2019-02-12 23:53 ` Jens Axboe 2019-02-12 23:53 ` Jens Axboe 2019-02-13 0:07 ` Andy Lutomirski 2019-02-13 0:07 ` Andy Lutomirski 2019-02-13 0:14 ` Jann Horn 2019-02-13 0:14 ` Jann Horn 2019-02-13 0:24 ` Jens Axboe 2019-02-13 0:24 ` Jens Axboe 2019-02-09 9:35 ` Hannes Reinecke 2019-02-09 9:35 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 06/19] io_uring: add fsync support Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-08 22:36 ` Jann Horn [this message] 2019-02-08 22:36 ` Jann Horn 2019-02-08 23:31 ` Jens Axboe 2019-02-08 23:31 ` Jens Axboe 2019-02-09 9:37 ` Hannes Reinecke 2019-02-09 9:37 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 07/19] io_uring: support for IO polling Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:39 ` Hannes Reinecke 2019-02-09 9:39 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 08/19] fs: add fget_many() and fput_many() Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:41 ` Hannes Reinecke 2019-02-09 9:41 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 09/19] io_uring: use fget/fput_many() for file references Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:42 ` Hannes Reinecke 2019-02-09 9:42 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 10/19] io_uring: batch io_kiocb allocation Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:43 ` Hannes Reinecke 2019-02-09 9:43 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:45 ` Hannes Reinecke 2019-02-09 9:45 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 12/19] io_uring: add support for pre-mapped user IO buffers Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-08 22:54 ` Jann Horn 2019-02-08 22:54 ` Jann Horn 2019-02-08 23:38 ` Jens Axboe 2019-02-08 23:38 ` Jens Axboe 2019-02-09 16:50 ` Jens Axboe 2019-02-09 16:50 ` Jens Axboe 2019-02-09 9:48 ` Hannes Reinecke 2019-02-09 9:48 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 13/19] net: split out functions related to registering inflight socket files Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-08 19:49 ` David Miller 2019-02-08 19:49 ` David Miller 2019-02-08 19:51 ` Jens Axboe 2019-02-09 9:49 ` Hannes Reinecke 2019-02-09 9:49 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 14/19] io_uring: add file set registration Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-08 20:26 ` Jann Horn 2019-02-08 20:26 ` Jann Horn 2019-02-09 0:16 ` Jens Axboe 2019-02-09 0:16 ` Jens Axboe 2019-02-09 9:50 ` Hannes Reinecke 2019-02-09 9:50 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 15/19] io_uring: add submission polling Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:53 ` Hannes Reinecke 2019-02-09 9:53 ` Hannes Reinecke 2019-02-08 17:34 ` [PATCH 16/19] io_uring: add io_kiocb ref count Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-08 17:34 ` [PATCH 17/19] io_uring: add support for IORING_OP_POLL Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-08 17:34 ` [PATCH 18/19] io_uring: allow workqueue item to handle multiple buffered requests Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-08 17:34 ` [PATCH 19/19] io_uring: add io_uring_event cache hit information Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 21:13 [PATCHSET v14] io_uring IO interface Jens Axboe 2019-02-09 21:13 ` [PATCH 06/19] io_uring: add fsync support Jens Axboe 2019-02-09 21:13 ` Jens Axboe 2019-02-11 19:00 [PATCHSET v15] io_uring IO interface Jens Axboe 2019-02-11 19:00 ` [PATCH 06/19] io_uring: add fsync support Jens Axboe 2019-02-11 19:00 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAG48ez1zUf9GqZyoD3XEEYyeg2zrBSAO5uKT3MKHOPMk6eujDQ@mail.gmail.com \ --to=jannh@google.com \ --cc=avi@scylladb.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=jmoyer@redhat.com \ --cc=linux-aio@kvack.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.