From: Alim Akhtar <alim.akhtar@gmail.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Cc: Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, open list <linux-kernel@vger.kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com>, Sylwester Nawrocki <snawrocki@kernel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, Alim Akhtar <alim.akhtar@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Pankaj Dubey <pankaj.dubey@samsung.com> Subject: Re: [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module! Date: Sun, 19 Sep 2021 23:02:14 +0530 [thread overview] Message-ID: <CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com> (raw) In-Reply-To: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> Hello Krzysztof On Sun, Sep 19, 2021 at 6:28 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Hi, > > Changes since v1 > ================ > 1. Drop patch 1/2 - exporting soc_device_to_device > 2. Add new patches: 1/3 and 3/3. > > Question > ======== > > A question - what is the convention for naming modules: underscores '_' or > hyphens '-'? > > The C-unit file already uses a hyphen "exynos-chipid.c", so I could > create a module named: > 1. exynos_chipid > 2. soc-exynos-chipid > 3. exynos-chip-id > > The Linux device name is "exynos-chipid". > > Best regards, > Krzysztof > > > Krzysztof Kozlowski (3): > soc: samsung: exynos-chipid: avoid soc_device_to_device() > soc: samsung: exynos-chipid: convert to a module > soc: samsung: exynos-chipid: do not enforce built-in > > arch/arm/mach-exynos/Kconfig | 1 - > drivers/soc/samsung/Kconfig | 4 +++- > drivers/soc/samsung/Makefile | 3 ++- > drivers/soc/samsung/exynos-chipid.c | 14 +++++++++++--- > drivers/soc/samsung/exynos5422-asv.c | 1 + > 5 files changed, 17 insertions(+), 6 deletions(-) > Thanks for the patches. For this series Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> Also tested on exynos7 based platform, so Tested-by: Alim Akhtar <alim.akhtar@samsung.com> > -- > 2.30.2 > -- Regards, Alim
WARNING: multiple messages have this Message-ID (diff)
From: Alim Akhtar <alim.akhtar@gmail.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Cc: Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, open list <linux-kernel@vger.kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com>, Sylwester Nawrocki <snawrocki@kernel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, Alim Akhtar <alim.akhtar@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Pankaj Dubey <pankaj.dubey@samsung.com> Subject: Re: [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module! Date: Sun, 19 Sep 2021 23:02:14 +0530 [thread overview] Message-ID: <CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com> (raw) In-Reply-To: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> Hello Krzysztof On Sun, Sep 19, 2021 at 6:28 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Hi, > > Changes since v1 > ================ > 1. Drop patch 1/2 - exporting soc_device_to_device > 2. Add new patches: 1/3 and 3/3. > > Question > ======== > > A question - what is the convention for naming modules: underscores '_' or > hyphens '-'? > > The C-unit file already uses a hyphen "exynos-chipid.c", so I could > create a module named: > 1. exynos_chipid > 2. soc-exynos-chipid > 3. exynos-chip-id > > The Linux device name is "exynos-chipid". > > Best regards, > Krzysztof > > > Krzysztof Kozlowski (3): > soc: samsung: exynos-chipid: avoid soc_device_to_device() > soc: samsung: exynos-chipid: convert to a module > soc: samsung: exynos-chipid: do not enforce built-in > > arch/arm/mach-exynos/Kconfig | 1 - > drivers/soc/samsung/Kconfig | 4 +++- > drivers/soc/samsung/Makefile | 3 ++- > drivers/soc/samsung/exynos-chipid.c | 14 +++++++++++--- > drivers/soc/samsung/exynos5422-asv.c | 1 + > 5 files changed, 17 insertions(+), 6 deletions(-) > Thanks for the patches. For this series Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> Also tested on exynos7 based platform, so Tested-by: Alim Akhtar <alim.akhtar@samsung.com> > -- > 2.30.2 > -- Regards, Alim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-19 17:32 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-19 9:31 [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module! Krzysztof Kozlowski 2021-09-19 9:31 ` Krzysztof Kozlowski 2021-09-19 9:31 ` [PATCH v2 1/3] soc: samsung: exynos-chipid: avoid soc_device_to_device() Krzysztof Kozlowski 2021-09-19 9:31 ` Krzysztof Kozlowski 2021-10-05 12:06 ` Sam Protsenko 2021-10-05 12:06 ` Sam Protsenko 2021-09-19 9:31 ` [PATCH v2 2/3] soc: samsung: exynos-chipid: convert to a module Krzysztof Kozlowski 2021-09-19 9:31 ` Krzysztof Kozlowski 2021-10-05 12:07 ` Sam Protsenko 2021-10-05 12:07 ` Sam Protsenko 2021-09-19 9:31 ` [PATCH v2 3/3] soc: samsung: exynos-chipid: do not enforce built-in Krzysztof Kozlowski 2021-09-19 9:31 ` Krzysztof Kozlowski 2021-10-05 12:10 ` Sam Protsenko 2021-10-05 12:10 ` Sam Protsenko 2021-09-19 17:32 ` Alim Akhtar [this message] 2021-09-19 17:32 ` [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module! Alim Akhtar 2021-09-21 10:03 ` Sylwester Nawrocki 2021-09-21 10:03 ` Sylwester Nawrocki 2021-09-29 13:58 ` Krzysztof Kozlowski 2021-09-29 13:58 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com' \ --to=alim.akhtar@gmail.com \ --cc=alim.akhtar@samsung.com \ --cc=arnd@arndb.de \ --cc=b.zolnierkie@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=m.szyprowski@samsung.com \ --cc=olof@lixom.net \ --cc=pankaj.dubey@samsung.com \ --cc=snawrocki@kernel.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.