From: Alim Akhtar <alim.akhtar@gmail.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Cc: Tomasz Figa <tomasz.figa@gmail.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, open list <linux-kernel@vger.kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com>, Sylwester Nawrocki <snawrocki@kernel.org>, Sam Protsenko <semen.protsenko@linaro.org>, Chanho Park <chanho61.park@samsung.com> Subject: Re: [PATCH 07/24] ARM: dts: exynos: override pins by label in Peach Pi Date: Fri, 7 Jan 2022 00:14:42 +0530 [thread overview] Message-ID: <CAGOxZ51cEZ2SV=GYdjFEFFhKqp0+KxWcmA0VJx7C1z=UdFqW=Q@mail.gmail.com> (raw) In-Reply-To: <20211231162207.257478-1-krzysztof.kozlowski@canonical.com> Hi Krzysztof, On Sat, Jan 1, 2022 at 1:15 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Using node paths to extend or override a device tree node is error > prone. If there was a typo error, a new node will be created instead of > extending the existing node. This will lead to run-time errors that > could be hard to detect. > > A mistyped label on the other hand, will cause a dtc compile error > (during build time). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > arch/arm/boot/dts/exynos5800-peach-pi.dts | 33 +++++++++++------------ > 1 file changed, 16 insertions(+), 17 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 77013ee586f8..6bf3fd37fb2b 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -850,27 +850,26 @@ pmic_dvs_1: pmic-dvs-1 { > }; > }; > > -&pinctrl_1 { > - /* Adjust WiFi drive strengths lower for EMI */ > - sd1_clk: sd1-clk { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +/* pinctrl_1 */ > +/* Adjust WiFi drive strengths lower for EMI */ > +&sd1_bus1 { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_cmd: sd1-cmd { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_bus4 { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_bus1: sd1-bus-width1 { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_bus8 { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_bus4: sd1-bus-width4 { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_clk { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_bus8: sd1-bus-width8 { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_cmd { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > }; > > &pinctrl_2 { > -- > 2.32.0 > -- Regards, Alim
WARNING: multiple messages have this Message-ID (diff)
From: Alim Akhtar <alim.akhtar@gmail.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Cc: Tomasz Figa <tomasz.figa@gmail.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, open list <linux-kernel@vger.kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com>, Sylwester Nawrocki <snawrocki@kernel.org>, Sam Protsenko <semen.protsenko@linaro.org>, Chanho Park <chanho61.park@samsung.com> Subject: Re: [PATCH 07/24] ARM: dts: exynos: override pins by label in Peach Pi Date: Fri, 7 Jan 2022 00:14:42 +0530 [thread overview] Message-ID: <CAGOxZ51cEZ2SV=GYdjFEFFhKqp0+KxWcmA0VJx7C1z=UdFqW=Q@mail.gmail.com> (raw) In-Reply-To: <20211231162207.257478-1-krzysztof.kozlowski@canonical.com> Hi Krzysztof, On Sat, Jan 1, 2022 at 1:15 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Using node paths to extend or override a device tree node is error > prone. If there was a typo error, a new node will be created instead of > extending the existing node. This will lead to run-time errors that > could be hard to detect. > > A mistyped label on the other hand, will cause a dtc compile error > (during build time). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > arch/arm/boot/dts/exynos5800-peach-pi.dts | 33 +++++++++++------------ > 1 file changed, 16 insertions(+), 17 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 77013ee586f8..6bf3fd37fb2b 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -850,27 +850,26 @@ pmic_dvs_1: pmic-dvs-1 { > }; > }; > > -&pinctrl_1 { > - /* Adjust WiFi drive strengths lower for EMI */ > - sd1_clk: sd1-clk { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +/* pinctrl_1 */ > +/* Adjust WiFi drive strengths lower for EMI */ > +&sd1_bus1 { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_cmd: sd1-cmd { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_bus4 { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_bus1: sd1-bus-width1 { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_bus8 { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_bus4: sd1-bus-width4 { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_clk { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > +}; > > - sd1_bus8: sd1-bus-width8 { > - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > - }; > +&sd1_cmd { > + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; > }; > > &pinctrl_2 { > -- > 2.32.0 > -- Regards, Alim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-06 18:45 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-31 16:19 [PATCH 00/24] pinctrl: dt-bindings: samsung: convert to dtschema Krzysztof Kozlowski 2021-12-31 16:19 ` Krzysztof Kozlowski 2021-12-31 16:19 ` [PATCH 01/24] pinctrl: samsung: drop pin banks references on error paths Krzysztof Kozlowski 2021-12-31 16:19 ` Krzysztof Kozlowski 2022-01-03 14:49 ` Sam Protsenko 2022-01-03 14:49 ` Sam Protsenko 2022-01-05 20:24 ` Krzysztof Kozlowski 2022-01-05 20:24 ` Krzysztof Kozlowski 2021-12-31 16:19 ` [PATCH 02/24] pinctrl: samsung: accept GPIO bank nodes with a suffix Krzysztof Kozlowski 2021-12-31 16:19 ` Krzysztof Kozlowski 2022-01-03 18:43 ` Sam Protsenko 2022-01-03 18:43 ` Sam Protsenko 2022-01-05 20:31 ` Krzysztof Kozlowski 2022-01-05 20:31 ` Krzysztof Kozlowski 2021-12-31 16:19 ` [PATCH 03/24] ARM: dts: exynos: drop unused pinctrl defines in Exynos3250 Krzysztof Kozlowski 2021-12-31 16:19 ` Krzysztof Kozlowski 2022-01-06 18:20 ` Alim Akhtar 2022-01-06 18:20 ` Alim Akhtar 2021-12-31 16:19 ` [PATCH 04/24] ARM: dts: exynos: simplify PMIC DVS pin configuration in Odroid XU Krzysztof Kozlowski 2021-12-31 16:19 ` Krzysztof Kozlowski 2021-12-31 16:19 ` [PATCH 05/24] ARM: dts: exynos: override pins by label in Peach Pit Krzysztof Kozlowski 2021-12-31 16:19 ` Krzysztof Kozlowski 2022-01-06 18:42 ` Alim Akhtar 2022-01-06 18:42 ` Alim Akhtar 2021-12-31 16:19 ` [PATCH 06/24] ARM: dts: exynos: simplify PMIC DVS pin configuration " Krzysztof Kozlowski 2021-12-31 16:19 ` Krzysztof Kozlowski 2021-12-31 16:21 ` [PATCH 07/24] ARM: dts: exynos: override pins by label in Peach Pi Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2022-01-06 18:44 ` Alim Akhtar [this message] 2022-01-06 18:44 ` Alim Akhtar 2021-12-31 16:21 ` [PATCH 08/24] ARM: dts: exynos: simplify PMIC DVS pin configuration " Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2022-01-06 18:47 ` Alim Akhtar 2022-01-06 18:47 ` Alim Akhtar 2022-01-07 7:34 ` Krzysztof Kozlowski 2022-01-07 7:34 ` Krzysztof Kozlowski 2021-12-31 16:21 ` [PATCH 09/24] ARM: dts: s3c64xx: drop unneeded pinctrl wake-up interrupt mapping Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2021-12-31 16:21 ` [PATCH 10/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos3250 Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2021-12-31 16:21 ` [PATCH 11/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos4210 Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2021-12-31 16:21 ` [PATCH 12/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos4412 Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2021-12-31 16:21 ` [PATCH 13/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos5250 Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2021-12-31 16:21 ` [PATCH 14/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos5260 Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2021-12-31 16:21 ` [PATCH 15/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos5410 Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2021-12-31 16:21 ` [PATCH 16/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos542x/5800 Krzysztof Kozlowski 2021-12-31 16:21 ` Krzysztof Kozlowski 2021-12-31 16:22 ` [PATCH 17/24] arm64: dts: exynos: align pinctrl with dtschema in Exynos5433 Krzysztof Kozlowski 2021-12-31 16:22 ` Krzysztof Kozlowski 2021-12-31 16:23 ` [PATCH 18/24] arm64: dts: exynos: align pinctrl with dtschema in Exynos7 Krzysztof Kozlowski 2021-12-31 16:23 ` Krzysztof Kozlowski 2021-12-31 16:23 ` [PATCH 19/24] arm64: dts: exynos: align pinctrl with dtschema in Exynos850 Krzysztof Kozlowski 2021-12-31 16:23 ` Krzysztof Kozlowski 2022-01-03 14:45 ` Sam Protsenko 2022-01-03 14:45 ` Sam Protsenko 2021-12-31 16:23 ` [PATCH 20/24] arm64: dts: exynos: align pinctrl with dtschema in ExynosAutov9 Krzysztof Kozlowski 2021-12-31 16:23 ` Krzysztof Kozlowski 2021-12-31 16:23 ` [PATCH 21/24] ARM: dts: s3c24xx: align pinctrl with dtschema Krzysztof Kozlowski 2021-12-31 16:23 ` Krzysztof Kozlowski 2021-12-31 16:23 ` [PATCH 22/24] ARM: dts: s3c64xx: " Krzysztof Kozlowski 2021-12-31 16:23 ` Krzysztof Kozlowski 2021-12-31 16:23 ` [PATCH 23/24] ARM: dts: s5pv210: " Krzysztof Kozlowski 2021-12-31 16:23 ` Krzysztof Kozlowski 2021-12-31 16:23 ` [PATCH 24/24] dt-bindings: pinctrl: samsung: convert to dtschema Krzysztof Kozlowski 2021-12-31 16:23 ` Krzysztof Kozlowski 2022-01-03 21:19 ` Sam Protsenko 2022-01-03 21:19 ` Sam Protsenko 2022-01-10 20:43 ` Rob Herring 2022-01-10 20:43 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGOxZ51cEZ2SV=GYdjFEFFhKqp0+KxWcmA0VJx7C1z=UdFqW=Q@mail.gmail.com' \ --to=alim.akhtar@gmail.com \ --cc=chanho61.park@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=semen.protsenko@linaro.org \ --cc=snawrocki@kernel.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.