From: Chen-Yu Tsai <wenst@chromium.org>
To: Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
linux-rockchip@lists.infradead.org, Lin Huang <hl@rock-chips.com>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
Sandy Huang <hjc@rock-chips.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output
Date: Mon, 17 Jan 2022 15:44:37 +0800 [thread overview]
Message-ID: <CAGXv+5H0-dM28YQj_orS1_14NLcJve8VtO6oLcBiRpJFjaf5KA@mail.gmail.com> (raw)
In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid>
On Sat, Jan 15, 2022 at 7:03 AM Brian Norris <briannorris@chromium.org> wrote:
>
> Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> switched the platform to SPDIF, but we didn't fix up the device tree.
>
> Drop the pinctrl settings, because the 'spdif_bus' pins are either:
> * unused (on kevin, bob), so the settings is ~harmless
> * used by a different function (on scarlet), which causes probe
> failures (!!)
I suppose that means the default pinctrl should be dropped? Or maybe this
use case is the outlier. Up to Heiko?
> Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wenst@chromium.org>
To: Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
linux-rockchip@lists.infradead.org,
Lin Huang <hl@rock-chips.com>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Sandy Huang <hjc@rock-chips.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output
Date: Mon, 17 Jan 2022 15:44:37 +0800 [thread overview]
Message-ID: <CAGXv+5H0-dM28YQj_orS1_14NLcJve8VtO6oLcBiRpJFjaf5KA@mail.gmail.com> (raw)
In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid>
On Sat, Jan 15, 2022 at 7:03 AM Brian Norris <briannorris@chromium.org> wrote:
>
> Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> switched the platform to SPDIF, but we didn't fix up the device tree.
>
> Drop the pinctrl settings, because the 'spdif_bus' pins are either:
> * unused (on kevin, bob), so the settings is ~harmless
> * used by a different function (on scarlet), which causes probe
> failures (!!)
I suppose that means the default pinctrl should be dropped? Or maybe this
use case is the outlier. Up to Heiko?
> Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wenst@chromium.org>
To: Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Lin Huang <hl@rock-chips.com>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org, Sandy Huang <hjc@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output
Date: Mon, 17 Jan 2022 15:44:37 +0800 [thread overview]
Message-ID: <CAGXv+5H0-dM28YQj_orS1_14NLcJve8VtO6oLcBiRpJFjaf5KA@mail.gmail.com> (raw)
In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid>
On Sat, Jan 15, 2022 at 7:03 AM Brian Norris <briannorris@chromium.org> wrote:
>
> Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> switched the platform to SPDIF, but we didn't fix up the device tree.
>
> Drop the pinctrl settings, because the 'spdif_bus' pins are either:
> * unused (on kevin, bob), so the settings is ~harmless
> * used by a different function (on scarlet), which causes probe
> failures (!!)
I suppose that means the default pinctrl should be dropped? Or maybe this
use case is the outlier. Up to Heiko?
> Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wenst@chromium.org>
To: Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Lin Huang <hl@rock-chips.com>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org, Sandy Huang <hjc@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Mark Brown <broonie@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output
Date: Mon, 17 Jan 2022 15:44:37 +0800 [thread overview]
Message-ID: <CAGXv+5H0-dM28YQj_orS1_14NLcJve8VtO6oLcBiRpJFjaf5KA@mail.gmail.com> (raw)
In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid>
On Sat, Jan 15, 2022 at 7:03 AM Brian Norris <briannorris@chromium.org> wrote:
>
> Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> switched the platform to SPDIF, but we didn't fix up the device tree.
>
> Drop the pinctrl settings, because the 'spdif_bus' pins are either:
> * unused (on kevin, bob), so the settings is ~harmless
> * used by a different function (on scarlet), which causes probe
> failures (!!)
I suppose that means the default pinctrl should be dropped? Or maybe this
use case is the outlier. Up to Heiko?
> Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wenst@chromium.org>
To: Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
linux-rockchip@lists.infradead.org,
Lin Huang <hl@rock-chips.com>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Sandy Huang <hjc@rock-chips.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output
Date: Mon, 17 Jan 2022 15:44:37 +0800 [thread overview]
Message-ID: <CAGXv+5H0-dM28YQj_orS1_14NLcJve8VtO6oLcBiRpJFjaf5KA@mail.gmail.com> (raw)
In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid>
On Sat, Jan 15, 2022 at 7:03 AM Brian Norris <briannorris@chromium.org> wrote:
>
> Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> switched the platform to SPDIF, but we didn't fix up the device tree.
>
> Drop the pinctrl settings, because the 'spdif_bus' pins are either:
> * unused (on kevin, bob), so the settings is ~harmless
> * used by a different function (on scarlet), which causes probe
> failures (!!)
I suppose that means the default pinctrl should be dropped? Or maybe this
use case is the outlier. Up to Heiko?
> Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-17 7:44 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 23:02 [PATCH v2 0/3] (Re)enable DP/HDMI audio for RK3399 Gru Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-14 23:02 ` [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-17 7:44 ` Chen-Yu Tsai [this message]
2022-01-17 7:44 ` Chen-Yu Tsai
2022-01-17 7:44 ` Chen-Yu Tsai
2022-01-17 7:44 ` Chen-Yu Tsai
2022-01-17 7:44 ` Chen-Yu Tsai
2022-01-17 8:40 ` Heiko Stübner
2022-01-17 8:40 ` Heiko Stübner
2022-01-17 8:40 ` Heiko Stübner
2022-01-17 8:40 ` Heiko Stübner
2022-01-17 8:40 ` Heiko Stübner
2022-01-14 23:02 ` [PATCH v2 2/3] drm/rockchip: cdn-dp: Support HDMI codec plug-change callback Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-17 7:45 ` Chen-Yu Tsai
2022-01-17 7:45 ` Chen-Yu Tsai
2022-01-17 7:45 ` Chen-Yu Tsai
2022-01-17 7:45 ` Chen-Yu Tsai
2022-01-17 7:45 ` Chen-Yu Tsai
2022-01-14 23:02 ` [PATCH v2 3/3] ASoC: rk3399_gru_sound: Wire up DP jack detection Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-14 23:02 ` Brian Norris
2022-01-17 9:01 ` Chen-Yu Tsai
2022-01-17 9:01 ` Chen-Yu Tsai
2022-01-17 9:01 ` Chen-Yu Tsai
2022-01-17 9:01 ` Chen-Yu Tsai
2022-01-17 9:01 ` Chen-Yu Tsai
2022-01-18 20:17 ` Brian Norris
2022-01-18 20:17 ` Brian Norris
2022-01-18 20:17 ` Brian Norris
2022-01-18 20:17 ` Brian Norris
2022-01-18 20:17 ` Brian Norris
2022-01-19 5:59 ` Chen-Yu Tsai
2022-01-19 5:59 ` Chen-Yu Tsai
2022-01-19 5:59 ` Chen-Yu Tsai
2022-01-19 5:59 ` Chen-Yu Tsai
2022-01-19 5:59 ` Chen-Yu Tsai
2022-01-23 15:40 ` (subset) [PATCH v2 0/3] (Re)enable DP/HDMI audio for RK3399 Gru Heiko Stuebner
2022-01-23 15:40 ` Heiko Stuebner
2022-01-23 15:40 ` Heiko Stuebner
2022-01-23 15:40 ` Heiko Stuebner
2022-01-23 15:40 ` Heiko Stuebner
2022-01-28 23:46 ` Mark Brown
2022-01-28 23:46 ` Mark Brown
2022-01-28 23:46 ` Mark Brown
2022-01-28 23:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXv+5H0-dM28YQj_orS1_14NLcJve8VtO6oLcBiRpJFjaf5KA@mail.gmail.com \
--to=wenst@chromium.org \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.