All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Hans De Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
Date: Tue, 26 Apr 2016 22:18:04 +0800	[thread overview]
Message-ID: <CAGb2v648p8T5PqxZTyvoZsugcTM03-mqjNnwSZLXJq_KnErFdA@mail.gmail.com> (raw)
In-Reply-To: <1461679251-25538-1-git-send-email-maxime.ripard@free-electrons.com>

On Tue, Apr 26, 2016 at 10:00 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The current linear voltage range for the LDO4 regulator found in the APX20X
> PMICs assumes that the voltage is linear between 2.5 and 3.1V.
>
> However, the PMIC can output up to 3.3V on that regulator by skipping the
> 2.6V and 2.9V steps.
>
> Fix the ranges to read and set the proper voltages.
>
> Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4")
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

Hans sent an identical patch (plus another fix) a month ago though.

> ---
> Hi Mark,
>
> This patch fixes a commit merged into 4.6-rc1, so it should probably go in
> the next -rc release.
>
> Thanks!
> Maxime
>
>  drivers/regulator/axp20x-regulator.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index 40cd894e4df5..29ab0985b46e 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c
> @@ -157,7 +157,9 @@ static struct regulator_ops axp20x_ops_sw = {
>  static const struct regulator_linear_range axp20x_ldo4_ranges[] = {
>         REGULATOR_LINEAR_RANGE(1250000, 0x0, 0x0, 0),
>         REGULATOR_LINEAR_RANGE(1300000, 0x1, 0x8, 100000),
> -       REGULATOR_LINEAR_RANGE(2500000, 0x9, 0xf, 100000),
> +       REGULATOR_LINEAR_RANGE(2500000, 0x9, 0x9, 0),
> +       REGULATOR_LINEAR_RANGE(2700000, 0xa, 0xb, 100000),
> +       REGULATOR_LINEAR_RANGE(3000000, 0xc, 0xf, 100000),
>  };
>
>  static const struct regulator_desc axp20x_regulators[] = {
> --
> 2.8.1
>

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
Date: Tue, 26 Apr 2016 22:18:04 +0800	[thread overview]
Message-ID: <CAGb2v648p8T5PqxZTyvoZsugcTM03-mqjNnwSZLXJq_KnErFdA@mail.gmail.com> (raw)
In-Reply-To: <1461679251-25538-1-git-send-email-maxime.ripard@free-electrons.com>

On Tue, Apr 26, 2016 at 10:00 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The current linear voltage range for the LDO4 regulator found in the APX20X
> PMICs assumes that the voltage is linear between 2.5 and 3.1V.
>
> However, the PMIC can output up to 3.3V on that regulator by skipping the
> 2.6V and 2.9V steps.
>
> Fix the ranges to read and set the proper voltages.
>
> Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4")
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

Hans sent an identical patch (plus another fix) a month ago though.

> ---
> Hi Mark,
>
> This patch fixes a commit merged into 4.6-rc1, so it should probably go in
> the next -rc release.
>
> Thanks!
> Maxime
>
>  drivers/regulator/axp20x-regulator.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index 40cd894e4df5..29ab0985b46e 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c
> @@ -157,7 +157,9 @@ static struct regulator_ops axp20x_ops_sw = {
>  static const struct regulator_linear_range axp20x_ldo4_ranges[] = {
>         REGULATOR_LINEAR_RANGE(1250000, 0x0, 0x0, 0),
>         REGULATOR_LINEAR_RANGE(1300000, 0x1, 0x8, 100000),
> -       REGULATOR_LINEAR_RANGE(2500000, 0x9, 0xf, 100000),
> +       REGULATOR_LINEAR_RANGE(2500000, 0x9, 0x9, 0),
> +       REGULATOR_LINEAR_RANGE(2700000, 0xa, 0xb, 100000),
> +       REGULATOR_LINEAR_RANGE(3000000, 0xc, 0xf, 100000),
>  };
>
>  static const struct regulator_desc axp20x_regulators[] = {
> --
> 2.8.1
>

  reply	other threads:[~2016-04-26 14:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 14:00 [PATCH] regulator: axp20x: Fix LDO4 linear voltage range Maxime Ripard
2016-04-26 14:00 ` Maxime Ripard
2016-04-26 14:18 ` Chen-Yu Tsai [this message]
2016-04-26 14:18   ` Chen-Yu Tsai
2016-04-26 14:57   ` Mark Brown
2016-04-26 14:57     ` Mark Brown
2016-04-27  9:46     ` Hans de Goede
2016-04-27  9:46       ` Hans de Goede
2016-04-27 10:32       ` Mark Brown
2016-04-27 10:32         ` Mark Brown
2016-04-26 18:25 ` Applied "regulator: axp20x: Fix LDO4 linear voltage range" to the regulator tree Mark Brown
2016-04-26 18:25   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v648p8T5PqxZTyvoZsugcTM03-mqjNnwSZLXJq_KnErFdA@mail.gmail.com \
    --to=wens@csie.org \
    --cc=broonie@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.