From: Xinliang Liu <xinliang.liu@linaro.org> To: Xinliang Liu <xinliang.liu@linaro.org>, Peter Griffin <peter.griffin@linaro.org>, seanpaul@google.com, Guodong Xu <guodong.xu@linaro.org>, Feng Chen <puck.chen@hisilicon.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, "Liuxinliang (Matthew Liu)" <z.liuxinliang@hisilicon.com>, XinWei Kong <kong.kongxinwei@hisilicon.com>, stable@vger.kernel.org, Rongrong Zou <zourongrong@gmail.com>, Andrey Konovalov <andrey.konovalov@linaro.org>, LAKML <linux-arm-kernel@lists.infradead.org> Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured. Date: Mon, 28 Aug 2017 17:27:47 +0800 [thread overview] Message-ID: <CAGd==0558EHJFdh_+C=Zo11OJDNgbS-BOkj+TvbVKFJkU=gDHg@mail.gmail.com> (raw) In-Reply-To: <20170828085108.zp4pjkmt6gbewwgm@phenom.ffwll.local> Hi Daniel, On 28 August 2017 at 16:51, Daniel Vetter <daniel@ffwll.ch> wrote: > On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote: >> Hi, >> >> On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote: >> >> > This patch fixes the following soft lockup: >> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307] >> > >> > On weston idle-timeout the IP is powered down and reset >> > asserted. On weston resume we get a massive vblank >> > IRQ storm due to the LDI registers having lost some state. >> > >> > This state loss is caused by ade_crtc_atomic_begin() not >> > calling ade_ldi_set_mode(). With this patch applied >> > resuming from Weston idle-timeout works well. >> > >> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> >> > Tested-by: John Stultz <john.stultz@linaro.org> >> > >> >> Thanks Peter, >> This patch looks good to me. >> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org> >> >> @Sean, could you please help to apply to drm-misc if others has no more >> comments, thanks. > > hisilicon isn't maintained in drm-misc, and you're the maintainer. This is > not how it works. So either > a) pick up the patch and send out a pull request to Dave Airlie > b) move hisilicon over to drm-misc and become a drm-misc maintainer > yourself. This needs a MAINTAINERS update to point the git tree at > drm-misc. > > drm-misc maintainers don't maintain everyone else's driver as a service, > that simply doesn't scale. Sorry for my misunderstanding and thanks for pointing out that how drm-misc works. So I will pick up the patch and send a pull request. Thanks, Xinliang > > Thanks, Daniel > >> >> Thanks, >> Xinliang >> >> >> > Cc: stable@vger.kernel.org >> > --- >> > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> > b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> > index c96c228..72c6357 100644 >> > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> > @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc >> > *crtc, >> > { >> > struct ade_crtc *acrtc = to_ade_crtc(crtc); >> > struct ade_hw_ctx *ctx = acrtc->ctx; >> > + struct drm_display_mode *mode = &crtc->state->mode; >> > + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode; >> > >> > if (!ctx->power_on) >> > (void)ade_power_up(ctx); >> > + ade_ldi_set_mode(acrtc, mode, adj_mode); >> > } >> > >> > static void ade_crtc_atomic_flush(struct drm_crtc *crtc, >> > -- >> > 2.7.4 >> > >> > _______________________________________________ >> > dri-devel mailing list >> > dri-devel@lists.freedesktop.org >> > https://lists.freedesktop.org/mailman/listinfo/dri-devel >> > > >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: xinliang.liu@linaro.org (Xinliang Liu) To: linux-arm-kernel@lists.infradead.org Subject: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured. Date: Mon, 28 Aug 2017 17:27:47 +0800 [thread overview] Message-ID: <CAGd==0558EHJFdh_+C=Zo11OJDNgbS-BOkj+TvbVKFJkU=gDHg@mail.gmail.com> (raw) In-Reply-To: <20170828085108.zp4pjkmt6gbewwgm@phenom.ffwll.local> Hi Daniel, On 28 August 2017 at 16:51, Daniel Vetter <daniel@ffwll.ch> wrote: > On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote: >> Hi, >> >> On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote: >> >> > This patch fixes the following soft lockup: >> > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307] >> > >> > On weston idle-timeout the IP is powered down and reset >> > asserted. On weston resume we get a massive vblank >> > IRQ storm due to the LDI registers having lost some state. >> > >> > This state loss is caused by ade_crtc_atomic_begin() not >> > calling ade_ldi_set_mode(). With this patch applied >> > resuming from Weston idle-timeout works well. >> > >> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> >> > Tested-by: John Stultz <john.stultz@linaro.org> >> > >> >> Thanks Peter, >> This patch looks good to me. >> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org> >> >> @Sean, could you please help to apply to drm-misc if others has no more >> comments, thanks. > > hisilicon isn't maintained in drm-misc, and you're the maintainer. This is > not how it works. So either > a) pick up the patch and send out a pull request to Dave Airlie > b) move hisilicon over to drm-misc and become a drm-misc maintainer > yourself. This needs a MAINTAINERS update to point the git tree at > drm-misc. > > drm-misc maintainers don't maintain everyone else's driver as a service, > that simply doesn't scale. Sorry for my misunderstanding and thanks for pointing out that how drm-misc works. So I will pick up the patch and send a pull request. Thanks, Xinliang > > Thanks, Daniel > >> >> Thanks, >> Xinliang >> >> >> > Cc: stable at vger.kernel.org >> > --- >> > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> > b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> > index c96c228..72c6357 100644 >> > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> > @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc >> > *crtc, >> > { >> > struct ade_crtc *acrtc = to_ade_crtc(crtc); >> > struct ade_hw_ctx *ctx = acrtc->ctx; >> > + struct drm_display_mode *mode = &crtc->state->mode; >> > + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode; >> > >> > if (!ctx->power_on) >> > (void)ade_power_up(ctx); >> > + ade_ldi_set_mode(acrtc, mode, adj_mode); >> > } >> > >> > static void ade_crtc_atomic_flush(struct drm_crtc *crtc, >> > -- >> > 2.7.4 >> > >> > _______________________________________________ >> > dri-devel mailing list >> > dri-devel at lists.freedesktop.org >> > https://lists.freedesktop.org/mailman/listinfo/dri-devel >> > > >> _______________________________________________ >> dri-devel mailing list >> dri-devel at lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
next prev parent reply other threads:[~2017-08-28 9:27 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-15 14:14 [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured Peter Griffin 2017-08-15 14:14 ` Peter Griffin 2017-08-28 8:44 ` Xinliang Liu 2017-08-28 8:51 ` Daniel Vetter 2017-08-28 8:51 ` Daniel Vetter 2017-08-28 8:51 ` Daniel Vetter 2017-08-28 9:27 ` Xinliang Liu [this message] 2017-08-28 9:27 ` Xinliang Liu 2017-10-23 17:34 ` Peter Griffin 2017-10-25 1:00 ` liuxinliang -- strict thread matches above, loose matches on Subject: below -- 2017-06-29 20:54 Peter Griffin 2017-06-29 20:54 ` Peter Griffin 2017-06-29 21:10 ` John Stultz 2017-06-29 21:10 ` John Stultz 2017-06-29 21:10 ` John Stultz 2017-06-29 21:10 ` John Stultz 2017-06-30 5:55 ` Greg KH 2017-06-30 5:55 ` Greg KH 2017-06-30 5:55 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGd==0558EHJFdh_+C=Zo11OJDNgbS-BOkj+TvbVKFJkU=gDHg@mail.gmail.com' \ --to=xinliang.liu@linaro.org \ --cc=andrey.konovalov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=guodong.xu@linaro.org \ --cc=kong.kongxinwei@hisilicon.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=peter.griffin@linaro.org \ --cc=puck.chen@hisilicon.com \ --cc=seanpaul@google.com \ --cc=stable@vger.kernel.org \ --cc=z.liuxinliang@hisilicon.com \ --cc=zourongrong@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.