All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Tom Talpey <tom@talpey.com>
Cc: Ralph Boehme <slow@samba.org>, Jeremy Allison <jra@samba.org>,
	Namjae Jeon <linkinjeon@kernel.org>,
	CIFS <linux-cifs@vger.kernel.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Hyunchul Lee <hyc.lee@gmail.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v3 0/5] ksmbd: a bunch of patches
Date: Wed, 29 Sep 2021 12:11:35 -0500	[thread overview]
Message-ID: <CAH2r5mvPy0UBJ2z=gSbyOSK9cMYMdB-Unr4Jk14Fve4W1XFTJQ@mail.gmail.com> (raw)
In-Reply-To: <27908e3e-140e-8c7a-e792-414fec5b5190@talpey.com>

On Wed, Sep 29, 2021 at 11:45 AM Tom Talpey <tom@talpey.com> wrote:
>
> On 9/29/2021 12:38 PM, Ralph Boehme wrote:
> > Am 29.09.21 um 17:42 schrieb Jeremy Allison:
> >> On Wed, Sep 29, 2021 at 11:28:09AM -0400, Tom Talpey wrote:
> >>>
> >>> I completely agree that email is inefficient, but git is a terrible
> >>> way to have a discussion.

Agreed

> >> Maybe send the initial patch to the list with a link
> >> to the github MR so people interested in reviewing/discussing
> >> can follow along there ?
> >
> > well, if I could have it the way I wanted, then this would be it. But I
> > understand that adopting new workflows is not something I can impose --
> > at least not without paying for an insane amount of Lakritz-Gitarren
> > that I tend to use to bribe metze into doing something I want him to do. :)
>
> I'm in for github if you send me some too!

gitnub is fine for many things, and we can automated "kernel
development process"
things presumably with github easier than alternatives:
- running "scripts/checkpatch"
- make with C=1 and "_CHECK_ENDIAN" support turned on
- kick off smbtorture tests (as Namjae already does in his branches in github)

BUT ... we have to ensure a couple things.
- we don't annoy Linus (and linux-next and stable maintainers) by doing things
like web merges in github (he complained about the meaningless/distracting
github web ui empty merge messages)
- we don't miss reviewers in Linux who also want to see them on
mailing lists (presumably
some of fsdevel - ie more general patches that other fs developers outside
smb world need to comment on)


> >
> > Once such a collaboratively worked on patchset stabilizes, it can of
> > course again go to the mailing list.

Makes sense


-- 
Thanks,

Steve

  parent reply	other threads:[~2021-09-29 17:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 13:55 [PATCH v3 0/5] ksmbd: a bunch of patches Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 1/5] ksmbd: add the check to vaildate if stream protocol length exceeds maximum value Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 2/5] ksmbd: add validation in smb2_ioctl Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 3/5] ksmbd: add request buffer validation in smb2_set_info Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 4/5] ksmbd: check strictly data area in ksmbd_smb2_check_message() Namjae Jeon
2021-09-26 13:55 ` [PATCH v3 5/5] ksmbd: add validation in smb2 negotiate Namjae Jeon
2021-09-26 14:27 ` [PATCH v3 0/5] ksmbd: a bunch of patches Ralph Boehme
2021-09-26 15:32   ` Namjae Jeon
2021-09-27 15:42 ` Ralph Boehme
2021-09-27 23:57   ` Namjae Jeon
2021-09-28  3:26     ` Ralph Boehme
2021-09-28 13:43       ` Ralph Boehme
2021-09-28 14:23         ` Namjae Jeon
2021-09-28 16:33           ` Ralph Boehme
2021-09-28 17:33             ` Jeremy Allison
2021-09-29 15:28               ` Tom Talpey
2021-09-29 15:42                 ` Jeremy Allison
2021-09-29 16:38                   ` Ralph Boehme
2021-09-29 16:45                     ` Tom Talpey
2021-09-29 17:08                       ` Ralph Boehme
2021-09-29 17:11                       ` Steve French [this message]
2021-09-29 17:18                         ` Ralph Boehme
2021-09-30  0:32                           ` Namjae Jeon
2021-09-30  0:51                             ` Hyunchul Lee
2021-09-30  7:57                             ` Ralph Boehme
2021-09-28 23:27           ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5mvPy0UBJ2z=gSbyOSK9cMYMdB-Unr4Jk14Fve4W1XFTJQ@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=hyc.lee@gmail.com \
    --cc=jra@samba.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=slow@samba.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.