Re: [PATCH v3 0/5] ksmbd: a bunch of patches

From: Ralph Boehme <slow@samba.org>
To: Jeremy Allison <jra@samba.org>, Tom Talpey <tom@talpey.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
	linux-cifs@vger.kernel.org,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Steve French <smfrench@gmail.com>,
	Hyunchul Lee <hyc.lee@gmail.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v3 0/5] ksmbd: a bunch of patches
Date: Wed, 29 Sep 2021 18:38:15 +0200	[thread overview]
Message-ID: <ce52c130-74de-feaa-6995-6a0d947816a6@samba.org> (raw)
In-Reply-To: <YVSJWPa8dalyzsl0@jeremy-acer>

[-- Attachment #1.1: Type: text/plain, Size: 1910 bytes --]

Am 29.09.21 um 17:42 schrieb Jeremy Allison:
> On Wed, Sep 29, 2021 at 11:28:09AM -0400, Tom Talpey wrote:
>>
>> I completely agree that email is inefficient, but git is a terrible
>> way to have a discussion. We should attempt to be sure we have
>> those, and that everybody has a chance to see the proposals without
>> having to go to the web five times a day.
>>
>> Please take this as a request for regular git-send-email updates to
>> this list, so I can see them if I'm not online. Maybe add a boilerplate
>> line to direct to the git repo webui. I'm sure a few others will
>> appreciate it too.
> 
> Samba does well with the web-based discussion mechanism
> around merge-requests (MR's) in gitlab. I assume github
> has something similar.
> 
> Maybe send the initial patch to the list with a link
> to the github MR so people interested in reviewing/discussing
> can follow along there ?

well, if I could have it the way I wanted, then this would be it. But I 
understand that adopting new workflows is not something I can impose -- 
at least not without paying for an insane amount of Lakritz-Gitarren 
that I tend to use to bribe metze into doing something I want him to do. :)

The problem is not so much doing the *review* on patches sent to the 
list. While Samba has moved away from doing review on patch emails, it 
can certainly be done.

The point is, once you go beyond "review" by taking someone else's 
patchset, modifying it deeply, reordering patches, adding patches, 
rewriting patches, dropping patches and so on, that's when the 
patchset-as-email workflow explodes and coordination via git is needed.

Once such a collaboratively worked on patchset stabilizes, it can of 
course again go to the mailing list.

-slow

-- 
Ralph Boehme, Samba Team                 https://samba.org/
SerNet Samba Team Lead      https://sernet.de/en/team-samba

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]