* [PATCH] fs: fat: directory entries starting with 0x05
@ 2020-11-21 12:22 Heinrich Schuchardt
2020-11-23 1:28 ` Simon Glass
2020-11-23 7:03 ` Christian Gmeiner
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2020-11-21 12:22 UTC (permalink / raw)
To: u-boot
0x05 is used as replacement letter for 0xe5 at the first position of short
file names. We must not skip over directory entries starting with 0x05.
Cf. Microsoft FAT Specification, August 30 2005
Fixes: 39606d462c97 ("fs: fat: handle deleted directory entries correctly")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
fs/fat/fat.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index 28aa5aaa9f..fb6ba89466 100644
--- a/fs/fat/fat.c
+++ b/fs/fat/fat.c
@@ -926,8 +926,7 @@ static int fat_itr_next(fat_itr *itr)
if (!dent)
return 0;
- if (dent->name[0] == DELETED_FLAG ||
- dent->name[0] == aRING)
+ if (dent->name[0] == DELETED_FLAG)
continue;
if (dent->attr & ATTR_VOLUME) {
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] fs: fat: directory entries starting with 0x05
2020-11-21 12:22 [PATCH] fs: fat: directory entries starting with 0x05 Heinrich Schuchardt
@ 2020-11-23 1:28 ` Simon Glass
2020-11-23 7:03 ` Christian Gmeiner
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2020-11-23 1:28 UTC (permalink / raw)
To: u-boot
On Sat, 21 Nov 2020 at 05:22, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> 0x05 is used as replacement letter for 0xe5 at the first position of short
> file names. We must not skip over directory entries starting with 0x05.
>
> Cf. Microsoft FAT Specification, August 30 2005
>
> Fixes: 39606d462c97 ("fs: fat: handle deleted directory entries correctly")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> fs/fat/fat.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] fs: fat: directory entries starting with 0x05
2020-11-21 12:22 [PATCH] fs: fat: directory entries starting with 0x05 Heinrich Schuchardt
2020-11-23 1:28 ` Simon Glass
@ 2020-11-23 7:03 ` Christian Gmeiner
1 sibling, 0 replies; 3+ messages in thread
From: Christian Gmeiner @ 2020-11-23 7:03 UTC (permalink / raw)
To: u-boot
Am Sa., 21. Nov. 2020 um 13:22 Uhr schrieb Heinrich Schuchardt
<xypron.glpk@gmx.de>:
>
> 0x05 is used as replacement letter for 0xe5 at the first position of short
> file names. We must not skip over directory entries starting with 0x05.
>
> Cf. Microsoft FAT Specification, August 30 2005
>
> Fixes: 39606d462c97 ("fs: fat: handle deleted directory entries correctly")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-23 7:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-21 12:22 [PATCH] fs: fat: directory entries starting with 0x05 Heinrich Schuchardt
2020-11-23 1:28 ` Simon Glass
2020-11-23 7:03 ` Christian Gmeiner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.