From: Adam Ford <aford173@gmail.com> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, linux-mtd@lists.infradead.org, Julien Su <juliensu@mxic.com.tw>, ycllin@mxic.com.tw, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Linux-OMAP <linux-omap@vger.kernel.org> Subject: Re: [PATCH 04/20] mtd: nand: ecc-bch: Stop exporting the private structure Date: Tue, 19 Jan 2021 09:49:36 -0600 [thread overview] Message-ID: <CAHCN7xKtSwEDEXwU=df0FYzL0ivrWser0-kioW2BSrfU+XQFWQ@mail.gmail.com> (raw) In-Reply-To: <20210119153521.7d5de79d@xps13> On Tue, Jan 19, 2021 at 8:36 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Hi Adam, > > > > ---8<--- > > > > > > Author: Miquel Raynal <miquel.raynal@bootlin.com> > > > Date: Tue Jan 19 12:27:07 2021 +0100 > > > > > > wip: fix omap > > > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > > Thanks for fixing this. > > > > I tested your patch, and I no longer get a Panic and the MTD device > > appears to appear correctly: > > > > mtdoops: mtd device (mtddev=name/number) must be supplied > > omap2-nand 30000000.nand: GPIO lookup for consumer rb > > omap2-nand 30000000.nand: using device tree for GPIO lookup > > of_get_named_gpiod_flags: parsed 'rb-gpios' property of node > > '/ocp@68000000/gpmc@6e000000/nand@0,0[0]' - status (0) > > gpio gpiochip6: Persistence not supported for GPIO 0 > > nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xbc > > nand: Micron MT29F4G16ABBDA3W > > nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 > > nand: using OMAP_ECC_BCH8_CODE_HW_DETECTION_SW > > 6 cmdlinepart partitions found on MTD device omap2-nand.0 > > Creating 6 MTD partitions on "omap2-nand.0": > > ... > > Good to know. Can you just tell me if the values of > - chip->ecc.bytes vs. engine_conf->code_size > - chip->ecc.steps vs. engine_conf->nsteps > are the same in both cases (your patch and mine)? Otherwise your data > might appear corrupted somehow. I didn't fully vet my hack, beyond eliminating the Kernel panic, so I felt more comfortable comparing the values to a stable release. I compared the values in 5.10 to 5.11-rc4 + your patch, and the number of steps and oobregion->length are identical between them. 5.10.5: chip->ecc.steps = 4 oobregion->length = d 5.11-rc4 + patch: engine_conf->nsteps = 4 oobregion->length = d adam > > > > > When you submit a formal patch, CC me on the patch, and I'll respond > > with a 'tested-by' > > Of course, I'll also add a Reported-by. > > Thanks, > Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Adam Ford <aford173@gmail.com> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, Julien Su <juliensu@mxic.com.tw>, Richard Weinberger <richard@nod.at>, ycllin@mxic.com.tw, linux-mtd@lists.infradead.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Linux-OMAP <linux-omap@vger.kernel.org> Subject: Re: [PATCH 04/20] mtd: nand: ecc-bch: Stop exporting the private structure Date: Tue, 19 Jan 2021 09:49:36 -0600 [thread overview] Message-ID: <CAHCN7xKtSwEDEXwU=df0FYzL0ivrWser0-kioW2BSrfU+XQFWQ@mail.gmail.com> (raw) In-Reply-To: <20210119153521.7d5de79d@xps13> On Tue, Jan 19, 2021 at 8:36 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Hi Adam, > > > > ---8<--- > > > > > > Author: Miquel Raynal <miquel.raynal@bootlin.com> > > > Date: Tue Jan 19 12:27:07 2021 +0100 > > > > > > wip: fix omap > > > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > > Thanks for fixing this. > > > > I tested your patch, and I no longer get a Panic and the MTD device > > appears to appear correctly: > > > > mtdoops: mtd device (mtddev=name/number) must be supplied > > omap2-nand 30000000.nand: GPIO lookup for consumer rb > > omap2-nand 30000000.nand: using device tree for GPIO lookup > > of_get_named_gpiod_flags: parsed 'rb-gpios' property of node > > '/ocp@68000000/gpmc@6e000000/nand@0,0[0]' - status (0) > > gpio gpiochip6: Persistence not supported for GPIO 0 > > nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xbc > > nand: Micron MT29F4G16ABBDA3W > > nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 > > nand: using OMAP_ECC_BCH8_CODE_HW_DETECTION_SW > > 6 cmdlinepart partitions found on MTD device omap2-nand.0 > > Creating 6 MTD partitions on "omap2-nand.0": > > ... > > Good to know. Can you just tell me if the values of > - chip->ecc.bytes vs. engine_conf->code_size > - chip->ecc.steps vs. engine_conf->nsteps > are the same in both cases (your patch and mine)? Otherwise your data > might appear corrupted somehow. I didn't fully vet my hack, beyond eliminating the Kernel panic, so I felt more comfortable comparing the values to a stable release. I compared the values in 5.10 to 5.11-rc4 + your patch, and the number of steps and oobregion->length are identical between them. 5.10.5: chip->ecc.steps = 4 oobregion->length = d 5.11-rc4 + patch: engine_conf->nsteps = 4 oobregion->length = d adam > > > > > When you submit a formal patch, CC me on the patch, and I'll respond > > with a 'tested-by' > > Of course, I'll also add a Reported-by. > > Thanks, > Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-01-19 15:51 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-29 23:01 [PATCH 00/20] Create generic software ECC engines Miquel Raynal 2020-09-29 23:01 ` [PATCH 01/20] mtd: nand: ecc: Add an I/O request tweaking mechanism Miquel Raynal 2020-09-30 7:53 ` Thomas Petazzoni 2020-09-30 8:16 ` Miquel Raynal 2020-10-30 17:30 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 02/20] mtd: nand: ecc-bch: Move BCH code to the generic NAND layer Miquel Raynal 2020-10-30 17:30 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 03/20] mtd: nand: ecc-bch: Cleanup and style fixes Miquel Raynal 2020-10-30 17:30 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 04/20] mtd: nand: ecc-bch: Stop exporting the private structure Miquel Raynal 2021-01-09 14:46 ` Adam Ford 2021-01-09 14:46 ` Adam Ford 2021-01-11 10:20 ` Miquel Raynal 2021-01-11 10:20 ` Miquel Raynal 2021-01-12 14:35 ` Miquel Raynal 2021-01-12 14:35 ` Miquel Raynal 2021-01-12 16:01 ` Adam Ford 2021-01-12 16:01 ` Adam Ford 2021-01-12 17:20 ` Adam Ford 2021-01-12 17:20 ` Adam Ford 2021-01-14 15:42 ` Miquel Raynal 2021-01-14 15:42 ` Miquel Raynal 2021-01-15 12:23 ` Adam Ford 2021-01-15 12:23 ` Adam Ford 2021-01-15 16:06 ` Adam Ford 2021-01-15 16:06 ` Adam Ford 2021-01-15 16:17 ` Miquel Raynal 2021-01-15 16:17 ` Miquel Raynal 2021-01-15 16:28 ` Adam Ford 2021-01-15 16:28 ` Adam Ford 2021-01-19 11:56 ` Miquel Raynal 2021-01-19 11:56 ` Miquel Raynal 2021-01-19 14:21 ` Adam Ford 2021-01-19 14:21 ` Adam Ford 2021-01-19 14:36 ` Miquel Raynal 2021-01-19 14:36 ` Miquel Raynal 2021-01-19 15:49 ` Adam Ford [this message] 2021-01-19 15:49 ` Adam Ford 2021-01-19 15:53 ` Miquel Raynal 2021-01-19 15:53 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 05/20] mtd: nand: ecc-bch: Return only valid error codes Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 06/20] mtd: nand: ecc-bch: Drop mtd_nand_has_bch() Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 07/20] mtd: nand: ecc-bch: Update the prototypes to be more generic Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 08/20] mtd: nand: ecc-bch: Stop using raw NAND structures Miquel Raynal 2020-09-29 23:01 ` [PATCH 09/20] mtd: nand: ecc-bch: Create the software BCH engine Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 10/20] mtd: rawnand: Get rid of chip->ecc.priv Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 11/20] mtd: nand: ecc-hamming: Move Hamming code to the generic NAND layer Miquel Raynal 2020-09-29 23:01 ` [PATCH 12/20] mtd: nand: ecc-hamming: Clarify the driver descriptions Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 13/20] mtd: nand: ecc-hamming: Drop/fix the kernel doc Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 14/20] mtd: nand: ecc-hamming: Cleanup and style fixes Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 15/20] mtd: nand: ecc-hamming: Rename the exported functions Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 16/20] mtd: nand: ecc-hamming: Stop using raw NAND structures Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 17/20] mtd: nand: ecc-hamming: Remove useless includes Miquel Raynal 2020-09-29 23:01 ` [PATCH 18/20] mtd: nand: ecc-hamming: Let the software Hamming ECC engine be unselected Miquel Raynal 2020-10-30 17:29 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 19/20] mtd: nand: ecc-hamming: Create the software Hamming engine Miquel Raynal 2020-10-30 17:28 ` Miquel Raynal 2020-09-29 23:01 ` [PATCH 20/20] mtd: nand: Let software ECC engines be retrieved from the NAND core Miquel Raynal 2020-10-30 17:28 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHCN7xKtSwEDEXwU=df0FYzL0ivrWser0-kioW2BSrfU+XQFWQ@mail.gmail.com' \ --to=aford173@gmail.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=juliensu@mxic.com.tw \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=thomas.petazzoni@bootlin.com \ --cc=vigneshr@ti.com \ --cc=ycllin@mxic.com.tw \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.